From: Bernhard Nortmann <bernhard.nortmann@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v3 0/5] fix NetConsole for CONFIG_DM_ETH
Date: Mon, 14 Sep 2015 15:29:42 +0200 [thread overview]
Message-ID: <1442237387-29474-1-git-send-email-bernhard.nortmann@web.de> (raw)
(I'm resending this as patch 1/5 is still requiring an ACK/NAK.)
With the introduction of driver model and accompanying changes,
outdated code in netconsole.c leads to compilation errors when both
CONFIG_NETCONSOLE and CONFIG_DM_ETH are set.
This is a series of patches to fix these issues and get NetConsole
working again with DM_ETH. v2 adds some proper subsystem prefixes
on the commit messages, and enables a test case (sunxi board
configuration for Banana Pi/Pro) that combines CONFIG_DM_ETH and
CONFIG_NETCONSOLE. v3 adds some ACKs by J. Hershberger and a fix
to make proper use of dev_get_uclass_priv().
I have tested the resulting code on my Banana Pi (sun7i / Allwinner
A20) and had a functional NetConsole again. I also backported
eth_is_active() and the netconsole.c changes to v2015.04, to make
sure they properly worked in case CONFIG_DM_ETH is absent
(v2015.04 predates the introduction of DM_ETH, and I'm lacking
other hardware to test CONFIG_NETCONSOLE with).
Regards, B. Nortmann
Changes in v3:
- use dev_get_uclass_priv()
Changes in v2:
- add "net:" prefix to commit message
- add "net:" prefix to commit message
Bernhard Nortmann (5):
net: expose eth_is_active() function to test network device state
net: fix netconsole when CONFIG_DM_ETH is set
net: avoid eth_unregister() call when function is unavailable
net: support NETCONSOLE option via Kconfig
sunxi: add NetConsole by default for Banana Pi/Pro
common/bootm.c | 2 ++
configs/Bananapi_defconfig | 3 ++-
configs/Bananapro_defconfig | 3 ++-
drivers/net/netconsole.c | 14 +++++++++++---
include/net.h | 6 ++++++
net/Kconfig | 6 ++++++
net/eth.c | 18 +++++++++++++++++-
7 files changed, 46 insertions(+), 6 deletions(-)
--
2.4.6
next reply other threads:[~2015-09-14 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 13:29 Bernhard Nortmann [this message]
2015-09-14 13:29 ` [U-Boot] [RESEND PATCH v3 1/5] net: expose eth_is_active() function to test network device state Bernhard Nortmann
2015-09-14 21:26 ` Joe Hershberger
2015-09-30 17:22 ` Joe Hershberger
2015-09-14 13:29 ` [U-Boot] [RESEND PATCH v3 2/5] net: fix netconsole when CONFIG_DM_ETH is set Bernhard Nortmann
2015-09-30 17:22 ` Joe Hershberger
2015-09-14 13:29 ` [U-Boot] [RESEND PATCH v3 3/5] net: avoid eth_unregister() call when function is unavailable Bernhard Nortmann
2015-09-30 17:22 ` Joe Hershberger
2015-09-14 13:29 ` [U-Boot] [RESEND PATCH v3 4/5] net: support NETCONSOLE option via Kconfig Bernhard Nortmann
2015-09-30 17:23 ` Joe Hershberger
2015-09-14 13:29 ` [U-Boot] [RESEND PATCH v3 5/5] sunxi: add NetConsole by default for Banana Pi/Pro Bernhard Nortmann
2015-09-30 17:23 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442237387-29474-1-git-send-email-bernhard.nortmann@web.de \
--to=bernhard.nortmann@web.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.