From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755684AbbINNtD (ORCPT ); Mon, 14 Sep 2015 09:49:03 -0400 Received: from mail-yk0-f182.google.com ([209.85.160.182]:36172 "EHLO mail-yk0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbbINNqF (ORCPT ); Mon, 14 Sep 2015 09:46:05 -0400 From: Jeff Layton X-Google-Original-From: Jeff Layton To: Al Viro Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] fs: export flush_delayed_fput Date: Mon, 14 Sep 2015 09:45:55 -0400 Message-Id: <1442238355-8203-5-git-send-email-jeff.layton@primarydata.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1442238355-8203-1-git-send-email-jeff.layton@primarydata.com> References: <1442238355-8203-1-git-send-email-jeff.layton@primarydata.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ...and clean up the comments over it a bit. Signed-off-by: Jeff Layton --- fs/file_table.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/file_table.c b/fs/file_table.c index 1ad2e3fd2064..2b145b513274 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -246,19 +246,19 @@ static void ____fput(struct callback_head *work) static DECLARE_DELAYED_WORK(delayed_fput_work, delayed_fput); /* - * If kernel thread really needs to have the final fput() it has done - * to complete, call this. The only user right now is the boot - we - * *do* need to make sure our writes to binaries on initramfs has - * not left us with opened struct file waiting for __fput() - execve() - * won't work without that. Please, don't add more callers without - * very good reasons; in particular, never call that with locks - * held and never call that from a thread that might need to do - * some work on any kind of umount. + * If kernel thread or task that has used fput_queue really needs to have the + * final fput() it has done to complete, call this. The only user right now is + * the boot - we *do* need to make sure our writes to binaries on initramfs has + * not left us with opened struct file waiting for __fput() - execve() won't + * work without that. Please, don't add more callers without very good + * reasons; in particular, never call that with locks held and never call that + * from a thread that might need to do some work on any kind of umount. */ void flush_delayed_fput(void) { flush_delayed_work(&delayed_fput_work); } +EXPORT_SYMBOL(flush_delayed_fput); /** * fput - put a struct file reference -- 2.4.3