From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 14 Sep 2015 15:09:46 +0000 Subject: Re: [PATCH] powerpc/e500: move qemu machine spec together with the rest Message-Id: <1442243386.2909.62.camel@freescale.com> List-Id: References: <55E992AE.3010605@freescale.com> In-Reply-To: <55E992AE.3010605@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ppc@vger.kernel.org On Mon, 2015-09-14 at 16:14 +0200, Alexander Graf wrote: > > Am 14.09.2015 um 15:17 schrieb Laurentiu Tudor : > > > > > On 09/10/2015 02:01 AM, Scott Wood wrote: > > > > On Fri, 2015-09-04 at 15:46 +0300, Laurentiu Tudor wrote: > > > > This way we get rid of an entire file with mostly > > > > duplicated code plus a Kconfig option that you always > > > > had to take care to check it in order for kvm to work. > > > > > > > > Signed-off-by: Laurentiu Tudor > > > > --- > > > > arch/powerpc/platforms/85xx/Kconfig | 15 ----- > > > > arch/powerpc/platforms/85xx/Makefile | 1 - > > > > arch/powerpc/platforms/85xx/corenet_generic.c | 1 + > > > > arch/powerpc/platforms/85xx/qemu_e500.c | 85 ------------------- > > > > ----- > > > > > > > > > qemu_e500 is not only for corenet chips. > > > > That's too bad. :-( > > I remember discussions on dropping the e500v2 support at some point in > > time? > > > > > We can add it to the defconfig (in fact I've been meaning to do so). > > > > Or maybe just drop de KConfig option and > > wrap the file in an #ifdef CONFIG_KVM or something along these lines? > > CONFIG_KVM is for host support though. This is for the guest kernel. CONFIG_QEMU_E500 can also be used with TCG -- it's not KVM-specific. -Scott