From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32800)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZbkO4-0002Qf-17
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 03:10:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZbkO0-0001nv-Qy
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 03:10:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37754)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZbkO0-0001nl-Lm
	for qemu-devel@nongnu.org; Tue, 15 Sep 2015 03:10:40 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id 3E740461DB
	for <qemu-devel@nongnu.org>; Tue, 15 Sep 2015 07:10:40 +0000 (UTC)
Message-ID: <1442301038.2895.5.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 15 Sep 2015 09:10:38 +0200
In-Reply-To: <55F6F384.1040107@redhat.com>
References: <1441797654-15350-1-git-send-email-kraxel@redhat.com>
	<1441797654-15350-2-git-send-email-kraxel@redhat.com>
	<55F6EF34.4010703@redhat.com> <55F6F384.1040107@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org

> > Therefore, I'm not sure whether deleting the buffer is right here. Maybe
> > OpenGL uses reference counting here, too, so it remembers that the
> > buffer is still in use by the VAO, and so the glDeleteBuffers()
> > operation will only decrease its refcount, but not actually end up
> > deleting it.

Hmm, my docs sayed it's refcounted and as long as the vao uses it
everything should be fine ...

> Oh, and I just noticed: With glDeleteBuffers(), I get a segmentation
> fault when qemu exits (somewhere deep in fglrx_dri.so). Without, the
> segfault disappears.

... but appearently it isn't.  Ok, dropping the glDeleteBuffers call.
It isn't freed anyway until qemu exits, so at the end of the day it
doesn't matter much.

cheers,
  Gerd