* [PATCH net] net/mlx4_en:
@ 2015-09-16 1:26 Eric Dumazet
2015-09-16 1:28 ` Eric Dumazet
2015-09-16 1:29 ` [PATCH v2 net] net/mlx4_en: really allow to change RSS key Eric Dumazet
0 siblings, 2 replies; 5+ messages in thread
From: Eric Dumazet @ 2015-09-16 1:26 UTC (permalink / raw
To: David Miller; +Cc: netdev, Eyal Perry, Amir Vadai
From: Eric Dumazet <edumazet@google.com>
When changing rss key, we do not want to overwrite user provided key
by the one provided by netdev_rss_key_fill(), which is the host random
key generated at boot time.
Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eyal Perry <eyalpe@mellanox.com>
CC: Amir Vadai <amirv@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 4402a1e48c9b..0ce6ffe73ca8 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -1268,8 +1268,6 @@ int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv)
rss_context->hash_fn = MLX4_RSS_HASH_TOP;
memcpy(rss_context->rss_key, priv->rss_key,
MLX4_EN_RSS_KEY_SIZE);
- netdev_rss_key_fill(rss_context->rss_key,
- MLX4_EN_RSS_KEY_SIZE);
} else {
en_err(priv, "Unknown RSS hash function requested\n");
err = -EINVAL;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net] net/mlx4_en:
2015-09-16 1:26 [PATCH net] net/mlx4_en: Eric Dumazet
@ 2015-09-16 1:28 ` Eric Dumazet
2015-09-16 1:29 ` [PATCH v2 net] net/mlx4_en: really allow to change RSS key Eric Dumazet
1 sibling, 0 replies; 5+ messages in thread
From: Eric Dumazet @ 2015-09-16 1:28 UTC (permalink / raw
To: David Miller; +Cc: netdev, Eyal Perry, Amir Vadai
Arg, patch title was meant to be
net/mlx4_en: really allow to change RSS key
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 net] net/mlx4_en: really allow to change RSS key
2015-09-16 1:26 [PATCH net] net/mlx4_en: Eric Dumazet
2015-09-16 1:28 ` Eric Dumazet
@ 2015-09-16 1:29 ` Eric Dumazet
2015-09-16 11:05 ` Or Gerlitz
1 sibling, 1 reply; 5+ messages in thread
From: Eric Dumazet @ 2015-09-16 1:29 UTC (permalink / raw
To: David Miller; +Cc: netdev, Eyal Perry, Amir Vadai
From: Eric Dumazet <edumazet@google.com>
When changing rss key, we do not want to overwrite user provided key
by the one provided by netdev_rss_key_fill(), which is the host random
key generated at boot time.
Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eyal Perry <eyalpe@mellanox.com>
CC: Amir Vadai <amirv@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
index 4402a1e48c9b..0ce6ffe73ca8 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
@@ -1268,8 +1268,6 @@ int mlx4_en_config_rss_steer(struct mlx4_en_priv *priv)
rss_context->hash_fn = MLX4_RSS_HASH_TOP;
memcpy(rss_context->rss_key, priv->rss_key,
MLX4_EN_RSS_KEY_SIZE);
- netdev_rss_key_fill(rss_context->rss_key,
- MLX4_EN_RSS_KEY_SIZE);
} else {
en_err(priv, "Unknown RSS hash function requested\n");
err = -EINVAL;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 net] net/mlx4_en: really allow to change RSS key
2015-09-16 1:29 ` [PATCH v2 net] net/mlx4_en: really allow to change RSS key Eric Dumazet
@ 2015-09-16 11:05 ` Or Gerlitz
2015-09-18 4:04 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Or Gerlitz @ 2015-09-16 11:05 UTC (permalink / raw
To: Eric Dumazet; +Cc: David Miller, netdev, Eyal Perry, Amir Vadai
On Wed, Sep 16, 2015 at 4:29 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> When changing rss key, we do not want to overwrite user provided key
> by the one provided by netdev_rss_key_fill(), which is the host random
> key generated at boot time.
>
> Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Eyal Perry <eyalpe@mellanox.com>
> CC: Amir Vadai <amirv@mellanox.com>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Dave, can you please push it to -stable of >= 3.19 ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 net] net/mlx4_en: really allow to change RSS key
2015-09-16 11:05 ` Or Gerlitz
@ 2015-09-18 4:04 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2015-09-18 4:04 UTC (permalink / raw
To: gerlitz.or; +Cc: eric.dumazet, netdev, eyalpe, amirv
From: Or Gerlitz <gerlitz.or@gmail.com>
Date: Wed, 16 Sep 2015 14:05:25 +0300
> On Wed, Sep 16, 2015 at 4:29 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> From: Eric Dumazet <edumazet@google.com>
>>
>> When changing rss key, we do not want to overwrite user provided key
>> by the one provided by netdev_rss_key_fill(), which is the host random
>> key generated at boot time.
>>
>> Fixes: 947cbb0ac242 ("net/mlx4_en: Support for configurable RSS hash function")
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Cc: Eyal Perry <eyalpe@mellanox.com>
>> CC: Amir Vadai <amirv@mellanox.com>
>
> Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
>
> Dave, can you please push it to -stable of >= 3.19 ?
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-18 4:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 1:26 [PATCH net] net/mlx4_en: Eric Dumazet
2015-09-16 1:28 ` Eric Dumazet
2015-09-16 1:29 ` [PATCH v2 net] net/mlx4_en: really allow to change RSS key Eric Dumazet
2015-09-16 11:05 ` Or Gerlitz
2015-09-18 4:04 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.