From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Drozdov <al.drozdov@gmail.com>
Cc: Tom Herbert <tom@herbertland.com>,
davem@davemloft.net, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [net-next,1/2] net: Set sk_txhash from a random number
Date: Tue, 08 Dec 2015 05:15:59 -0800 [thread overview]
Message-ID: <1449580559.7632.10.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <566695D6.6060603@gmail.com>
On Tue, 2015-12-08 at 11:33 +0300, Alexander Drozdov wrote:
> 29.07.2015 02:02, Tom Herbert wrote:
> > This patch creates sk_set_txhash and eliminates protocol specific
> > inet_set_txhash and ip6_set_txhash. sk_set_txhash simply sets a
> > random number instead of performing flow dissection. sk_set_txash
> > is also allowed to be called multiple times for the same socket,
> > we'll need this when redoing the hash for negative routing advice.
> It seems that this patch and some previous txhash-related
> ones break af_packet hash features for outgoing packets:
> - PACKET_FANOUT_HASH
> - TP_FT_REQ_FILL_RXHASH
>
> af_packet now thinks that hashes for for incoming and outgoing
> packets of the same TCP stream differ. That is true for TCP
> sessions initiated by the host.
There never has been such guarantee. Even rx hashes for a single TCP
flow can differ, if packets are received on two different NIC with
different RSSS keys.
next prev parent reply other threads:[~2015-12-08 13:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 23:02 [PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs Tom Herbert
2015-07-28 23:02 ` [PATCH net-next 1/2] net: Set sk_txhash from a random number Tom Herbert
2015-07-29 9:13 ` Thomas Graf
2015-07-29 9:29 ` Eric Dumazet
2015-07-29 9:54 ` Thomas Graf
2015-07-29 10:06 ` Eric Dumazet
2015-07-29 10:47 ` Thomas Graf
2015-07-29 15:58 ` Tom Herbert
2015-07-29 20:02 ` Thomas Graf
2015-12-08 8:33 ` [net-next,1/2] " Alexander Drozdov
2015-12-08 13:15 ` Eric Dumazet [this message]
2015-12-08 16:33 ` Tom Herbert
2015-12-09 11:14 ` Alexander Drozdov
2015-07-28 23:02 ` [PATCH net-next 2/2] net: Recompute sk_txhash on negative routing advice Tom Herbert
2015-07-30 5:44 ` [PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449580559.7632.10.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=al.drozdov@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.