From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871AbbLHXPz (ORCPT ); Tue, 8 Dec 2015 18:15:55 -0500 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:43521 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbLHXPy (ORCPT ); Tue, 8 Dec 2015 18:15:54 -0500 Message-ID: <1449616550.2384.39.camel@tiscali.nl> Subject: Re: [PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from release method From: Paul Bolle To: Tilman Schmidt , netdev@vger.kernel.org Cc: Peter Hurley , Sasha Levin , syzkaller@googlegroups.com, David Miller , Karsten Keil , isdn4linux@listserv.isdn4linux.de, gigaset307x-common@lists.sourceforge.net, linux-kernel@vger.kernel.org Date: Wed, 09 Dec 2015 00:15:50 +0100 In-Reply-To: <61b60d7eff05eddf305460f3dae2b80221f08aad.1449570042.git.tilman@imap.cc> References: <61b60d7eff05eddf305460f3dae2b80221f08aad.1449570042.git.tilman@imap.cc> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tilman, On di, 2015-12-08 at 12:00 +0100, Tilman Schmidt wrote: > device->platform_data and platform_device->resource are never used > and remain NULL through their entire life. Drops the kfree() calls > for them from the device release method. > > Signed-off-by: Tilman Schmidt > Reported-by: Paul Bolle s/Reported-by/Acked-by/ (Having both lines would be overdoing things.) Thanks, Paul Bolle