From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxl: update check-xl-disk-parse
Date: Wed, 9 Dec 2015 10:32:57 +0000
Message-ID: <1449657177.16124.177.camel@citrix.com>
References: <1449604931-1477-1-git-send-email-wei.liu2@citrix.com>
	<1449655577.16124.166.camel@citrix.com>
	<20151209101535.GB23818@citrix.com>
	<20151209102426.GC23818@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=778267b00=Ian.Campbell@citrix.com>)
	id 1a6c4W-0007T5-0N
	for xen-devel@lists.xenproject.org; Wed, 09 Dec 2015 10:34:08 +0000
In-Reply-To: <20151209102426.GC23818@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Jim Fehlig <jfehlig@suse.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-12-09 at 10:24 +0000, Wei Liu wrote:
> On Wed, Dec 09, 2015 at 10:15:35AM +0000, Wei Liu wrote:
> > On Wed, Dec 09, 2015 at 10:06:17AM +0000, Ian Campbell wrote:
> > > On Tue, 2015-12-08 at 20:02 +0000, Wei Liu wrote:
> > > > The block-attach command now returns 1 when fails. Update first
> > > > test
> > > > case to expect return value 1 instead of 255.
> > > > 
> > > > The parser now doesn't generate output for default values. Remove
> > > > them
> > > > from expected output.
> > > 
> > > This it looks good.
> > > 
> > > > The "discard=" variant is never not supported, so delete two test
> > > > cases
> > > > with that variant.
> > > 
> > > I don't follow (the double negative "never not" doesn't help).
> > > 
> > 
> > Duh, I didn't intend to use double negation.

You meant "...was never supported..." then I think?

> > > However, assuming you are saying that discard= is always supported, I
> > > don't
> > > then see the rationale for removing the test. Of course we do want to
> > > test
> > > things which are supported.
> > > 
> > 
> > No, it is not supported. I dug into mailing list archive last night and
> > confirmed that Ian J asked Olaf to remove such variant. Those test
> > cases
> > were residual from a previous version Olaf failed to remove.
> > 
> 
> Forgot to paste in the references:
> 
> commit 417e6b70d73ffe8f8d3938aa30a413b35098e614 in xen.git
> 
> http://lists.xen.org/archives/html/xen-devel/2014-05/msg01063.html

Thanks, please include the commit reference in the v2 commit for this
change.

Ian.