From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbbLIQuZ (ORCPT ); Wed, 9 Dec 2015 11:50:25 -0500 Received: from mail-bl2on0119.outbound.protection.outlook.com ([65.55.169.119]:48035 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751706AbbLIQuW (ORCPT ); Wed, 9 Dec 2015 11:50:22 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1449679809.15946.167.camel@freescale.com> Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) From: Scott Wood To: Borislav Petkov , Michael Ellerman CC: , Stephen Rothwell , , Johannes Thumshirn Date: Wed, 9 Dec 2015 10:50:09 -0600 In-Reply-To: <20151209160301.GB10518@pd.tnic> References: <20151208154910.78d27c03@canb.auug.org.au> <1449657167.17265.4.camel@ellerman.id.au> <20151209111747.GA10518@pd.tnic> <20151209160301.GB10518@pd.tnic> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:80ce:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR14CA0080.namprd14.prod.outlook.com (25.163.209.176) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:ZPFObd7JNz6eEI+kyYDszXZ9egJU7o2VJ2oCWOo1ZvWsmUNGieoZtCE5ITaVi93xLza/6FbUz8DgTJCGA24lj+jlgOXC4kTDs+Xu+YeE+RlRS5b0aK7/2B3i+dYTbBYSj6Y1RtBjmh9HkpDPkPKb0w==;3:Pcpa/nyhW7YwHTizEhPjSO5DxTAqqF+1QkRV0K9IF8arCinUpsn03au+qnRzPRqM27h0ihSkEqmwYX6nZPyeQ9BBZZF0MBFTFoki0iCoDIMG6Q1u2KVRAKsJqCyn1lBJ;25:Fx3t4ethzvU712sdZWJWWA1mp+6MEAX+luh6qgjOVrGw/ML2l7jpSzIGCnsza5UejXk7FFxjmOjQJ+WyOmCgcjcHs4hdcl2cQhRDnBAtKjwD4JSRHyGt64OVVx6HMafQtmeEZNW0hrwL62kNNSvsvHGMXookFiG0Ciwb65yz4EjKUy/sNc0T/xOw2LSKA77Nmba+Kz8PQpBV/OEkRqq6tYftkGmmgjORVZZafyG6wQgSSJP/xs+uohCcagXe5fCzlT2xRBKCkZJxpzxdZWSS6w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:zCdIqmLIhTQI+mNbiBL96dKhBE701VslNCc7PsGmhJrKXtWP5gp0vK8POtJxfLtQKLusR168hwV+R0Nxgzsxdr3aPKdwwLTwj4K5F+LQFjp+RmK/kwkkENBueB/OxEot1N55E9ho6l60J3/S9Ad4sPSquHAyooDwQCXprMkojCsInfYENuVP8UrZw8fiqjvuCHADbPhLUf6c8u1DO4/H4lCayMni0qdpoee6qVkA3vVOiiIHKty8doR33nx0gPPwDUctG2zdckAJfE0B20CF1p3M9lO7TrEGbTS6WmQ0xsAqoPj5LE00LylQRQSekv2ppABggrcE7ZFFoS+Ynn/oe+x8j/zxV52D0JjfIB3+rLJHso5WHk8P1FasbtbdSB06smw7XssL8LIAsSr/pzVXp1PvNDmzt1FZnUmQCHmWmWiXM0MZsHXTEr8O5un2cHkApgwWulXix7WxDb/0L1qJatomoFf5CMzGjgoQnrv1iohdQm/X9yHFKgF0+Tmb/QVF;4:HkpukVY3ixT40k1WcvXPap3d9OIWiRHP7QTB5uSpU4f8jQ1Vk0iVnTmmD2fRsG9H9GW3bV384aGylg01lgTUCNvzBte60wbbUQU3tlp7GkfoFYpJzOzVDHg50SMjQ8F+rZJzCgi8cl5T5dFRWF3enOHR0/J/lVyESPiKFnL97OeRdK3doskGMbA5QfIoaeSXsFLTNsWZCTQbSUDOL8MkkzBvD4TppcDdNg5sCljH2G9gA9dWy2ZZI85LnxctvtkuHBqi1aHwFBcNlpcGHt/sZMXVjs0wEB/cbECvfX1mMBG60U9OZ+kHc089yrPhzCAc/2cKaXjMIu8TFWKu8Qiv9/AYCFoS2FJYdwibTrdF7FlMRk3OQ+LWWkrpscQ4Hahd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0785459C39 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377424004)(199003)(51914003)(189002)(93886004)(2950100001)(50466002)(40100003)(81156007)(5008740100001)(1706002)(76176999)(230700001)(122386002)(1096002)(50986999)(586003)(6116002)(5004730100002)(23676002)(33646002)(50226001)(87976001)(103116003)(36756003)(5820100001)(86362001)(5001960100002)(5001770100001)(106356001)(189998001)(101416001)(77096005)(105586002)(42186005)(92566002)(97736004)(47776003)(99106002)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:[IPv6:2601:448:8100:80ce:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgyOzIzOnNoK1VEMTFrODRWd29KL1U5VXVJekYvT0tT?= =?utf-8?B?VDlsWUFTMzVpUVdybFdrRUNheVpocVdBRFg4cTNCVGcxOHZYbjFDWUQ3c2ZN?= =?utf-8?B?WENKVkJlaHlBUnVIVGFEM2NJeGwveDJRQm5ab2JEdnVxeGN6d3BNY3hYNWtw?= =?utf-8?B?ekxXcXE2S3l4WG1RNGZEYXlZV1pKOEFTc2tvR0djUjFVaGZ2WTBnOGRlbGZ1?= =?utf-8?B?bFZOV213b0ZvQW1acCtvZ1Q3Q2JjNTNxbXRwc05KemtTWWsrNVk4RjRCU0lv?= =?utf-8?B?dkUyRFNjbEFYbXRndm0vUUp4VGhXazJFcEg1T2pNM1I2aThvWE5vNG9QNEZR?= =?utf-8?B?NnVVTjM4Z2RrejUyY2huT0U5TFNNcFVpMFEzV2FuNWV4TVp2TjdUS29odk9B?= =?utf-8?B?SHArdmhOWVBaelVNc292cklqUW5NZ1NFYitDRnZDRG0rOTJmTm1yRGh4alo3?= =?utf-8?B?YVdWU1RTU0RRT2FoWDZjS1VGQzNWcEd0U0NkejR3cVZEMUhtODNIdTFFcU8w?= =?utf-8?B?MlhyeU5VUFMvRzBLd0JsRkRldUJaU1BvdlRiS0RteFdvSUIxaThMSndVUWNE?= =?utf-8?B?NFBqT3pScnU3TWN0MmNvWXBTZDJNUnBNRm9ZT0pMN0U5eVRFR1RlS2xKWW5R?= =?utf-8?B?VVU0ZXlJMDdkRDU5NDJBd1VueWl3ZFh2VS9iVnJHTjZHSUFhT2FyYUhGTTBh?= =?utf-8?B?RHRQZk5yUUF6ajFzcnRsRTRvUEQ4NUdFZmFBb3NWZW1DcTJPVW9uWVQySlNq?= =?utf-8?B?dFZNdHZERXRpRUp0MU5sZmZXREVjRS9nUE4xNld0S05oalBWRVQ5a29DRmg2?= =?utf-8?B?QUpBZiswaWF3TWorUWZ1WDUzcm1rSGNabFJITjdWS1lTWnp4SUhtcW42M0ZS?= =?utf-8?B?dnVocGdXVkY3VTFZODN4NjA4ejAzcVZwazcvT1A4S1hxNTFoS3pncUNGRUZI?= =?utf-8?B?T2xrWWk3U1hGR2MwTGlCdzlVMGV6ZHFPZ0FQaGQyWmFPU2RVaEdOZFB1a0tk?= =?utf-8?B?TXNuWTZ2RnZwSnBhZXcwNW1LYW9jR0w4Vkp6VHVWN0hxK2pBdkNBaXQ5YXVW?= =?utf-8?B?YzMrZCt1Q3FaL0V1b0VzaEQ5eTI2M0dZWTJNazljbENIaDIvVkdvNHFENVk4?= =?utf-8?B?N1FFaW9NR3BMN2xFOTRLNUlrNk04R3FxTUphditGY3ZmYSszMlZSdFZNYTFq?= =?utf-8?B?eUFidmFoQUFzTkRsa0tCc3EydFZMd0kyWEwvak4xMVlqUzNwQ3poVnVGeGMr?= =?utf-8?B?TFpOcXBVbGNHNmZqTG1GbjdMSHBLNEhQbHl0ZW1JYldUTms5aHVpbUVIVTdx?= =?utf-8?B?VlY0cWJRS2g4ZjVpSjBQelNZSDZ0VkJXU083NWY5QnBpUmhLbmh2TERwak5Q?= =?utf-8?B?QkNQSzRYS1dzVG9UYTNkTHJZUEhwMjRJMTZLWXliYnQ5aUdnUFpyelpKcC9N?= =?utf-8?B?OVJ1dHgvRE4yL3FLVnFEZ0sydlhKaklSRHQ4N1hwNkFSWXN0Q3Q5SFVPc0Zn?= =?utf-8?B?MXVjZz09?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:TnTv/UecMDfKgacL6Tk03ZWDFaBvcOwsEJke5ujsefzc0Z6X7lgIw40oweGaFwdUQ555i4UPO5Qlyv8dAy0TMaO2Acl/i6SG5KqotKdmxawIe9L0OyTerTCHd0P3cJ0BpzkruXRFfERZ5P4me1e5Mw==;24:dGm7Mf8NXiWWO/bCU36RxWsP63uLFAq1PJoCg7zdpqAd4oxd9Nj+Cf5/RFEsoZ7n9NpbWNBuJwMgmAtCEM9NeXmZ6nOgGjghiNOty3rf1LQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2015 16:50:18.4635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-12-09 at 17:03 +0100, Borislav Petkov wrote: > On Wed, Dec 09, 2015 at 12:17:47PM +0100, Borislav Petkov wrote: > > On Wed, Dec 09, 2015 at 09:32:47PM +1100, Michael Ellerman wrote: > > > Presumably caused by the fact that edac_init() is subsys_initcall(), > > > whereas > > > corenet_gen_publish_devices() is arch_initcall(). > > > > Thanks for the report! > > > > Hmm, interesting, can you send .config please? > > > > I need to fix this dependency properly - edac_core needs to have > > finished loaded *before* any other EDAC driver loads. Every other order > > is wrong. > > Yeah, see Johannes' patch. > > Btw, calling a driver's probe function from outside the driver is a new > low in driver design. Tztztz... It's not "a driver's probe function". There is no driver whose .probe() is mpc85xx_pci_err_probe() -- the name is historical. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Date: Wed, 9 Dec 2015 10:50:09 -0600 Message-ID: <1449679809.15946.167.camel@freescale.com> References: <20151208154910.78d27c03@canb.auug.org.au> <1449657167.17265.4.camel@ellerman.id.au> <20151209111747.GA10518@pd.tnic> <20151209160301.GB10518@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bl2on0119.outbound.protection.outlook.com ([65.55.169.119]:48035 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751706AbbLIQuW (ORCPT ); Wed, 9 Dec 2015 11:50:22 -0500 In-Reply-To: <20151209160301.GB10518@pd.tnic> Sender: linux-next-owner@vger.kernel.org List-ID: To: Borislav Petkov , Michael Ellerman Cc: linux-kernel@vger.kernel.org, Stephen Rothwell , linux-next@vger.kernel.org, Johannes Thumshirn On Wed, 2015-12-09 at 17:03 +0100, Borislav Petkov wrote: > On Wed, Dec 09, 2015 at 12:17:47PM +0100, Borislav Petkov wrote: > > On Wed, Dec 09, 2015 at 09:32:47PM +1100, Michael Ellerman wrote: > > > Presumably caused by the fact that edac_init() is subsys_initcall(), > > > whereas > > > corenet_gen_publish_devices() is arch_initcall(). > > > > Thanks for the report! > > > > Hmm, interesting, can you send .config please? > > > > I need to fix this dependency properly - edac_core needs to have > > finished loaded *before* any other EDAC driver loads. Every other order > > is wrong. > > Yeah, see Johannes' patch. > > Btw, calling a driver's probe function from outside the driver is a new > low in driver design. Tztztz... It's not "a driver's probe function". There is no driver whose .probe() is mpc85xx_pci_err_probe() -- the name is historical. -Scott