From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbbLIR5U (ORCPT ); Wed, 9 Dec 2015 12:57:20 -0500 Received: from mail-by2on0142.outbound.protection.outlook.com ([207.46.100.142]:21954 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752854AbbLIR5S (ORCPT ); Wed, 9 Dec 2015 12:57:18 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1449683825.15946.207.camel@freescale.com> Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) From: Scott Wood To: Borislav Petkov CC: Michael Ellerman , , Stephen Rothwell , , Johannes Thumshirn , Date: Wed, 9 Dec 2015 11:57:05 -0600 In-Reply-To: <20151209173829.GD10518@pd.tnic> References: <20151208154910.78d27c03@canb.auug.org.au> <1449657167.17265.4.camel@ellerman.id.au> <20151209111747.GA10518@pd.tnic> <20151209160301.GB10518@pd.tnic> <1449679809.15946.167.camel@freescale.com> <20151209173829.GD10518@pd.tnic> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5-1ubuntu3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:80ce:12bf:48ff:fe84:c9a0] X-ClientProxiedBy: BLUPR19CA0017.namprd19.prod.outlook.com (25.162.230.155) To BY1PR03MB1481.namprd03.prod.outlook.com (25.162.210.14) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;2:kWXzRc1i+GQ7+UW6kbJAZJQEFu8oxFebeFkXUzMWF3KNydsYAHXNsqwo3vsTl+sWMTIU1Y/0AVuGBokXULjZIUGOX9ibFBzZ+99LFgrzeP9XpgFo0BUO1yoxvab0hsWjEnQ6heNjnnNsHigiPDjMYQ==;3:rvEc5ubxrdVPHJ15EYJjEycuNDiDNsefFFBjhffQMAcOjY/OBp83MwWo8TFK7mbYh7yj2LTdqR4iFumPvWqMtc6gIHVB1yXjK2vXniLskS3A+qVDWAmUbQzKayE8IWgz;25:6AyGO9mdQITqd8EXuGX1Kdr7VzbpezfPnVuo9y1pbxK+grH17XFepcIvGIeJbC9mLU+RMHJjfHyEIOKVjHnAzKZSvrFimky1nHsZwlbfO8uiT5rV6Uu0tFbqcR/jlikiGpsPCHdeWuyN/kX1EyGgH2v2qBh0oTKNjNeagC4AoANTJzMfgNc3UOjgh9nXIEfJN65heZjp7A5+Ah4h08lRbeCJQ8PA+EBP08NR3q+lxTlC77f3Y8uQdD+jycdNiZkXlF0TF3fV+CMMMzraFiZCmA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1481; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;20:/bHR+rvKlCVJfzbRXiXAqb8BnGBWMkar5fYYiFghnHOmRIS+Y1bw/X74ycnsF/UkLZdid1eT4BkATYVN+O9LhaxsUBwtVgC0xWXXxR8I0sV1t7iobfIZmJU9jxasfSn7JPh5NYi1gZSGJPGYd0BDBwYDidR0SsYZfpd/noCuQq0BQx8bWDQgSx8XMUGhTvuSgVFp89issulU1uRD7YzRlq7TeFmQzsWhfvKJHjpEGBNEI3WKGRclmRrSwzToNNKDNUNiYEGv/38TWiAsnIC69GQYAfVJd0pVnQWLAG0TP0ZKpBwhrLTUOrPr+qj18rbwEdzfzUpfar+DYUZt1yzxGpFKWTXc0n0jpedtgSowKnaD5Nqw1hU2XN+sjZkW/9gO/SDjPe393rG0N4UOXJ5cQ/w3f8+c4OBbCossBxDMdrAHnUSxEMnfRP1ttfjaPQx4dvg6be1oFLr+B7gKLxLeQSDEG5C4ns447OJZ5MGy1ayTue1JZhAey+su2lLPw8rJ;4:ZHr+t1eEcZA+BlCo74kT1QTcXugaHOKPDxn0fOxEvkGM7F6SHAbXZ6rqMVBHoF44tHOgZcB+NUjDyPyRxf8NENLhFA2KP/1FvrnZBMa+7I8w3ZV9TEfRobLL7YbgBeO1n+GDA1tYoHEBMqvm3vbaZtx12hP0aA+LHdQO9oySCb3TfVI8E+MShrxFbvxsTzorRCh2fP8Fti+op6bdfmnhtYke5yBKpSwhZA3mGhNN1hA/JQpMG6PSj9uB5/uhI58MISEruNEg3Xvsf8DEvqqOcwSB7ugMstZ7Zklu3DBFR0zw4CxqYLVjxMW6YKVxKUJy75NWy5LjHyVMyXCR9T7l3mCZ1pOKe2lG/DorttuvBxEcJb95N3INyOdF6lwXGCeV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:BY1PR03MB1481;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1481; X-Forefront-PRVS: 0785459C39 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(52604005)(377424004)(52544003)(189002)(24454002)(199003)(106356001)(50466002)(50986999)(5001960100002)(47776003)(189998001)(23676002)(93886004)(36756003)(42186005)(105586002)(86362001)(81156007)(1096002)(92566002)(6116002)(230700001)(101416001)(87976001)(1706002)(103116003)(33646002)(122386002)(77096005)(5008740100001)(5004730100002)(5820100001)(76176999)(110136002)(586003)(40100003)(50226001)(2950100001)(97736004)(99106002)(3826002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1481;H:[IPv6:2601:448:8100:80ce:12bf:48ff:fe84:c9a0];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgxOzIzOmgyd1FGRUEvcHBlZVRzR2txdHVJdXVQeFdF?= =?utf-8?B?UzZYTFdUdEtFamZVaTB0ZE1rQWpla1Bzd0JUV0tERlpNSUo4OEI3cUtmVnpk?= =?utf-8?B?MFVISHowa1luZ0U5T1ZjcUNrcldueE9TMnBtaU40MmU5bnlxdTFYNjdKMFJ3?= =?utf-8?B?elVrWjd4RGlkaURRK2kvSk5oWTkwM3dVWjhMbnU0K1dZZmY5Q1RSazNvK0po?= =?utf-8?B?YjJ1ZVM5LzV0T0FXMTE2V0Z6VEhvbzJxMkxFd0kzNEJ6R25LYWtHcytCd0Jy?= =?utf-8?B?ZGs0cE5HRkVhR01SUVVJVlY0Q3JIR3JQV1FBdnYxTE5TN1Y4MHNHbDZVRlJP?= =?utf-8?B?MTNjUk9DQVNEQUVVR1hBRXZuYXZsbHZTRklKekhPaXlvNW1rMjQ4RXhsVzR3?= =?utf-8?B?cnJuRDkyeEFtc3NVd2l5c05YTTk1Wks3Z1RZUkRtNkdmOVlXcCs5M2gwMWMw?= =?utf-8?B?b2VkSmtYTlVCbUpCZTg1NWkydlBkZnVGbXN6bjdxZVg2Q2h5aXZhSlByRDd6?= =?utf-8?B?cHVrVG5wTmRNcEo4NjVBckEvbU5SWkc0TWlsa0oxQW9nVHpYOFZTOXIyeFlx?= =?utf-8?B?T0hxc1dNR1c5cnlvRWlZQi9QTmR6dm5NOHkwY0RONkgyWVo2VjEyT1kyMUxt?= =?utf-8?B?ODNFMkltNWxhTmVLUCtmNk1Lb1FMUnJXM1RsVkU4cWkvcUZXMFVVaThzY2FI?= =?utf-8?B?MlFNRmJLOEtYTFhSZmdVTnIxZHZCV3daeWE2K2VBL0dWRzFkazBqeEZ0TFN4?= =?utf-8?B?dUZENjJuK3NEYzBsNG5VS2VnTXJpL0YwSWRmNjFwSDcwOFNSaWxQOGpPSm0z?= =?utf-8?B?Ym4wNTVNcHlJMXJnbGg3ZVpHeFd1TWJydTJDMDV5Q1hMVkdCaU0yTzREUjR5?= =?utf-8?B?REw3MW8wckNITXJiWlBsUndwNDhVWk5JTExVb2prd0hvRFZJbjlCK1VmRUpN?= =?utf-8?B?OEpGcUZrZm9XWkx4N1RoNi9NR2VWNzlFcEpYd0ZwU1pGa243NnBMOStBczJy?= =?utf-8?B?eHV3QXhWYWZDT1U3Q2piWGtXbFh0elFZRlB2eXROTnZ0SXY2SDk3Nm5BTW1z?= =?utf-8?B?Rys4K0VSU2Q2b25zMlk0NWg1NkM1VWZQQjZHbWVsWXV5RmxIM2k0SkhQSWdl?= =?utf-8?B?YW9ocUNqVzF2Ymg2T1BpeHJ0WUxOTWV1ZHpKYlJWNWRSQkg1eUU3cGFTOENZ?= =?utf-8?B?SC9yNWFOWElVTzh3Z2s0Tk9EeFdXaHc1WU52bFZJN0srcENqUzVuQk5HcGhQ?= =?utf-8?B?dWh2cE5ubVB2Y1M2NDRuMmdMV2JJSnkzbGZtc09USUYyNFpmUW5KYS81MEVM?= =?utf-8?B?TWovc0hoQWhXd1MvK0svNmNwTlcyVkdNYnBjWmUwWkNldkE5NEJiWmNXbkVB?= =?utf-8?B?bGRVVndTM3JPbnBWQVBrRGxuaVF5b2NtR0Y0bC9XaW1CSi9pMHYrK2RiRWdv?= =?utf-8?B?a2lDWG9ReHBPeTBLOFF5ZE1rSnVNOFpBZHN6NVltVlNDRzBXbG0vOEhXMWdM?= =?utf-8?Q?3Z2TFZtImcuONSwBpODRT+FK4=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1481;5:+f5uWGaOpV6A+ps9x4FTg9R9vHnTqIO4Z6ju4nf/CUf9siBNfCC8y0unpL2NLkdr9JKR3NtQ3TOh0XyM+Kvvk9Fu1wZONhGOZJzIlpV3iKWw8txk6v5xaxpUVw+9wgQq3NwXyfvAMbDf7KDAL8stDg==;24:jlUkeY9jtaffLGSnV9L2QObwOPkVVv0tCmuiOvg5fKmrGWqlqAyaBKwf0UG/FPYk6x4quR1eDv0jkV3Y7em2wIwwKQPCYiwoZAwX448JIfQ= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2015 17:57:15.1505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1481 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-12-09 at 18:38 +0100, Borislav Petkov wrote: > On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote: > > It's not "a driver's probe function". There is no driver whose .probe() > > is > > mpc85xx_pci_err_probe() -- the name is historical. > > From looking at it, it behaves a lot like a probe function. Irrespective > of what it is or it isn't, calling it from outside a driver which can be > built as a module is a no-no. So I'd appreciate it if someone could test > Johannes' patch on the relevant hardware. Thanks for pointing the patch out -- it wasn't posted to linuxppc-dev so I would have missed it otherwise. I don't need to test it to see that it's broken -- we can't have two drivers binding to the same device, which is the reason why the current situation exists. I recall at the time suggesting that the PCIe controller driver instantiate a platform device for the EDAC driver to bind to -- it looks like that's what we'll need to do. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8) Date: Wed, 9 Dec 2015 11:57:05 -0600 Message-ID: <1449683825.15946.207.camel@freescale.com> References: <20151208154910.78d27c03@canb.auug.org.au> <1449657167.17265.4.camel@ellerman.id.au> <20151209111747.GA10518@pd.tnic> <20151209160301.GB10518@pd.tnic> <1449679809.15946.167.camel@freescale.com> <20151209173829.GD10518@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151209173829.GD10518@pd.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: Michael Ellerman , linux-kernel@vger.kernel.org, Stephen Rothwell , linux-next@vger.kernel.org, Johannes Thumshirn , linux-edac@vger.kernel.org List-Id: linux-next.vger.kernel.org On Wed, 2015-12-09 at 18:38 +0100, Borislav Petkov wrote: > On Wed, Dec 09, 2015 at 10:50:09AM -0600, Scott Wood wrote: > > It's not "a driver's probe function". There is no driver whose .probe() > > is > > mpc85xx_pci_err_probe() -- the name is historical. > > From looking at it, it behaves a lot like a probe function. Irrespective > of what it is or it isn't, calling it from outside a driver which can be > built as a module is a no-no. So I'd appreciate it if someone could test > Johannes' patch on the relevant hardware. Thanks for pointing the patch out -- it wasn't posted to linuxppc-dev so I would have missed it otherwise. I don't need to test it to see that it's broken -- we can't have two drivers binding to the same device, which is the reason why the current situation exists. I recall at the time suggesting that the PCIe controller driver instantiate a platform device for the EDAC driver to bind to -- it looks like that's what we'll need to do. -Scott