From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751292AbbLMVom (ORCPT <rfc822;w@1wt.eu>);
	Sun, 13 Dec 2015 16:44:42 -0500
Received: from mail-pf0-f172.google.com ([209.85.192.172]:36779 "EHLO
	mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750996AbbLMVol (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 13 Dec 2015 16:44:41 -0500
Message-ID: <1450043078.9768.37.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double
 allocations
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Luis Henriques <luis.henriques@canonical.com>,
        Eric Dumazet <edumazet@google.com>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, kernel-team@lists.ubuntu.com
Date: Sun, 13 Dec 2015 13:44:38 -0800
In-Reply-To: <1450041762.3944.4.camel@decadent.org.uk>
References: <1449653896-5236-1-git-send-email-luis.henriques@canonical.com>
	 <1449653896-5236-10-git-send-email-luis.henriques@canonical.com>
	 <1449893906.3836.5.camel@decadent.org.uk> <20151213185429.GA31826@charon>
	 <1450038035.3944.2.camel@decadent.org.uk>
	 <1450039390.9768.30.camel@edumazet-glaptop2.roam.corp.google.com>
	 <1450041762.3944.4.camel@decadent.org.uk>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2015-12-13 at 21:22 +0000, Ben Hutchings wrote:
> On Sun, 2015-12-13 at 12:43 -0800, Eric Dumazet wrote:

> > 1) Sorry Ben, I do not understand the problem you mention.
> >    What is a partially initialized device exactly ?
> 
> A tunnel device which is registered but hasn't had its private
> structure fully initialised yet.

And you see this happening after my patch ? I am blind.

I am referring to current linux kernel, not to a backport to pre 3.18
kernels, that was not considered when I wrote this patch.

By the time ipip6_fb_tunnel_init() is called, dev->tstats had been
already allocated in ipip6_tunnel_init(), so what is missing ?

Thanks.