From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbbLMVuG (ORCPT ); Sun, 13 Dec 2015 16:50:06 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:54165 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbbLMVuD (ORCPT ); Sun, 13 Dec 2015 16:50:03 -0500 Message-ID: <1450043388.3944.6.camel@decadent.org.uk> Subject: Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double allocations From: Ben Hutchings To: Eric Dumazet Cc: Luis Henriques , Eric Dumazet , Steffen Klassert , "David S. Miller" , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com Date: Sun, 13 Dec 2015 21:49:48 +0000 In-Reply-To: <1450043078.9768.37.camel@edumazet-glaptop2.roam.corp.google.com> References: <1449653896-5236-1-git-send-email-luis.henriques@canonical.com> <1449653896-5236-10-git-send-email-luis.henriques@canonical.com> <1449893906.3836.5.camel@decadent.org.uk> <20151213185429.GA31826@charon> <1450038035.3944.2.camel@decadent.org.uk> <1450039390.9768.30.camel@edumazet-glaptop2.roam.corp.google.com> <1450041762.3944.4.camel@decadent.org.uk> <1450043078.9768.37.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-x5yEm+gFcS36Ds0xeTFB" X-Mailer: Evolution 3.18.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.247 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-x5yEm+gFcS36Ds0xeTFB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2015-12-13 at 13:44 -0800, Eric Dumazet wrote: > On Sun, 2015-12-13 at 21:22 +0000, Ben Hutchings wrote: > > On Sun, 2015-12-13 at 12:43 -0800, Eric Dumazet wrote: >=20 > > > 1) Sorry Ben, I do not understand the problem you mention. > > > =C2=A0=C2=A0=C2=A0What is a partially initialized device exactly ? > >=20 > > A tunnel device which is registered but hasn't had its private > > structure fully initialised yet. >=20 > And you see this happening after my patch ? I am blind. >=20 > I am referring to current linux kernel, not to a backport to pre 3.18 > kernels, that was not considered when I wrote this patch. >=20 > By the time ipip6_fb_tunnel_init() is called, dev->tstats had been > already allocated in ipip6_tunnel_init(), so what is missing ? You moved this initialisation below the registration: > ipip6_tunnel_clone_6rd(sitn->fb_tunnel_dev, sitn); > ipip6_fb_tunnel_init(sitn->fb_tunnel_dev); Ben. --=20 Ben Hutchings Life would be so much easier if we could look at the source code. --=-x5yEm+gFcS36Ds0xeTFB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVm3n/Oe/yOyVhhEJAQobnA//Zo7JFLjBgG1KFmUVzmK40s9FigfXuKgU T8DYmsvYYJFaGafeaRr45C94s6Fnyp1/YezXBFecO9U3rZQo7JXwdAmqROJBQPU+ BqvyiTvGbK9WZ5iI6pFtO3H60cKlvRLMehwwWGy81LUkTTRFLlyHcyxxVWJm4K8D sOsE239Ssu7UuvVWOaohom2peXa+PWdpFOeXIvBKYIbyE3Uab9USHNRh08Bw9rP7 +3QrLAM00+rUDAs2OGd1YukTo3aiLIINMSb2imAcv6m3qMJqG/4sK7Gb1zZwAu2k Rwrb0LKfUoDVEvs2QJHA9cvl5ludVUIJ5ag++K7JrB/zrJR9cEbe/tf4zwK3scC2 ibpiv1kMiy/voJuxvE9p3AIttTBk1xSEKWk+B/TtzEpqYQiv5LJNiCfbfOHDwrOT 66/5hXfVxeAQ5FLIiMdocGTZobDlvVxC16pQ79uNJD75xt9yBM8nkJ7pFbWKF42t X2TYkx06noSvaYzGYrRe6q+JZUm3QvOi8q7rE35Sz9woubK82THE4WeF/t9qRF6y AbpFNLf/QG/+THwdlNtMxnpKjTcsDW+WFrJQzgv78g0rMrxLXKfUJYwH7w2NQSjE bdxBsND/Ed8cE0dOr4VRN/bCTTeOK4c21uVCZ3Y6qjDmhbkZZsT2kgRcXcznUCs5 3dQcpAqzbDs= =BjQs -----END PGP SIGNATURE----- --=-x5yEm+gFcS36Ds0xeTFB--