* [Buildroot] [PATCH 1/2] acpitool: new package
@ 2016-03-26 18:26 Erico Nunes
2016-03-26 18:26 ` [Buildroot] [PATCH 2/2] acpica: " Erico Nunes
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Erico Nunes @ 2016-03-26 18:26 UTC (permalink / raw
To: buildroot
acpitool is a small, convenient command-line ACPI client.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
package/Config.in | 1 +
package/acpitool/Config.in | 11 +++++++++++
package/acpitool/acpitool.hash | 2 ++
package/acpitool/acpitool.mk | 13 +++++++++++++
4 files changed, 27 insertions(+)
create mode 100644 package/acpitool/Config.in
create mode 100644 package/acpitool/acpitool.hash
create mode 100644 package/acpitool/acpitool.mk
diff --git a/package/Config.in b/package/Config.in
index 1467f33..cca553c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -340,6 +340,7 @@ menu "Firmware"
endmenu
source "package/a10disp/Config.in"
source "package/acpid/Config.in"
+ source "package/acpitool/Config.in"
source "package/am335x-pru-package/Config.in"
source "package/avrdude/Config.in"
source "package/bcache-tools/Config.in"
diff --git a/package/acpitool/Config.in b/package/acpitool/Config.in
new file mode 100644
index 0000000..7992e0f
--- /dev/null
+++ b/package/acpitool/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_ACPITOOL
+ bool "acpitool"
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ A small, convenient command-line ACPI client with a lot of
+ features for Linux
+
+ http://acpitool.sourceforge.net
+
+comment "acpitool needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/acpitool/acpitool.hash b/package/acpitool/acpitool.hash
new file mode 100644
index 0000000..e25dc54
--- /dev/null
+++ b/package/acpitool/acpitool.hash
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256 004fb6cd43102918b6302cf537a2db7ceadda04aef2e0906ddf230f820dad34f acpitool-0.5.1.tar.bz2
diff --git a/package/acpitool/acpitool.mk b/package/acpitool/acpitool.mk
new file mode 100644
index 0000000..f663fbb
--- /dev/null
+++ b/package/acpitool/acpitool.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# acpitool
+#
+################################################################################
+
+ACPITOOL_VERSION = 0.5.1
+ACPITOOL_SOURCE = acpitool-$(ACPITOOL_VERSION).tar.bz2
+ACPITOOL_SITE = http://downloads.sourceforge.net/sourceforge/acpitool
+ACPITOOL_LICENSE = GPLv2+
+ACPITOOL_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] acpica: new package
2016-03-26 18:26 [Buildroot] [PATCH 1/2] acpitool: new package Erico Nunes
@ 2016-03-26 18:26 ` Erico Nunes
2016-07-02 9:54 ` Romain Naour
2016-07-02 9:22 ` [Buildroot] [PATCH 1/2] acpitool: " Romain Naour
2016-07-03 8:08 ` Peter Korsgaard
2 siblings, 1 reply; 7+ messages in thread
From: Erico Nunes @ 2016-03-26 18:26 UTC (permalink / raw
To: buildroot
The ACPI Component Architecture (ACPICA) project provides an operating
system (OS)-independent reference implementation of the Advanced
Configuration and Power Interface Specification (ACPI).
It contains tools such as acpidump, iasl, acpixtract, etc.
The only issue that has been found is that it used uname to determine
the architecture for the target, and this has been worked around by
putting the target architecture directly instead.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
package/Config.in | 1 +
package/acpica/Config.in | 9 +++++++++
package/acpica/acpica.hash | 2 ++
package/acpica/acpica.mk | 26 ++++++++++++++++++++++++++
4 files changed, 38 insertions(+)
create mode 100644 package/acpica/Config.in
create mode 100644 package/acpica/acpica.hash
create mode 100644 package/acpica/acpica.mk
diff --git a/package/Config.in b/package/Config.in
index cca553c..6a283eb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -339,6 +339,7 @@ menu "Firmware"
source "package/zd1211-firmware/Config.in"
endmenu
source "package/a10disp/Config.in"
+ source "package/acpica/Config.in"
source "package/acpid/Config.in"
source "package/acpitool/Config.in"
source "package/am335x-pru-package/Config.in"
diff --git a/package/acpica/Config.in b/package/acpica/Config.in
new file mode 100644
index 0000000..8c33d0f
--- /dev/null
+++ b/package/acpica/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_ACPICA
+ bool "acpica"
+ help
+ The ACPI Component Architecture (ACPICA) project provides an
+ operating system (OS)-independent reference implementation of
+ the Advanced Configuration and Power Interface Specification
+ (ACPI).
+
+ https://www.acpica.org
diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
new file mode 100644
index 0000000..2798792
--- /dev/null
+++ b/package/acpica/acpica.hash
@@ -0,0 +1,2 @@
+# locally computed hash
+sha256 c0c68c7a8e9b1f4f66895b5950023042cb8e619fd92dab288010c8bd023d3270 acpica-unix2-20160212.tar.gz
diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
new file mode 100644
index 0000000..40ba009
--- /dev/null
+++ b/package/acpica/acpica.mk
@@ -0,0 +1,26 @@
+################################################################################
+#
+# acpica
+#
+################################################################################
+
+ACPICA_VERSION = 20160212
+ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
+ACPICA_SITE = https://acpica.org/sites/acpica/files
+ACPICA_LICENSE = GPLv2
+ACPICA_LICENSE_FILES = source/include/acpi.h
+ACPICA_DEPENDENCIES = host-bison host-flex
+
+define ACPICA_CONFIGURE_CMDS
+ $(SED) 's/uname -m/echo $(TARGET_ARCH)/' $(@D)/generate/unix/Makefile.common
+endef
+
+define ACPICA_BUILD_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) HOST=_LINUX CC=$(TARGET_CC) all
+endef
+
+define ACPICA_INSTALL_TARGET_CMDS
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
+endef
+
+$(eval $(generic-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] acpitool: new package
2016-03-26 18:26 [Buildroot] [PATCH 1/2] acpitool: new package Erico Nunes
2016-03-26 18:26 ` [Buildroot] [PATCH 2/2] acpica: " Erico Nunes
@ 2016-07-02 9:22 ` Romain Naour
2016-07-03 8:08 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Romain Naour @ 2016-07-02 9:22 UTC (permalink / raw
To: buildroot
Hi Erico,
Le 26/03/2016 ? 19:26, Erico Nunes a ?crit :
> acpitool is a small, convenient command-line ACPI client.
Checked the license and license file.
Reviewed-by: Romain Naour <romain.naour@smile.fr>
Build tested with musl, uclibc and static build.
Tested-by: Romain Naour <romain.naour@smile.fr>
Best regards,
Romain Naour
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
> package/Config.in | 1 +
> package/acpitool/Config.in | 11 +++++++++++
> package/acpitool/acpitool.hash | 2 ++
> package/acpitool/acpitool.mk | 13 +++++++++++++
> 4 files changed, 27 insertions(+)
> create mode 100644 package/acpitool/Config.in
> create mode 100644 package/acpitool/acpitool.hash
> create mode 100644 package/acpitool/acpitool.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 1467f33..cca553c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -340,6 +340,7 @@ menu "Firmware"
> endmenu
> source "package/a10disp/Config.in"
> source "package/acpid/Config.in"
> + source "package/acpitool/Config.in"
> source "package/am335x-pru-package/Config.in"
> source "package/avrdude/Config.in"
> source "package/bcache-tools/Config.in"
> diff --git a/package/acpitool/Config.in b/package/acpitool/Config.in
> new file mode 100644
> index 0000000..7992e0f
> --- /dev/null
> +++ b/package/acpitool/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_ACPITOOL
> + bool "acpitool"
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + A small, convenient command-line ACPI client with a lot of
> + features for Linux
> +
> + http://acpitool.sourceforge.net
> +
> +comment "acpitool needs a toolchain w/ C++"
> + depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/acpitool/acpitool.hash b/package/acpitool/acpitool.hash
> new file mode 100644
> index 0000000..e25dc54
> --- /dev/null
> +++ b/package/acpitool/acpitool.hash
> @@ -0,0 +1,2 @@
> +# locally computed hash
> +sha256 004fb6cd43102918b6302cf537a2db7ceadda04aef2e0906ddf230f820dad34f acpitool-0.5.1.tar.bz2
> diff --git a/package/acpitool/acpitool.mk b/package/acpitool/acpitool.mk
> new file mode 100644
> index 0000000..f663fbb
> --- /dev/null
> +++ b/package/acpitool/acpitool.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# acpitool
> +#
> +################################################################################
> +
> +ACPITOOL_VERSION = 0.5.1
> +ACPITOOL_SOURCE = acpitool-$(ACPITOOL_VERSION).tar.bz2
> +ACPITOOL_SITE = http://downloads.sourceforge.net/sourceforge/acpitool
> +ACPITOOL_LICENSE = GPLv2+
> +ACPITOOL_LICENSE_FILES = COPYING
> +
> +$(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] acpica: new package
2016-03-26 18:26 ` [Buildroot] [PATCH 2/2] acpica: " Erico Nunes
@ 2016-07-02 9:54 ` Romain Naour
2016-07-02 10:45 ` Erico Nunes
0 siblings, 1 reply; 7+ messages in thread
From: Romain Naour @ 2016-07-02 9:54 UTC (permalink / raw
To: buildroot
Hi Erico,
Le 26/03/2016 ? 19:26, Erico Nunes a ?crit :
> The ACPI Component Architecture (ACPICA) project provides an operating
> system (OS)-independent reference implementation of the Advanced
> Configuration and Power Interface Specification (ACPI).
>
> It contains tools such as acpidump, iasl, acpixtract, etc.
>
> The only issue that has been found is that it used uname to determine
> the architecture for the target, and this has been worked around by
> putting the target architecture directly instead.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
> package/Config.in | 1 +
> package/acpica/Config.in | 9 +++++++++
> package/acpica/acpica.hash | 2 ++
> package/acpica/acpica.mk | 26 ++++++++++++++++++++++++++
> 4 files changed, 38 insertions(+)
> create mode 100644 package/acpica/Config.in
> create mode 100644 package/acpica/acpica.hash
> create mode 100644 package/acpica/acpica.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index cca553c..6a283eb 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -339,6 +339,7 @@ menu "Firmware"
> source "package/zd1211-firmware/Config.in"
> endmenu
> source "package/a10disp/Config.in"
> + source "package/acpica/Config.in"
> source "package/acpid/Config.in"
> source "package/acpitool/Config.in"
> source "package/am335x-pru-package/Config.in"
> diff --git a/package/acpica/Config.in b/package/acpica/Config.in
> new file mode 100644
> index 0000000..8c33d0f
> --- /dev/null
> +++ b/package/acpica/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_ACPICA
> + bool "acpica"
> + help
> + The ACPI Component Architecture (ACPICA) project provides an
> + operating system (OS)-independent reference implementation of
> + the Advanced Configuration and Power Interface Specification
> + (ACPI).
> +
> + https://www.acpica.org
> diff --git a/package/acpica/acpica.hash b/package/acpica/acpica.hash
> new file mode 100644
> index 0000000..2798792
> --- /dev/null
> +++ b/package/acpica/acpica.hash
> @@ -0,0 +1,2 @@
> +# locally computed hash
> +sha256 c0c68c7a8e9b1f4f66895b5950023042cb8e619fd92dab288010c8bd023d3270 acpica-unix2-20160212.tar.gz
> diff --git a/package/acpica/acpica.mk b/package/acpica/acpica.mk
> new file mode 100644
> index 0000000..40ba009
> --- /dev/null
> +++ b/package/acpica/acpica.mk
> @@ -0,0 +1,26 @@
> +################################################################################
> +#
> +# acpica
> +#
> +################################################################################
> +
> +ACPICA_VERSION = 20160212
> +ACPICA_SOURCE = acpica-unix2-$(ACPICA_VERSION).tar.gz
> +ACPICA_SITE = https://acpica.org/sites/acpica/files
> +ACPICA_LICENSE = GPLv2
The license seems to be a BSD like or GPLv2
> +ACPICA_LICENSE_FILES = source/include/acpi.h
> +ACPICA_DEPENDENCIES = host-bison host-flex
> +
> +define ACPICA_CONFIGURE_CMDS
> + $(SED) 's/uname -m/echo $(TARGET_ARCH)/' $(@D)/generate/unix/Makefile.common
> +endef
> +
> +define ACPICA_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) HOST=_LINUX CC=$(TARGET_CC) all
> +endef
> +
> +define ACPICA_INSTALL_TARGET_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR=$(TARGET_DIR) install
> +endef
Maybe you can use TARGET_CONFIGURE_OPTS like as Peter suggested in [1]
With that fixed:
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Build tested with musl, uclibc and static build.
Tested-by: Romain Naour <romain.naour@gmail.com>
[1]
https://git.busybox.net/buildroot/commit/?id=6d2cb12d5f544a5fd24b14326e85901dfeaf3d31
Best regards,
Romain Naour
> +
> +$(eval $(generic-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] acpica: new package
2016-07-02 9:54 ` Romain Naour
@ 2016-07-02 10:45 ` Erico Nunes
2016-07-03 8:15 ` Peter Korsgaard
0 siblings, 1 reply; 7+ messages in thread
From: Erico Nunes @ 2016-07-02 10:45 UTC (permalink / raw
To: buildroot
Hi Romain,
thank you very much for your review and testing.
On Sat, Jul 2, 2016 at 11:54 AM, Romain Naour <romain.naour@smile.fr> wrote:
> The license seems to be a BSD like or GPLv2
I've look again and indeed it looks like a dual license, I'll update
accordingly.
> Maybe you can use TARGET_CONFIGURE_OPTS like as Peter suggested in [1]
Ok. By the way, during some more testing after your comment, I've
found that it builds without errors but fails to install on non-x86_64
architectures due to the use of "install -s" (install fails attempting
to use 'strip' from the host on other architectures).
I'll have that fixed too in a v2.
Thank you
Erico
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] acpitool: new package
2016-03-26 18:26 [Buildroot] [PATCH 1/2] acpitool: new package Erico Nunes
2016-03-26 18:26 ` [Buildroot] [PATCH 2/2] acpica: " Erico Nunes
2016-07-02 9:22 ` [Buildroot] [PATCH 1/2] acpitool: " Romain Naour
@ 2016-07-03 8:08 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2016-07-03 8:08 UTC (permalink / raw
To: buildroot
>>>>> "Erico" == Erico Nunes <nunes.erico@gmail.com> writes:
> acpitool is a small, convenient command-line ACPI client.
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
> package/Config.in | 1 +
> package/acpitool/Config.in | 11 +++++++++++
> package/acpitool/acpitool.hash | 2 ++
> package/acpitool/acpitool.mk | 13 +++++++++++++
> 4 files changed, 27 insertions(+)
> create mode 100644 package/acpitool/Config.in
> create mode 100644 package/acpitool/acpitool.hash
> create mode 100644 package/acpitool/acpitool.mk
> diff --git a/package/Config.in b/package/Config.in
> index 1467f33..cca553c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -340,6 +340,7 @@ menu "Firmware"
> endmenu
> source "package/a10disp/Config.in"
> source "package/acpid/Config.in"
> + source "package/acpitool/Config.in"
> source "package/am335x-pru-package/Config.in"
> source "package/avrdude/Config.in"
> source "package/bcache-tools/Config.in"
> diff --git a/package/acpitool/Config.in b/package/acpitool/Config.in
> new file mode 100644
> index 0000000..7992e0f
> --- /dev/null
> +++ b/package/acpitool/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_ACPITOOL
> + bool "acpitool"
> + depends on BR2_INSTALL_LIBSTDCPP
I was hessitating if we needed some architecture dependencies as this
uses the /proc/acpi kernel interface which is only available on
x86/ia64/arm64 - But as this is only a runtime dependency I left it as
is.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] acpica: new package
2016-07-02 10:45 ` Erico Nunes
@ 2016-07-03 8:15 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2016-07-03 8:15 UTC (permalink / raw
To: buildroot
>>>>> "Erico" == Erico Nunes <nunes.erico@gmail.com> writes:
> Hi Romain,
> thank you very much for your review and testing.
> On Sat, Jul 2, 2016 at 11:54 AM, Romain Naour <romain.naour@smile.fr> wrote:
>> The license seems to be a BSD like or GPLv2
> I've look again and indeed it looks like a dual license, I'll update
> accordingly.
>> Maybe you can use TARGET_CONFIGURE_OPTS like as Peter suggested in [1]
> Ok. By the way, during some more testing after your comment, I've
> found that it builds without errors but fails to install on non-x86_64
> architectures due to the use of "install -s" (install fails attempting
> to use 'strip' from the host on other architectures).
> I'll have that fixed too in a v2.
Ok. Don't forget to send the v2 patch. I'll mark this patch as changes
requested in patchwork.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-07-03 8:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-26 18:26 [Buildroot] [PATCH 1/2] acpitool: new package Erico Nunes
2016-03-26 18:26 ` [Buildroot] [PATCH 2/2] acpica: " Erico Nunes
2016-07-02 9:54 ` Romain Naour
2016-07-02 10:45 ` Erico Nunes
2016-07-03 8:15 ` Peter Korsgaard
2016-07-02 9:22 ` [Buildroot] [PATCH 1/2] acpitool: " Romain Naour
2016-07-03 8:08 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.