* [PATCH] mm: fix duplicate words and typos
@ 2016-05-18 2:35 ` Li Peng
0 siblings, 0 replies; 4+ messages in thread
From: Li Peng @ 2016-05-18 2:35 UTC (permalink / raw
To: akpm; +Cc: linux-mm, linux-kernel, Li Peng
Signed-off-by: Li Peng <lip@dtdream.com>
---
mm/memcontrol.c | 2 +-
mm/page_alloc.c | 6 +++---
mm/vmscan.c | 7 +++----
mm/zswap.c | 2 +-
4 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index fe787f5..4b74255 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2293,7 +2293,7 @@ struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp)
/*
* If we are in a safe context (can wait, and not in interrupt
- * context), we could be be predictable and return right away.
+ * context), we could be predictable and return right away.
* This would guarantee that the allocation being performed
* already belongs in the new cache.
*
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index c1069ef..93824cb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3030,7 +3030,7 @@ retry:
/*
* If an allocation failed after direct reclaim, it could be because
* pages are pinned on the per-cpu lists or in high alloc reserves.
- * Shrink them them and try again
+ * Shrink them and try again.
*/
if (!page && !drained) {
unreserve_highatomic_pageblock(ac);
@@ -4812,7 +4812,7 @@ static int zone_batchsize(struct zone *zone)
* locking.
*
* Any new users of pcp->batch and pcp->high should ensure they can cope with
- * those fields changing asynchronously (acording the the above rule).
+ * those fields changing asynchronously (according to the above rule).
*
* mutex_is_locked(&pcp_batch_high_lock) required when calling this function
* outside of boot time (or some other assurance that no concurrent updaters
@@ -5024,7 +5024,7 @@ int __meminit __early_pfn_to_nid(unsigned long pfn,
* @max_low_pfn: The highest PFN that will be passed to memblock_free_early_nid
*
* If an architecture guarantees that all ranges registered contain no holes
- * and may be freed, this this function may be used instead of calling
+ * and may be freed, this function may be used instead of calling
* memblock_free_early_nid() manually.
*/
void __init free_bootmem_with_active_regions(int nid, unsigned long max_low_pfn)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 142cb61..8ff5a79 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1683,8 +1683,8 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
set_bit(ZONE_DIRTY, &zone->flags);
/*
- * If kswapd scans pages marked marked for immediate
- * reclaim and under writeback (nr_immediate), it implies
+ * If kswapd scans pages marked for immediate reclaim
+ * and under writeback (nr_immediate), it implies
* that pages are cycling through the LRU faster than
* they are written so also forcibly stall.
*/
@@ -3267,8 +3267,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
/*
* There should be no need to raise the scanning
* priority if enough pages are already being scanned
- * that that high watermark would be met at 100%
- * efficiency.
+ * that high watermark would be met at 100% efficiency.
*/
if (kswapd_shrink_zone(zone, end_zone, &sc))
raise_priority = false;
diff --git a/mm/zswap.c b/mm/zswap.c
index de0f119b..6d829d7 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -928,7 +928,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle)
* a load may happening concurrently
* it is safe and okay to not free the entry
* if we free the entry in the following put
- * it it either okay to return !0
+ * it either okay to return !0
*/
fail:
spin_lock(&tree->lock);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mm: fix duplicate words and typos
@ 2016-05-18 2:35 ` Li Peng
0 siblings, 0 replies; 4+ messages in thread
From: Li Peng @ 2016-05-18 2:35 UTC (permalink / raw
To: akpm; +Cc: linux-mm, linux-kernel, Li Peng
Signed-off-by: Li Peng <lip@dtdream.com>
---
mm/memcontrol.c | 2 +-
mm/page_alloc.c | 6 +++---
mm/vmscan.c | 7 +++----
mm/zswap.c | 2 +-
4 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index fe787f5..4b74255 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2293,7 +2293,7 @@ struct kmem_cache *__memcg_kmem_get_cache(struct kmem_cache *cachep, gfp_t gfp)
/*
* If we are in a safe context (can wait, and not in interrupt
- * context), we could be be predictable and return right away.
+ * context), we could be predictable and return right away.
* This would guarantee that the allocation being performed
* already belongs in the new cache.
*
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index c1069ef..93824cb 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3030,7 +3030,7 @@ retry:
/*
* If an allocation failed after direct reclaim, it could be because
* pages are pinned on the per-cpu lists or in high alloc reserves.
- * Shrink them them and try again
+ * Shrink them and try again.
*/
if (!page && !drained) {
unreserve_highatomic_pageblock(ac);
@@ -4812,7 +4812,7 @@ static int zone_batchsize(struct zone *zone)
* locking.
*
* Any new users of pcp->batch and pcp->high should ensure they can cope with
- * those fields changing asynchronously (acording the the above rule).
+ * those fields changing asynchronously (according to the above rule).
*
* mutex_is_locked(&pcp_batch_high_lock) required when calling this function
* outside of boot time (or some other assurance that no concurrent updaters
@@ -5024,7 +5024,7 @@ int __meminit __early_pfn_to_nid(unsigned long pfn,
* @max_low_pfn: The highest PFN that will be passed to memblock_free_early_nid
*
* If an architecture guarantees that all ranges registered contain no holes
- * and may be freed, this this function may be used instead of calling
+ * and may be freed, this function may be used instead of calling
* memblock_free_early_nid() manually.
*/
void __init free_bootmem_with_active_regions(int nid, unsigned long max_low_pfn)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 142cb61..8ff5a79 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1683,8 +1683,8 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec,
set_bit(ZONE_DIRTY, &zone->flags);
/*
- * If kswapd scans pages marked marked for immediate
- * reclaim and under writeback (nr_immediate), it implies
+ * If kswapd scans pages marked for immediate reclaim
+ * and under writeback (nr_immediate), it implies
* that pages are cycling through the LRU faster than
* they are written so also forcibly stall.
*/
@@ -3267,8 +3267,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
/*
* There should be no need to raise the scanning
* priority if enough pages are already being scanned
- * that that high watermark would be met at 100%
- * efficiency.
+ * that high watermark would be met at 100% efficiency.
*/
if (kswapd_shrink_zone(zone, end_zone, &sc))
raise_priority = false;
diff --git a/mm/zswap.c b/mm/zswap.c
index de0f119b..6d829d7 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -928,7 +928,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle)
* a load may happening concurrently
* it is safe and okay to not free the entry
* if we free the entry in the following put
- * it it either okay to return !0
+ * it either okay to return !0
*/
fail:
spin_lock(&tree->lock);
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: fix duplicate words and typos
2016-05-18 2:35 ` Li Peng
@ 2016-05-18 15:23 ` Randy Dunlap
-1 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2016-05-18 15:23 UTC (permalink / raw
To: Li Peng, akpm; +Cc: linux-mm, linux-kernel
On 05/17/16 19:35, Li Peng wrote:
> Signed-off-by: Li Peng <lip@dtdream.com>
> ---
> mm/memcontrol.c | 2 +-
> mm/page_alloc.c | 6 +++---
> mm/vmscan.c | 7 +++----
> mm/zswap.c | 2 +-
> 4 files changed, 8 insertions(+), 9 deletions(-)
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 142cb61..8ff5a79 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3267,8 +3267,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
> /*
> * There should be no need to raise the scanning
> * priority if enough pages are already being scanned
> - * that that high watermark would be met at 100%
> - * efficiency.
> + * that high watermark would be met at 100% efficiency.
I think that this one wasn't wrong, just confusing. Maybe change it to:
* that the high watermark would be met at 100% efficiency.
> */
> if (kswapd_shrink_zone(zone, end_zone, &sc))
> raise_priority = false;
> diff --git a/mm/zswap.c b/mm/zswap.c
> index de0f119b..6d829d7 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -928,7 +928,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle)
> * a load may happening concurrently
> * it is safe and okay to not free the entry
> * if we free the entry in the following put
> - * it it either okay to return !0
> + * it either okay to return !0
That's still confusing. Needs some kind of help.
> */
> fail:
> spin_lock(&tree->lock);
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm: fix duplicate words and typos
@ 2016-05-18 15:23 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2016-05-18 15:23 UTC (permalink / raw
To: Li Peng, akpm; +Cc: linux-mm, linux-kernel
On 05/17/16 19:35, Li Peng wrote:
> Signed-off-by: Li Peng <lip@dtdream.com>
> ---
> mm/memcontrol.c | 2 +-
> mm/page_alloc.c | 6 +++---
> mm/vmscan.c | 7 +++----
> mm/zswap.c | 2 +-
> 4 files changed, 8 insertions(+), 9 deletions(-)
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 142cb61..8ff5a79 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3267,8 +3267,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int classzone_idx)
> /*
> * There should be no need to raise the scanning
> * priority if enough pages are already being scanned
> - * that that high watermark would be met at 100%
> - * efficiency.
> + * that high watermark would be met at 100% efficiency.
I think that this one wasn't wrong, just confusing. Maybe change it to:
* that the high watermark would be met at 100% efficiency.
> */
> if (kswapd_shrink_zone(zone, end_zone, &sc))
> raise_priority = false;
> diff --git a/mm/zswap.c b/mm/zswap.c
> index de0f119b..6d829d7 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -928,7 +928,7 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle)
> * a load may happening concurrently
> * it is safe and okay to not free the entry
> * if we free the entry in the following put
> - * it it either okay to return !0
> + * it either okay to return !0
That's still confusing. Needs some kind of help.
> */
> fail:
> spin_lock(&tree->lock);
>
--
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-18 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-18 2:35 [PATCH] mm: fix duplicate words and typos Li Peng
2016-05-18 2:35 ` Li Peng
2016-05-18 15:23 ` Randy Dunlap
2016-05-18 15:23 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.