All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550
@ 2016-06-01 16:50 Tony Nguyen
  2016-06-01 18:31 ` Keller, Jacob E
  2016-06-01 21:14 ` Bowers, AndrewX
  0 siblings, 2 replies; 3+ messages in thread
From: Tony Nguyen @ 2016-06-01 16:50 UTC (permalink / raw
  To: intel-wired-lan

Update ixgbe_ethtool_get_ts_info() to show that x550 supports hardware
timestamping of all packets.

Reported-by: Guy Harris <guy@alum.mit.edu>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index f1d2fc1..716e643 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -2993,10 +2993,15 @@ static int ixgbe_get_ts_info(struct net_device *dev,
 {
 	struct ixgbe_adapter *adapter = netdev_priv(dev);
 
+	/* we always support timestamping disabled */
+	info->rx_filters = BIT(HWTSTAMP_FILTER_NONE);
+
 	switch (adapter->hw.mac.type) {
 	case ixgbe_mac_X550:
 	case ixgbe_mac_X550EM_x:
 	case ixgbe_mac_x550em_a:
+		info->rx_filters |= BIT(HWTSTAMP_FILTER_ALL);
+		/* fallthrough */
 	case ixgbe_mac_X540:
 	case ixgbe_mac_82599EB:
 		info->so_timestamping =
@@ -3016,8 +3021,7 @@ static int ixgbe_get_ts_info(struct net_device *dev,
 			BIT(HWTSTAMP_TX_OFF) |
 			BIT(HWTSTAMP_TX_ON);
 
-		info->rx_filters =
-			BIT(HWTSTAMP_FILTER_NONE) |
+		info->rx_filters |=
 			BIT(HWTSTAMP_FILTER_PTP_V1_L4_SYNC) |
 			BIT(HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ) |
 			BIT(HWTSTAMP_FILTER_PTP_V2_EVENT);
-- 
2.4.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550
  2016-06-01 16:50 [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550 Tony Nguyen
@ 2016-06-01 18:31 ` Keller, Jacob E
  2016-06-01 21:14 ` Bowers, AndrewX
  1 sibling, 0 replies; 3+ messages in thread
From: Keller, Jacob E @ 2016-06-01 18:31 UTC (permalink / raw
  To: intel-wired-lan

On Wed, 2016-06-01 at 09:50 -0700, Tony Nguyen wrote:
> Update ixgbe_ethtool_get_ts_info() to show that x550 supports
> hardware
> timestamping of all packets.
> 
> Reported-by: Guy Harris <guy@alum.mit.edu>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---

Thanks Tony!

Regards,
Jake

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550
  2016-06-01 16:50 [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550 Tony Nguyen
  2016-06-01 18:31 ` Keller, Jacob E
@ 2016-06-01 21:14 ` Bowers, AndrewX
  1 sibling, 0 replies; 3+ messages in thread
From: Bowers, AndrewX @ 2016-06-01 21:14 UTC (permalink / raw
  To: intel-wired-lan

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Tony Nguyen
> Sent: Wednesday, June 01, 2016 9:51 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping
> for x550
> 
> Update ixgbe_ethtool_get_ts_info() to show that x550 supports hardware
> timestamping of all packets.
> 
> Reported-by: Guy Harris <guy@alum.mit.edu>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Ethtool correctly reports hardware timestamping capabilities of the device

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-01 21:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-01 16:50 [Intel-wired-lan] [PATCH] ixgbe: Correct reporting of timestamping for x550 Tony Nguyen
2016-06-01 18:31 ` Keller, Jacob E
2016-06-01 21:14 ` Bowers, AndrewX

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.