From: Hans de Goede <hdegoede@redhat.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio
Date: Sun, 1 Aug 2021 12:27:28 +0200 [thread overview]
Message-ID: <146ba2f9-448d-7268-a197-baab618ce2e8@redhat.com> (raw)
In-Reply-To: <s5h35ru7vkz.wl-tiwai@suse.de>
Hi,
On 7/31/21 10:10 AM, Takashi Iwai wrote:
> On Fri, 30 Jul 2021 22:04:00 +0200,
> Hans de Goede wrote:
>>
>> Hi All;,
>>
>> As discussed in the "5.14 regression, Intel SST (BYT) audio no longer works" thread,
>> audio on X86 devices using the Intel SST driver no longer works with 5.14.
>>
>> After poking at this for a while I've found the culprit:
>> 30b7ba6972d5 ("ALSA: core: Add continuous and vmalloc mmap ops")
>>
>> If I revert that single commit then everything works fine again with 5.14.
>
> Does the patch below fix the problem?
Yes that seems to fix things, thank you.
Regards,
Hans
> ---
> --- a/sound/core/memalloc.c
> +++ b/sound/core/memalloc.c
> @@ -215,7 +215,7 @@ static int snd_dma_continuous_mmap(struct snd_dma_buffer *dmab,
> struct vm_area_struct *area)
> {
> return remap_pfn_range(area, area->vm_start,
> - dmab->addr >> PAGE_SHIFT,
> + page_to_pfn(virt_to_page(dmab->area)),
> area->vm_end - area->vm_start,
> area->vm_page_prot);
> }
>
next prev parent reply other threads:[~2021-08-01 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 20:04 [5.14 regression] "ALSA: core: Add continuous and vmalloc mmap ops" breaks Intel SST audio Hans de Goede
2021-07-31 8:10 ` Takashi Iwai
2021-08-01 10:27 ` Hans de Goede [this message]
2021-08-01 11:35 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146ba2f9-448d-7268-a197-baab618ce2e8@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.