All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mwifiex: fix missing break on IEEE80211_STYPE_ACTION case
@ 2016-08-16 12:10 Colin King
  2016-09-03 10:08 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-08-16 12:10 UTC (permalink / raw
  To: Amitkumar Karwar, Nishant Sarmukadam, Kalle Valo, linux-wireless,
	netdev
  Cc: linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The IEEE80211_STYPE_ACTION case is missing a break in the switch
statement, causing it to fall through to the default case that
reports a debug message about an unknown frame subtype. Fix this
by adding in the missing break statement.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/marvell/mwifiex/util.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/util.c b/drivers/net/wireless/marvell/mwifiex/util.c
index 6681be0..18fbb96 100644
--- a/drivers/net/wireless/marvell/mwifiex/util.c
+++ b/drivers/net/wireless/marvell/mwifiex/util.c
@@ -386,6 +386,7 @@ mwifiex_parse_mgmt_packet(struct mwifiex_private *priv, u8 *payload, u16 len,
 				    "unknown public action frame category %d\n",
 				    category);
 		}
+		break;
 	default:
 		mwifiex_dbg(priv->adapter, INFO,
 		    "unknown mgmt frame subtype %#x\n", stype);
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: mwifiex: fix missing break on IEEE80211_STYPE_ACTION case
  2016-08-16 12:10 [PATCH] mwifiex: fix missing break on IEEE80211_STYPE_ACTION case Colin King
@ 2016-09-03 10:08 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-09-03 10:08 UTC (permalink / raw
  To: Colin Ian King
  Cc: Amitkumar Karwar, Nishant Sarmukadam, linux-wireless, netdev,
	linux-kernel

Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The IEEE80211_STYPE_ACTION case is missing a break in the switch
> statement, causing it to fall through to the default case that
> reports a debug message about an unknown frame subtype. Fix this
> by adding in the missing break statement.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, 1 patch applied to wireless-drivers-next.git:

d393be3ed0be mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9283755/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-03 10:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-16 12:10 [PATCH] mwifiex: fix missing break on IEEE80211_STYPE_ACTION case Colin King
2016-09-03 10:08 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.