* [PATCH v2] drm/i915/dp: Debug log MST active links explicitly
@ 2016-10-26 4:37 Dhinakaran Pandiyan
2016-10-26 4:49 ` Pandiyan, Dhinakaran
2016-10-26 5:16 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev3) Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Dhinakaran Pandiyan @ 2016-10-26 4:37 UTC (permalink / raw
To: intel-gfx; +Cc: Pandiyan, Dhinakaran
From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
No functional change. Just printing the number of active links without
stating what the number means is not very useful. So, add relevant text.
v2: Included connector info (Chris)
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
---
drivers/gpu/drm/i915/intel_dp_mst.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
index 3ffbd69..8f2016b 100644
--- a/drivers/gpu/drm/i915/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/intel_dp_mst.c
@@ -86,8 +86,6 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
to_intel_connector(old_conn_state->connector);
int ret;
- DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
-
drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
@@ -106,8 +104,6 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
struct intel_connector *connector =
to_intel_connector(old_conn_state->connector);
- DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
-
/* this can fail */
drm_dp_check_act_status(&intel_dp->mst_mgr);
/* and this can also fail */
@@ -124,6 +120,11 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
}
+
+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] MST link deactivated, total active links: %d\n",
+ old_conn_state->connector->base.id,
+ old_conn_state->connector->name,
+ intel_dp->active_mst_links);
}
static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
@@ -147,8 +148,6 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
connector->encoder = encoder;
intel_mst->connector = connector;
- DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
-
if (intel_dp->active_mst_links == 0) {
intel_ddi_clk_select(&intel_dig_port->base,
pipe_config->shared_dpll);
@@ -175,7 +174,6 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
return;
}
-
intel_dp->active_mst_links++;
temp = I915_READ(DP_TP_STATUS(port));
I915_WRITE(DP_TP_STATUS(port), temp);
@@ -194,8 +192,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
enum port port = intel_dig_port->port;
int ret;
- DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
-
if (intel_wait_for_register(dev_priv,
DP_TP_STATUS(port),
DP_TP_STATUS_ACT_SENT,
@@ -206,6 +202,11 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
+
+ DRM_DEBUG_KMS("[CONNECTOR:%d:%s] MST link activated, total active links: %d\n",
+ conn_state->connector->base.id,
+ conn_state->connector->name,
+ intel_dp->active_mst_links);
}
static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/i915/dp: Debug log MST active links explicitly
2016-10-26 4:37 [PATCH v2] drm/i915/dp: Debug log MST active links explicitly Dhinakaran Pandiyan
@ 2016-10-26 4:49 ` Pandiyan, Dhinakaran
2016-10-26 5:16 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev3) Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Pandiyan, Dhinakaran @ 2016-10-26 4:49 UTC (permalink / raw
To: intel-gfx@lists.freedesktop.org, jim.bride@linux.intel.com
Jim,
Please let me know if the R-B is still good.
-DK
On Tue, 2016-10-25 at 21:37 -0700, Dhinakaran Pandiyan wrote:
> From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
>
> No functional change. Just printing the number of active links without
> stating what the number means is not very useful. So, add relevant text.
>
> v2: Included connector info (Chris)
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Reviewed-by: Jim Bride <jim.bride@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp_mst.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c b/drivers/gpu/drm/i915/intel_dp_mst.c
> index 3ffbd69..8f2016b 100644
> --- a/drivers/gpu/drm/i915/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/intel_dp_mst.c
> @@ -86,8 +86,6 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
> to_intel_connector(old_conn_state->connector);
> int ret;
>
> - DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> -
> drm_dp_mst_reset_vcpi_slots(&intel_dp->mst_mgr, connector->port);
>
> ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
> @@ -106,8 +104,6 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
> struct intel_connector *connector =
> to_intel_connector(old_conn_state->connector);
>
> - DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> -
> /* this can fail */
> drm_dp_check_act_status(&intel_dp->mst_mgr);
> /* and this can also fail */
> @@ -124,6 +120,11 @@ static void intel_mst_post_disable_dp(struct intel_encoder *encoder,
>
> intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
> }
> +
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] MST link deactivated, total active links: %d\n",
> + old_conn_state->connector->base.id,
> + old_conn_state->connector->name,
> + intel_dp->active_mst_links);
> }
>
> static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
> @@ -147,8 +148,6 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
> connector->encoder = encoder;
> intel_mst->connector = connector;
>
> - DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> -
> if (intel_dp->active_mst_links == 0) {
> intel_ddi_clk_select(&intel_dig_port->base,
> pipe_config->shared_dpll);
> @@ -175,7 +174,6 @@ static void intel_mst_pre_enable_dp(struct intel_encoder *encoder,
> return;
> }
>
> -
> intel_dp->active_mst_links++;
> temp = I915_READ(DP_TP_STATUS(port));
> I915_WRITE(DP_TP_STATUS(port), temp);
> @@ -194,8 +192,6 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> enum port port = intel_dig_port->port;
> int ret;
>
> - DRM_DEBUG_KMS("%d\n", intel_dp->active_mst_links);
> -
> if (intel_wait_for_register(dev_priv,
> DP_TP_STATUS(port),
> DP_TP_STATUS_ACT_SENT,
> @@ -206,6 +202,11 @@ static void intel_mst_enable_dp(struct intel_encoder *encoder,
> ret = drm_dp_check_act_status(&intel_dp->mst_mgr);
>
> ret = drm_dp_update_payload_part2(&intel_dp->mst_mgr);
> +
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] MST link activated, total active links: %d\n",
> + conn_state->connector->base.id,
> + conn_state->connector->name,
> + intel_dp->active_mst_links);
> }
>
> static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev3)
2016-10-26 4:37 [PATCH v2] drm/i915/dp: Debug log MST active links explicitly Dhinakaran Pandiyan
2016-10-26 4:49 ` Pandiyan, Dhinakaran
@ 2016-10-26 5:16 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2016-10-26 5:16 UTC (permalink / raw
To: Pandiyan, Dhinakaran; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: Debug log MST active links explicitly (rev3)
URL : https://patchwork.freedesktop.org/series/13627/
State : failure
== Summary ==
Series 13627v3 drm/i915/dp: Debug log MST active links explicitly
https://patchwork.freedesktop.org/api/1.0/series/13627/revisions/3/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6770hq)
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-WARN (fi-skl-6700hq)
pass -> DMESG-WARN (fi-skl-6770hq)
Test kms_flip:
Subgroup basic-plain-flip:
pass -> DMESG-WARN (fi-skl-6770hq)
Test kms_frontbuffer_tracking:
Subgroup basic:
pass -> FAIL (fi-skl-6770hq)
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-b:
pass -> DMESG-WARN (fi-ivb-3770)
Subgroup suspend-read-crc-pipe-a:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-skl-6700hq)
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (fi-skl-6700hq)
fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42
fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30
fi-byt-j1900 total:246 pass:215 dwarn:0 dfail:0 fail:0 skip:31
fi-byt-n2820 total:246 pass:211 dwarn:0 dfail:0 fail:0 skip:35
fi-hsw-4770 total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-4770r total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23
fi-ilk-650 total:246 pass:185 dwarn:0 dfail:0 fail:0 skip:61
fi-ivb-3520m total:246 pass:220 dwarn:0 dfail:0 fail:0 skip:26
fi-ivb-3770 total:246 pass:219 dwarn:1 dfail:0 fail:0 skip:26
fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:246 pass:219 dwarn:4 dfail:0 fail:0 skip:23
fi-skl-6700k total:246 pass:222 dwarn:1 dfail:0 fail:0 skip:23
fi-skl-6770hq total:246 pass:228 dwarn:3 dfail:0 fail:1 skip:14
fi-snb-2520m total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
fi-snb-2600 total:246 pass:208 dwarn:0 dfail:0 fail:0 skip:38
f746a2112fbb563743acc132304075706551d123 drm-intel-nightly: 2016y-10m-25d-20h-02m-34s UTC integration manifest
7de0e75 drm/i915/dp: Debug log MST active links explicitly
Full results at https://intel-gfx-ci.01.org/CI/Patchwork_2820/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2820/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-26 5:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 4:37 [PATCH v2] drm/i915/dp: Debug log MST active links explicitly Dhinakaran Pandiyan
2016-10-26 4:49 ` Pandiyan, Dhinakaran
2016-10-26 5:16 ` ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev3) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.