* [PATCH] drm/amd/powerplay: use pr_debug to print function not implemented message
@ 2016-12-07 19:28 Alex Deucher
[not found] ` <1481138889-10312-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Alex Deucher @ 2016-12-07 19:28 UTC (permalink / raw
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Arindam Nath, Alex Deucher
From: Arindam Nath <arindam.nath@amd.com>
For CZ, some function pointers like display_configuration_changed
are not set. So when HW manager tries to configure display, we
end up with messages like
"[ powerplay ] this function not implement!"
in the logs. This message is informational, but lacks details
on which function is not implemented and why.
Rather than using KERN_INFO to print the message everytime the
system boots, we rather use pr_debug so that it is only printed
when debug prints are enabled at runtime.
Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Arindam Nath <arindam.nath@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
index a6abe81..71822ae 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
@@ -35,7 +35,7 @@ static int phm_run_table(struct pp_hwmgr *hwmgr,
phm_table_function *function;
if (rt_table->function_list == NULL) {
- printk(KERN_INFO "[ powerplay ] this function not implement!\n");
+ pr_debug("[ powerplay ] this function not implement!\n");
return 0;
}
--
2.5.5
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/powerplay: use pr_debug to print function not implemented message
[not found] ` <1481138889-10312-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2016-12-08 0:36 ` Edward O'Callaghan
0 siblings, 0 replies; 2+ messages in thread
From: Edward O'Callaghan @ 2016-12-08 0:36 UTC (permalink / raw
To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Arindam Nath, Alex Deucher
[-- Attachment #1.1.1: Type: text/plain, Size: 1675 bytes --]
Reviewed-by: Edward O'Callaghan <funfunctor-dczkZgxz+BNUPWh3PAxdjQ@public.gmane.org>
On 12/08/2016 06:28 AM, Alex Deucher wrote:
> From: Arindam Nath <arindam.nath-5C7GfCeVMHo@public.gmane.org>
>
> For CZ, some function pointers like display_configuration_changed
> are not set. So when HW manager tries to configure display, we
> end up with messages like
>
> "[ powerplay ] this function not implement!"
>
> in the logs. This message is informational, but lacks details
> on which function is not implemented and why.
>
> Rather than using KERN_INFO to print the message everytime the
> system boots, we rather use pr_debug so that it is only printed
> when debug prints are enabled at runtime.
>
> Reviewed-by: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
> Signed-off-by: Arindam Nath <arindam.nath-5C7GfCeVMHo@public.gmane.org>
> Signed-off-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> index a6abe81..71822ae 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> @@ -35,7 +35,7 @@ static int phm_run_table(struct pp_hwmgr *hwmgr,
> phm_table_function *function;
>
> if (rt_table->function_list == NULL) {
> - printk(KERN_INFO "[ powerplay ] this function not implement!\n");
> + pr_debug("[ powerplay ] this function not implement!\n");
> return 0;
> }
>
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-08 0:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-07 19:28 [PATCH] drm/amd/powerplay: use pr_debug to print function not implemented message Alex Deucher
[not found] ` <1481138889-10312-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2016-12-08 0:36 ` Edward O'Callaghan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.