All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* Patch "spi: s3c64xx: fix inconsistency between binding and driver" has been added to the 4.10-stable tree
@ 2017-03-08  9:17 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-03-08  9:17 UTC (permalink / raw
  To: andi.shyti, broonie, gregkh, krzk; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    spi: s3c64xx: fix inconsistency between binding and driver

to the 4.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     spi-s3c64xx-fix-inconsistency-between-binding-and-driver.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 379f831a927817c130a62e3ca0082ae685557324 Mon Sep 17 00:00:00 2001
From: Andi Shyti <andi.shyti@samsung.com>
Date: Fri, 10 Feb 2017 11:20:19 +0900
Subject: spi: s3c64xx: fix inconsistency between binding and driver

From: Andi Shyti <andi.shyti@samsung.com>

commit 379f831a927817c130a62e3ca0082ae685557324 upstream.

Commit a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS
line is not connected") introduced an inconsistency between the
binding, where the disconnected CS line was marked as
'no-cs-readback', and the driver.

The driver is erroneously checking for that attribute with
property name of 'broken-cs'.

Check for 'no-cs-readback' in the driver as well.

Fixes: a92e7c3d82a1 ("spi: s3c64xx: consider the case when the CS line is not connected")
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/spi/spi-s3c64xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -996,7 +996,7 @@ static struct s3c64xx_spi_info *s3c64xx_
 		sci->num_cs = temp;
 	}
 
-	sci->no_cs = of_property_read_bool(dev->of_node, "broken-cs");
+	sci->no_cs = of_property_read_bool(dev->of_node, "no-cs-readback");
 
 	return sci;
 }


Patches currently in stable-queue which might be from andi.shyti@samsung.com are

queue-4.10/lirc_dev-lirc_-g-s-et_rec_mode-do-not-work.patch
queue-4.10/spi-s3c64xx-fix-inconsistency-between-binding-and-driver.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-08  9:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-08  9:17 Patch "spi: s3c64xx: fix inconsistency between binding and driver" has been added to the 4.10-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.