From: kajoljain <kjain@linux.ibm.com>
To: Nageswara Sastry <rnsastry@linux.ibm.com>
Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
peterz@infradead.org, maddy@linux.vnet.ibm.com,
santosh@fossix.org, aneesh.kumar@linux.ibm.com,
vaibhav@linux.ibm.com, dan.j.williams@intel.com,
ira.weiny@intel.com, Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
tglx@linutronix.de
Subject: Re: [PATCH v2 0/4] Add perf interface to expose nvdimm
Date: Thu, 17 Jun 2021 12:02:56 +0530 [thread overview]
Message-ID: <14a63986-8a99-26dc-d207-7ff902df3afa@linux.ibm.com> (raw)
In-Reply-To: <B216F74B-8542-4363-8A82-1E392D9C5929@linux.ibm.com>
On 6/16/21 4:25 PM, Nageswara Sastry wrote:
>
>
>> On 14-Jun-2021, at 10:53 AM, Kajol Jain <kjain@linux.ibm.com> wrote:
>>
>> Patchset adds performance stats reporting support for nvdimm.
>> Added interface includes support for pmu register/unregister
>> functions. A structure is added called nvdimm_pmu to be used for
>> adding arch/platform specific data such as supported events, cpumask
>> pmu event functions like event_init/add/read/del.
>> User could use the standard perf tool to access perf
>> events exposed via pmu.
>>
>> Added implementation to expose IBM pseries platform nmem*
>> device performance stats using this interface.
>> ...
>>
>> Patch1:
>> Introduces the nvdimm_pmu structure
>> Patch2:
>> Adds common interface to add arch/platform specific data
>> includes supported events, pmu event functions. It also
>> adds code for cpu hotplug support.
>> Patch3:
>> Add code in arch/powerpc/platform/pseries/papr_scm.c to expose
>> nmem* pmu. It fills in the nvdimm_pmu structure with event attrs
>> cpumask andevent functions and then registers the pmu by adding
>> callbacks to register_nvdimm_pmu.
>> Patch4:
>> Sysfs documentation patch
>
> Tested with the following scenarios:
> 1. Check dmesg for nmem PMU registered messages.
> 2. Listed nmem events using 'perf list and perf list nmem'
> 3. Ran 'perf stat' with single event, grouping events, events from same pmu,
> different pmu and invalid events
> 4. Read from sysfs files, Writing in to sysfs files
> 5. While running nmem events with perf stat, offline cpu from the nmem?/cpumask
>
> While running the above functionality worked as expected, no error messages seen
> in dmesg.
>
> Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>
Hi Nageswara,
Thanks for testing the patch-set.
There is a nit change which need to be done in patch 4(Documentation patch).
We need to update nvdimm mailing list from linux-nvdimm@lists.01.org to
nvdimm@lists.linux.dev.
I will make this change and send a new patch-set with your tested-by tag.
Thanks,
Kajol Jain
>
>>
>> Changelog
>> ---
>> PATCH v1 -> PATCH v2
>> - Fix hotplug code by adding pmu migration call
>> incase current designated cpu got offline. As
>> pointed by Peter Zijlstra.
>>
>> - Removed the retun -1 part from cpu hotplug offline
>> function.
>>
>> - Link to the previous patchset : https://lkml.org/lkml/2021/6/8/500
>> ---
>> Kajol Jain (4):
>> drivers/nvdimm: Add nvdimm pmu structure
>> drivers/nvdimm: Add perf interface to expose nvdimm performance stats
>> powerpc/papr_scm: Add perf interface support
>> powerpc/papr_scm: Document papr_scm sysfs event format entries
>>
>> Documentation/ABI/testing/sysfs-bus-papr-pmem | 31 ++
>> arch/powerpc/include/asm/device.h | 5 +
>> arch/powerpc/platforms/pseries/papr_scm.c | 365 ++++++++++++++++++
>> drivers/nvdimm/Makefile | 1 +
>> drivers/nvdimm/nd_perf.c | 230 +++++++++++
>> include/linux/nd.h | 46 +++
>> 6 files changed, 678 insertions(+)
>> create mode 100644 drivers/nvdimm/nd_perf.c
>>
> Thanks and Regards,
> R.Nageswara Sastry
>
>>
>
WARNING: multiple messages have this Message-ID (diff)
From: kajoljain <kjain@linux.ibm.com>
To: Nageswara Sastry <rnsastry@linux.ibm.com>
Cc: nvdimm@lists.linux.dev, santosh@fossix.org,
maddy@linux.vnet.ibm.com, ira.weiny@intel.com,
peterz@infradead.org, linux-kernel@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
aneesh.kumar@linux.ibm.com, vaibhav@linux.ibm.com,
dan.j.williams@intel.com, linuxppc-dev@lists.ozlabs.org,
tglx@linutronix.de
Subject: Re: [PATCH v2 0/4] Add perf interface to expose nvdimm
Date: Thu, 17 Jun 2021 12:02:56 +0530 [thread overview]
Message-ID: <14a63986-8a99-26dc-d207-7ff902df3afa@linux.ibm.com> (raw)
In-Reply-To: <B216F74B-8542-4363-8A82-1E392D9C5929@linux.ibm.com>
On 6/16/21 4:25 PM, Nageswara Sastry wrote:
>
>
>> On 14-Jun-2021, at 10:53 AM, Kajol Jain <kjain@linux.ibm.com> wrote:
>>
>> Patchset adds performance stats reporting support for nvdimm.
>> Added interface includes support for pmu register/unregister
>> functions. A structure is added called nvdimm_pmu to be used for
>> adding arch/platform specific data such as supported events, cpumask
>> pmu event functions like event_init/add/read/del.
>> User could use the standard perf tool to access perf
>> events exposed via pmu.
>>
>> Added implementation to expose IBM pseries platform nmem*
>> device performance stats using this interface.
>> ...
>>
>> Patch1:
>> Introduces the nvdimm_pmu structure
>> Patch2:
>> Adds common interface to add arch/platform specific data
>> includes supported events, pmu event functions. It also
>> adds code for cpu hotplug support.
>> Patch3:
>> Add code in arch/powerpc/platform/pseries/papr_scm.c to expose
>> nmem* pmu. It fills in the nvdimm_pmu structure with event attrs
>> cpumask andevent functions and then registers the pmu by adding
>> callbacks to register_nvdimm_pmu.
>> Patch4:
>> Sysfs documentation patch
>
> Tested with the following scenarios:
> 1. Check dmesg for nmem PMU registered messages.
> 2. Listed nmem events using 'perf list and perf list nmem'
> 3. Ran 'perf stat' with single event, grouping events, events from same pmu,
> different pmu and invalid events
> 4. Read from sysfs files, Writing in to sysfs files
> 5. While running nmem events with perf stat, offline cpu from the nmem?/cpumask
>
> While running the above functionality worked as expected, no error messages seen
> in dmesg.
>
> Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com>
Hi Nageswara,
Thanks for testing the patch-set.
There is a nit change which need to be done in patch 4(Documentation patch).
We need to update nvdimm mailing list from linux-nvdimm@lists.01.org to
nvdimm@lists.linux.dev.
I will make this change and send a new patch-set with your tested-by tag.
Thanks,
Kajol Jain
>
>>
>> Changelog
>> ---
>> PATCH v1 -> PATCH v2
>> - Fix hotplug code by adding pmu migration call
>> incase current designated cpu got offline. As
>> pointed by Peter Zijlstra.
>>
>> - Removed the retun -1 part from cpu hotplug offline
>> function.
>>
>> - Link to the previous patchset : https://lkml.org/lkml/2021/6/8/500
>> ---
>> Kajol Jain (4):
>> drivers/nvdimm: Add nvdimm pmu structure
>> drivers/nvdimm: Add perf interface to expose nvdimm performance stats
>> powerpc/papr_scm: Add perf interface support
>> powerpc/papr_scm: Document papr_scm sysfs event format entries
>>
>> Documentation/ABI/testing/sysfs-bus-papr-pmem | 31 ++
>> arch/powerpc/include/asm/device.h | 5 +
>> arch/powerpc/platforms/pseries/papr_scm.c | 365 ++++++++++++++++++
>> drivers/nvdimm/Makefile | 1 +
>> drivers/nvdimm/nd_perf.c | 230 +++++++++++
>> include/linux/nd.h | 46 +++
>> 6 files changed, 678 insertions(+)
>> create mode 100644 drivers/nvdimm/nd_perf.c
>>
> Thanks and Regards,
> R.Nageswara Sastry
>
>>
>
next prev parent reply other threads:[~2021-06-17 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 5:23 [PATCH v2 0/4] Add perf interface to expose nvdimm Kajol Jain
2021-06-14 5:23 ` Kajol Jain
2021-06-14 5:23 ` [PATCH v2 1/4] drivers/nvdimm: Add nvdimm pmu structure Kajol Jain
2021-06-14 5:23 ` Kajol Jain
2021-06-14 5:23 ` [PATCH v2 2/4] drivers/nvdimm: Add perf interface to expose nvdimm performance stats Kajol Jain
2021-06-14 5:23 ` Kajol Jain
2021-06-14 5:23 ` [PATCH v2 3/4] powerpc/papr_scm: Add perf interface support Kajol Jain
2021-06-14 5:23 ` Kajol Jain
2021-06-14 5:23 ` [PATCH v2 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries Kajol Jain
2021-06-14 5:23 ` Kajol Jain
2021-06-16 10:55 ` [PATCH v2 0/4] Add perf interface to expose nvdimm Nageswara Sastry
2021-06-16 10:55 ` Nageswara Sastry
2021-06-17 6:32 ` kajoljain [this message]
2021-06-17 6:32 ` kajoljain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14a63986-8a99-26dc-d207-7ff902df3afa@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nvdimm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rnsastry@linux.ibm.com \
--cc=santosh@fossix.org \
--cc=tglx@linutronix.de \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.