From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <luca.boccassi@gmail.com>
Subject: Re: [PATCH] igb_uio: remove PCI reset during uio device
 open
Date: Thu, 21 Sep 2017 11:00:31 +0100
Message-ID: <1505988031.28679.2.camel@gmail.com>
References: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
 <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>,  "Yang, Qiming" <qiming.yang@intel.com>, "Patil,
 Harish" <Harish.Patil@cavium.com>, "Zhang, Helin" <helin.zhang@intel.com>,
 Gregory Etelson <gregory@weka.io>, "Tan, Jianfeng"
 <jianfeng.tan@intel.com>, "Hu, Xuekun" <xuekun.hu@intel.com>, "Li, Xiaoyun"
 <xiaoyun.li@intel.com>, "Thotton, Shijith" <Shijith.Thotton@cavium.com>,
 stable@dpdk.org, 3chas3@gmail.com
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1505816653-28715-1-git-send-email-shijith.thotton@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2017-09-19 at 15:54 +0530, Shijith Thotton wrote:
> Issuing reset during uio device open caused PMD init failure for some
> NIC VFs (i40, ixgbe, qede) in host. So this initial reset is removed.
> Bus master enable is kept as part of open since we disable it in uio
> device release.
>=20
> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of
> device file")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
> ---
> =C2=A0lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 +---
> =C2=A01 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> index 07a19a3..a6c2996 100644
> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> @@ -179,9 +179,7 @@ struct rte_uio_pci_dev {
> =C2=A0	struct rte_uio_pci_dev *udev =3D info->priv;
> =C2=A0	struct pci_dev *dev =3D udev->pdev;
> =C2=A0
> -	pci_reset_function(dev);
> -
> -	/* set bus master, which was cleared by the reset function
> */
> +	/* enable bus mastering on the device */
> =C2=A0	pci_set_master(dev);
> =C2=A0
> =C2=A0	return 0;

Tested-by: Luca Boccassi <luca.boccassi@att.com>

Hi, we had the same issue, Chas applied and tested this patch on top of
17.08 and our QA department confirms that it fixes the problem.

--=20
Kind regards,
Luca Boccassi