From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create() Date: Wed, 05 Aug 2015 15:15:46 +0200 Message-ID: <1514392.p4W8R5bZo1@xps13> References: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bernard Iremonger Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 35129559C for ; Wed, 5 Aug 2015 15:17:02 +0200 (CEST) Received: by wicgj17 with SMTP id gj17so192160625wic.1 for ; Wed, 05 Aug 2015 06:17:02 -0700 (PDT) In-Reply-To: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-08-05 13:36, Bernard Iremonger: > if the name parameter to rte_eth_bond_create() was NULL, > there was a segmentation fault because eth_dev was also NULL. You also add error handling of mac_addrs alloc and release_port(). It deserves to be said in this commit message.