* [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check
@ 2020-05-04 7:48 Vandita Kulkarni
2020-05-04 9:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Vandita Kulkarni @ 2020-05-04 7:48 UTC (permalink / raw
To: intel-gfx
For all ddi, encoder->type holds output type as ddi,
assigning it to individual o/p types is no more valid.
Fixes: 362bfb995b78 ("drm/i915/tgl: Add DKL PHY vswing table for HDMI")
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 5601673c3f30..10d70daf714b 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2579,14 +2579,14 @@ static void icl_ddi_vswing_sequence(struct intel_encoder *encoder,
static void
tgl_dkl_phy_ddi_vswing_sequence(struct intel_encoder *encoder, int link_clock,
- u32 level)
+ u32 level, enum intel_output_type type)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
enum tc_port tc_port = intel_port_to_tc(dev_priv, encoder->port);
const struct tgl_dkl_phy_ddi_buf_trans *ddi_translations;
u32 n_entries, val, ln, dpcnt_mask, dpcnt_val;
- if (encoder->type == INTEL_OUTPUT_HDMI) {
+ if (type == INTEL_OUTPUT_HDMI) {
n_entries = ARRAY_SIZE(tgl_dkl_phy_hdmi_ddi_trans);
ddi_translations = tgl_dkl_phy_hdmi_ddi_trans;
} else {
@@ -2638,7 +2638,7 @@ static void tgl_ddi_vswing_sequence(struct intel_encoder *encoder,
if (intel_phy_is_combo(dev_priv, phy))
icl_combo_phy_ddi_vswing_sequence(encoder, level, type);
else
- tgl_dkl_phy_ddi_vswing_sequence(encoder, link_clock, level);
+ tgl_dkl_phy_ddi_vswing_sequence(encoder, link_clock, level, type);
}
static u32 translate_signal_level(struct intel_dp *intel_dp, int signal_levels)
--
2.21.0.5.gaeb582a
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix the encoder type check
2020-05-04 7:48 [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check Vandita Kulkarni
@ 2020-05-04 9:34 ` Patchwork
2020-05-04 17:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-27 11:39 ` [Intel-gfx] [PATCH] " Shankar, Uma
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-04 9:34 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: Fix the encoder type check
URL : https://patchwork.freedesktop.org/series/76891/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8416 -> Patchwork_17563
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/index.html
Known issues
------------
Here are the changes found in Patchwork_17563 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-bsw-nick: [PASS][1] -> [INCOMPLETE][2] ([i915#1250])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/fi-bsw-nick/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/fi-bsw-nick/igt@debugfs_test@read_all_entries.html
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [SKIP][3] ([fdo#109271]) -> [FAIL][4] ([i915#62])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/fi-kbl-x1275/igt@i915_pm_rpm@module-reload.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1250]: https://gitlab.freedesktop.org/drm/intel/issues/1250
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Participating hosts (50 -> 44)
------------------------------
Additional (1): fi-gdg-551
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8416 -> Patchwork_17563
CI-20190529: 20190529
CI_DRM_8416: 4aa25ab0331c40f5d475c651f5f4e3801b07f28d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5628: 652a3fd8966345fa5498904ce80a2027a6782783 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17563: 488a2963a2477192e86e025985f6c5c1984acfd4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
488a2963a247 drm/i915/display: Fix the encoder type check
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Fix the encoder type check
2020-05-04 7:48 [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check Vandita Kulkarni
2020-05-04 9:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-05-04 17:46 ` Patchwork
2020-05-27 11:39 ` [Intel-gfx] [PATCH] " Shankar, Uma
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-04 17:46 UTC (permalink / raw
To: Vandita Kulkarni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: Fix the encoder type check
URL : https://patchwork.freedesktop.org/series/76891/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8416_full -> Patchwork_17563_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17563_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-iclb2/igt@gem_exec_params@invalid-bsd-ring.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-iclb8/igt@gem_exec_params@invalid-bsd-ring.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge:
- shard-apl: [PASS][5] -> [FAIL][6] ([i915#70] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-apl3/igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-apl7/igt@kms_cursor_edge_walk@pipe-a-256x256-bottom-edge.html
* igt@kms_cursor_legacy@pipe-b-forked-bo:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([i915#61]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-hsw1/igt@kms_cursor_legacy@pipe-b-forked-bo.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-hsw2/igt@kms_cursor_legacy@pipe-b-forked-bo.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#52] / [i915#54])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-glk7/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-glk6/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
* igt@kms_flip_tiling@flip-changes-tiling-y:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#95])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-apl1/igt@kms_flip_tiling@flip-changes-tiling-y.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-apl3/igt@kms_flip_tiling@flip-changes-tiling-y.html
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#699] / [i915#93] / [i915#95])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-kbl1/igt@kms_flip_tiling@flip-changes-tiling-y.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-kbl1/igt@kms_flip_tiling@flip-changes-tiling-y.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#1188])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-skl6/igt@kms_hdr@bpc-switch.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-skl10/igt@kms_hdr@bpc-switch.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [PASS][21] -> [INCOMPLETE][22] ([i915#155] / [i915#794])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-kbl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-kbl6/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
#### Possible fixes ####
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [FAIL][23] ([i915#54]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-skl10/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][25] ([fdo#109349]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-glk: [FAIL][27] ([i915#177] / [i915#52] / [i915#54]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-glk1/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-skl: [FAIL][29] ([i915#177] / [i915#52] / [i915#54]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-skl6/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-skl10/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled.html
* {igt@kms_flip@flip-vs-suspend-interruptible@a-edp1}:
- shard-skl: [INCOMPLETE][31] ([i915#198]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-skl5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* {igt@kms_flip@flip-vs-suspend@c-dp1}:
- shard-kbl: [DMESG-WARN][33] ([i915#180]) -> [PASS][34] +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
- shard-apl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][37] ([i915#1188]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-skl1/igt@kms_hdr@bpc-switch-dpms.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][39] ([fdo#108145] / [i915#265]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][41] ([fdo#109441]) -> [PASS][42] +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* {igt@perf@blocking-parameterized}:
- shard-kbl: [FAIL][43] ([i915#1542]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-kbl1/igt@perf@blocking-parameterized.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-kbl4/igt@perf@blocking-parameterized.html
* {igt@perf@polling-parameterized}:
- shard-hsw: [FAIL][45] ([i915#1542]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8416/shard-hsw6/igt@perf@polling-parameterized.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/shard-hsw4/igt@perf@polling-parameterized.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#177]: https://gitlab.freedesktop.org/drm/intel/issues/177
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#794]: https://gitlab.freedesktop.org/drm/intel/issues/794
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8416 -> Patchwork_17563
CI-20190529: 20190529
CI_DRM_8416: 4aa25ab0331c40f5d475c651f5f4e3801b07f28d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5628: 652a3fd8966345fa5498904ce80a2027a6782783 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17563: 488a2963a2477192e86e025985f6c5c1984acfd4 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17563/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check
2020-05-04 7:48 [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check Vandita Kulkarni
2020-05-04 9:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-04 17:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-05-27 11:39 ` Shankar, Uma
2 siblings, 0 replies; 4+ messages in thread
From: Shankar, Uma @ 2020-05-27 11:39 UTC (permalink / raw
To: Kulkarni, Vandita, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Vandita
> Kulkarni
> Sent: Monday, May 4, 2020 1:19 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check
>
> For all ddi, encoder->type holds output type as ddi, assigning it to individual o/p
> types is no more valid.
>
> Fixes: 362bfb995b78 ("drm/i915/tgl: Add DKL PHY vswing table for HDMI")
Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 5601673c3f30..10d70daf714b 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2579,14 +2579,14 @@ static void icl_ddi_vswing_sequence(struct
> intel_encoder *encoder,
>
> static void
> tgl_dkl_phy_ddi_vswing_sequence(struct intel_encoder *encoder, int link_clock,
> - u32 level)
> + u32 level, enum intel_output_type type)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> enum tc_port tc_port = intel_port_to_tc(dev_priv, encoder->port);
> const struct tgl_dkl_phy_ddi_buf_trans *ddi_translations;
> u32 n_entries, val, ln, dpcnt_mask, dpcnt_val;
>
> - if (encoder->type == INTEL_OUTPUT_HDMI) {
> + if (type == INTEL_OUTPUT_HDMI) {
> n_entries = ARRAY_SIZE(tgl_dkl_phy_hdmi_ddi_trans);
> ddi_translations = tgl_dkl_phy_hdmi_ddi_trans;
> } else {
> @@ -2638,7 +2638,7 @@ static void tgl_ddi_vswing_sequence(struct
> intel_encoder *encoder,
> if (intel_phy_is_combo(dev_priv, phy))
> icl_combo_phy_ddi_vswing_sequence(encoder, level, type);
> else
> - tgl_dkl_phy_ddi_vswing_sequence(encoder, link_clock, level);
> + tgl_dkl_phy_ddi_vswing_sequence(encoder, link_clock, level,
> type);
> }
>
> static u32 translate_signal_level(struct intel_dp *intel_dp, int signal_levels)
> --
> 2.21.0.5.gaeb582a
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-27 11:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-04 7:48 [Intel-gfx] [PATCH] drm/i915/display: Fix the encoder type check Vandita Kulkarni
2020-05-04 9:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-04 17:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-27 11:39 ` [Intel-gfx] [PATCH] " Shankar, Uma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.