* [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static
@ 2021-02-24 8:30 Jiapeng Chong
2021-02-25 0:44 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-24 8:30 UTC (permalink / raw
To: paulmck
Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, joel, rcu,
linux-kernel, Jiapeng Chong
Fix the following sparse warning:
kernel/rcu/tree_plugin.h:1497:5: warning: symbol
'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static?
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/rcu/tree_plugin.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 2d60377..8ff8cf8 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -1494,7 +1494,7 @@ static int __init parse_rcu_nocb_poll(char *arg)
* After all, the main point of bypassing is to avoid lock contention
* on ->nocb_lock, which only can happen at high call_rcu() rates.
*/
-int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
+static int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
module_param(nocb_nobypass_lim_per_jiffy, int, 0);
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static
2021-02-24 8:30 [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static Jiapeng Chong
@ 2021-02-25 0:44 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2021-02-25 0:44 UTC (permalink / raw
To: Jiapeng Chong
Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, joel, rcu,
linux-kernel
On Wed, Feb 24, 2021 at 04:30:29PM +0800, Jiapeng Chong wrote:
> Fix the following sparse warning:
>
> kernel/rcu/tree_plugin.h:1497:5: warning: symbol
> 'nocb_nobypass_lim_per_jiffy' was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Queued with Frederic's ack (given offlist), thank you both!
Thanx, Paul
> ---
> kernel/rcu/tree_plugin.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 2d60377..8ff8cf8 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -1494,7 +1494,7 @@ static int __init parse_rcu_nocb_poll(char *arg)
> * After all, the main point of bypassing is to avoid lock contention
> * on ->nocb_lock, which only can happen at high call_rcu() rates.
> */
> -int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> +static int nocb_nobypass_lim_per_jiffy = 16 * 1000 / HZ;
> module_param(nocb_nobypass_lim_per_jiffy, int, 0);
>
> /*
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-25 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-24 8:30 [PATCH] rcu: make nocb_nobypass_lim_per_jiffy static Jiapeng Chong
2021-02-25 0:44 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.