From: Pierre Morel <pmorel@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
cohuck@redhat.com, imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH v6 6/6] s390x: css: testing measurement block format 1
Date: Fri, 12 Mar 2021 11:41:54 +0100 [thread overview]
Message-ID: <1615545714-13747-7-git-send-email-pmorel@linux.ibm.com> (raw)
In-Reply-To: <1615545714-13747-1-git-send-email-pmorel@linux.ibm.com>
Measurement block format 1 is made available by the extended
measurement block facility and is indicated in the SCHIB by
the bit in the PMCW.
The MBO is specified in the SCHIB of each channel and the MBO
defined by the SCHM instruction is ignored.
The test of the MB format 1 is just skipped if the feature is
not available.
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
lib/s390x/css.h | 15 +++++++++
lib/s390x/css_lib.c | 2 +-
s390x/css.c | 75 +++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 91 insertions(+), 1 deletion(-)
diff --git a/lib/s390x/css.h b/lib/s390x/css.h
index 335bc70..7e3d261 100644
--- a/lib/s390x/css.h
+++ b/lib/s390x/css.h
@@ -107,6 +107,7 @@ struct schib {
uint64_t mbo;
uint8_t md[4];
} __attribute__ ((aligned(4)));
+extern struct schib schib;
struct irb {
struct scsw scsw;
@@ -386,4 +387,18 @@ struct measurement_block_format0 {
uint32_t initial_cmd_resp_time;
};
+struct measurement_block_format1 {
+ uint32_t ssch_rsch_count;
+ uint32_t sample_count;
+ uint32_t device_connect_time;
+ uint32_t function_pending_time;
+ uint32_t device_disconnect_time;
+ uint32_t cu_queuing_time;
+ uint32_t device_active_only_time;
+ uint32_t device_busy_time;
+ uint32_t initial_cmd_resp_time;
+ uint32_t irq_delay_time;
+ uint32_t irq_prio_delay_time;
+};
+
#endif
diff --git a/lib/s390x/css_lib.c b/lib/s390x/css_lib.c
index 8f09383..efc7057 100644
--- a/lib/s390x/css_lib.c
+++ b/lib/s390x/css_lib.c
@@ -19,7 +19,7 @@
#include <malloc_io.h>
#include <css.h>
-static struct schib schib;
+struct schib schib;
struct chsc_scsc *chsc_scsc;
static const char * const chsc_rsp_description[] = {
diff --git a/s390x/css.c b/s390x/css.c
index 658c5f8..c340c53 100644
--- a/s390x/css.c
+++ b/s390x/css.c
@@ -257,6 +257,80 @@ static void test_schm_fmt0(void)
free_io_mem(mb0, shared_mb_size);
}
+static void msch_with_wrong_fmt1_mbo(unsigned int schid, uint64_t mb)
+{
+ struct pmcw *pmcw = &schib.pmcw;
+ int cc;
+
+ /* Read the SCHIB for this subchannel */
+ cc = stsch(schid, &schib);
+ if (cc) {
+ report(0, "stsch: sch %08x failed with cc=%d", schid, cc);
+ return;
+ }
+
+ /* Update the SCHIB to enable the measurement block */
+ pmcw->flags |= PMCW_MBUE;
+ pmcw->flags2 |= PMCW_MBF1;
+ schib.mbo = mb;
+
+ /* Tell the CSS we want to modify the subchannel */
+ expect_pgm_int();
+ cc = msch(schid, &schib);
+ check_pgm_int_code(PGM_INT_CODE_OPERAND);
+}
+
+/*
+ * test_schm_fmt1:
+ * With measurement block format 1 the measurement block is
+ * dedicated to a subchannel.
+ */
+static void test_schm_fmt1(void)
+{
+ struct measurement_block_format1 *mb1;
+
+ if (!test_device_sid) {
+ report_skip("No device");
+ return;
+ }
+
+ if (!css_test_general_feature(CSSC_EXTENDED_MEASUREMENT_BLOCK)) {
+ report_skip("Extended measurement block not available");
+ return;
+ }
+
+ /* Allocate zeroed Measurement block */
+ mb1 = alloc_io_mem(sizeof(struct measurement_block_format1), 0);
+ if (!mb1) {
+ report_abort("measurement_block_format1 allocation failed");
+ return;
+ }
+
+ schm(NULL, 0); /* Stop any previous measurement */
+ schm(0, SCHM_MBU);
+
+ /* Expect error for non aligned MB */
+ report_prefix_push("Unaligned MB origin");
+ msch_with_wrong_fmt1_mbo(test_device_sid, (uint64_t)mb1 + 1);
+ report_prefix_pop();
+
+ /* Clear the measurement block for the next test */
+ memset(mb1, 0, sizeof(*mb1));
+
+ /* Expect success */
+ report_prefix_push("Valid MB origin");
+ if (start_measuring((u64)mb1, 0, true))
+ report(mb1->ssch_rsch_count == SCHM_UPDATE_CNT,
+ "SSCH measured %d", mb1->ssch_rsch_count);
+ report_prefix_pop();
+
+ /* Stop the measurement */
+ css_disable_mb(test_device_sid);
+ schm(NULL, 0);
+
+ free_io_mem(mb1, sizeof(struct measurement_block_format1));
+}
+
static struct {
const char *name;
void (*func)(void);
@@ -268,6 +342,7 @@ static struct {
{ "sense (ssch/tsch)", test_sense },
{ "measurement block (schm)", test_schm },
{ "measurement block format0", test_schm_fmt0 },
+ { "measurement block format1", test_schm_fmt1 },
{ NULL, NULL }
};
--
2.17.1
next prev parent reply other threads:[~2021-03-12 10:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 10:41 [kvm-unit-tests PATCH v6 0/6] CSS Mesurement Block Pierre Morel
2021-03-12 10:41 ` [kvm-unit-tests PATCH v6 1/6] s390x: css: Store CSS Characteristics Pierre Morel
2021-03-12 10:41 ` [kvm-unit-tests PATCH v6 2/6] s390x: css: simplifications of the tests Pierre Morel
2021-03-15 10:48 ` Janosch Frank
2021-03-16 10:27 ` Pierre Morel
2021-03-12 10:41 ` [kvm-unit-tests PATCH v6 3/6] s390x: css: extending the subchannel modifying functions Pierre Morel
2021-03-15 10:50 ` Janosch Frank
2021-03-16 10:26 ` Pierre Morel
2021-03-12 10:41 ` [kvm-unit-tests PATCH v6 4/6] s390x: css: implementing Set CHannel Monitor Pierre Morel
2021-03-12 10:41 ` [kvm-unit-tests PATCH v6 5/6] s390x: css: testing measurement block format 0 Pierre Morel
2021-03-12 11:17 ` Cornelia Huck
2021-03-16 10:26 ` Pierre Morel
2021-03-15 10:53 ` Janosch Frank
2021-03-16 10:27 ` Pierre Morel
2021-03-12 10:41 ` Pierre Morel [this message]
2021-03-12 11:18 ` [kvm-unit-tests PATCH v6 0/6] CSS Mesurement Block Cornelia Huck
2021-03-12 14:17 ` Janosch Frank
2021-03-16 9:39 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615545714-13747-7-git-send-email-pmorel@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.