From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Default request/fence expiry + watchdog
Date: Fri, 12 Mar 2021 16:22:11 -0000 [thread overview]
Message-ID: <161556613174.8355.6299030111253031306@emeril.freedesktop.org> (raw)
In-Reply-To: <20210312154622.1767865-1-tvrtko.ursulin@linux.intel.com>
== Series Details ==
Series: Default request/fence expiry + watchdog
URL : https://patchwork.freedesktop.org/series/87930/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
865f5ed6eec8 drm/i915: Individual request cancellation
-:256: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_inactive', this function's name, in a string
#256: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:660:
+ pr_err("%s: __cancel_inactive error %d\n", engine->name, err);
-:317: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_active', this function's name, in a string
#317: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:721:
+ pr_err("%s: __cancel_active error %d\n", engine->name, err);
-:388: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_active_chain', this function's name, in a string
#388: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:792:
+ pr_err("%s: __cancel_active_chain error %d\n",
-:438: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_completed', this function's name, in a string
#438: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:842:
+ pr_err("%s: __cancel_completed error %d\n", engine->name, err);
total: 0 errors, 4 warnings, 0 checks, 444 lines checked
5b101fa80277 drm/i915: Restrict sentinel requests further
c4f617682a6d drm/i915: Request watchdog infrastructure
-:197: WARNING:LONG_LINE_COMMENT: line length of 124 exceeds 100 columns
#197: FILE: drivers/gpu/drm/i915/i915_request.c:314:
+ NSEC_PER_MSEC, /* FIXME check if it gives the "not sooner" guarantee or slack is both ways */
total: 0 errors, 1 warnings, 0 checks, 190 lines checked
9e458012bb44 drm/i915: Allow userspace to configure the watchdog
5d0b88dfca39 drm/i915: Fail too long user submissions by default
7f4fb6d644b5 drm/i915: Allow configuring default request expiry via modparam
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-03-12 16:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 15:46 [Intel-gfx] [RFC 0/6] Default request/fence expiry + watchdog Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-12 15:46 ` [Intel-gfx] [RFC 1/6] drm/i915: Individual request cancellation Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-15 17:37 ` [Intel-gfx] " Tvrtko Ursulin
2021-03-15 17:37 ` Tvrtko Ursulin
2021-03-16 10:02 ` Daniel Vetter
2021-03-16 10:02 ` Daniel Vetter
2021-03-12 15:46 ` [Intel-gfx] [RFC 2/6] drm/i915: Restrict sentinel requests further Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-12 15:46 ` [Intel-gfx] [RFC 3/6] drm/i915: Request watchdog infrastructure Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-12 15:46 ` [Intel-gfx] [RFC 4/6] drm/i915: Allow userspace to configure the watchdog Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-16 10:09 ` [Intel-gfx] " Daniel Vetter
2021-03-16 10:09 ` Daniel Vetter
2021-03-12 15:46 ` [Intel-gfx] [RFC 5/6] drm/i915: Fail too long user submissions by default Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-16 10:10 ` [Intel-gfx] " Daniel Vetter
2021-03-16 10:10 ` Daniel Vetter
2021-03-12 15:46 ` [Intel-gfx] [RFC 6/6] drm/i915: Allow configuring default request expiry via modparam Tvrtko Ursulin
2021-03-12 15:46 ` Tvrtko Ursulin
2021-03-16 10:03 ` Daniel Vetter
2021-03-16 10:03 ` [Intel-gfx] " Daniel Vetter
2021-03-12 16:22 ` Patchwork [this message]
2021-03-12 16:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Default request/fence expiry + watchdog Patchwork
2021-03-12 18:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161556613174.8355.6299030111253031306@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.