* [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions
@ 2021-04-12 5:46 Ville Syrjala
2021-04-12 5:46 ` [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a Ville Syrjala
` (8 more replies)
0 siblings, 9 replies; 17+ messages in thread
From: Ville Syrjala @ 2021-04-12 5:46 UTC (permalink / raw
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fix a couple of regressions due to the glk display version 9->10
change. I *think* all the ones that slipped through involved
either DISPLAY_VER==9 or DISPLAY_VER<10 checks. These three
regressions are the ones I found through a quick scan, but someone
should probably go through the whole tree with a fine toothcomb
in case we missed more cases.
Also tossed in a couple of cleanups.
Cc: Matt Roper <matthew.d.roper@intel.com>
Ville Syrjälä (5):
drm/i915: Restore lost glk FBC 16bpp w/a
drm/i915: Restore lost glk ccs w/a
drm/i915: Disable LTTPR detection on GLK once again
drm/i915: Don't use {skl,cnl}_hpd_pin() for bxt/glk
drm/i915: Remove a few redundant glk checks
drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +-
5 files changed, 8 insertions(+), 7 deletions(-)
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
@ 2021-04-12 5:46 ` Ville Syrjala
2021-04-14 9:14 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a Ville Syrjala
` (7 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjala @ 2021-04-12 5:46 UTC (permalink / raw
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We lost the FBC 16bpp 512byte stride requirement on glk when
we switched from display version 9 to 10. Restore the w/a to
avoid enabling FBC with a bad stride and thus display garbage.
Cc: Matt Roper <matthew.d.roper@intel.com>
Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 04d9c7d22b04..dcc0f73ea225 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -598,7 +598,7 @@ static bool stride_is_valid(struct drm_i915_private *dev_priv,
return false;
/* Display WA #1105: skl,bxt,kbl,cfl,glk */
- if (IS_DISPLAY_VER(dev_priv, 9) &&
+ if ((IS_DISPLAY_VER(dev_priv, 9) || IS_GEMINILAKE(dev_priv)) &&
modifier == DRM_FORMAT_MOD_LINEAR && stride & 511)
return false;
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
2021-04-12 5:46 ` [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a Ville Syrjala
@ 2021-04-12 5:46 ` Ville Syrjala
2021-04-14 9:18 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again Ville Syrjala
` (6 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjala @ 2021-04-12 5:46 UTC (permalink / raw
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
We lost a CCS related w/a on glk when the display version
became 10 instead of 9. Restore the correct check.
Cc: Matt Roper <matthew.d.roper@intel.com>
Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 411b46c012f8..7eac893b4f96 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1406,7 +1406,8 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)
* require the entire fb to accommodate that to avoid
* potential runtime errors at plane configuration time.
*/
- if (IS_DISPLAY_VER(dev_priv, 9) && color_plane == 0 && fb->width > 3840)
+ if ((IS_DISPLAY_VER(dev_priv, 9) || IS_GEMINILAKE(dev_priv)) &&
+ color_plane == 0 && fb->width > 3840)
tile_width *= 4;
/*
* The main surface pitch must be padded to a multiple of four
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
2021-04-12 5:46 ` [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a Ville Syrjala
2021-04-12 5:46 ` [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a Ville Syrjala
@ 2021-04-12 5:46 ` Ville Syrjala
2021-04-14 9:19 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk Ville Syrjala
` (5 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjala @ 2021-04-12 5:46 UTC (permalink / raw
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The glk display version change is causing us to again attempt
LTTPR detection on glk. We must not do tha since glk doesn't
have a long enough AUX timeout. Restore the correct logic to
skip the detection.
Cc: Matt Roper <matthew.d.roper@intel.com>
Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index 5e9c3c74310c..597634e4f35f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -96,7 +96,7 @@ static bool intel_dp_read_lttpr_common_caps(struct intel_dp *intel_dp)
* Detecting LTTPRs must be avoided on platforms with an AUX timeout
* period < 3.2ms. (see DP Standard v2.0, 2.11.2, 3.6.6.1).
*/
- if (DISPLAY_VER(i915) < 10)
+ if (DISPLAY_VER(i915) < 10 || IS_GEMINILAKE(i915))
return false;
if (drm_dp_read_lttpr_common_caps(&intel_dp->aux,
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
` (2 preceding siblings ...)
2021-04-12 5:46 ` [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again Ville Syrjala
@ 2021-04-12 5:46 ` Ville Syrjala
2021-04-14 9:25 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks Ville Syrjala
` (4 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjala @ 2021-04-12 5:46 UTC (permalink / raw
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Just let bxt/glk fall back to intel_hpd_pin_default() instead
of using skl_hpd_pin() or cnl_hpd_pin(). Doesn't really matter
since both functions will end up returning the correct hpd pin
anyway, but I find it a bit less confusing when bxt/glk are
fully separated from the logic for the other platforms.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index deef24da00b5..e208ded9a688 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -4612,9 +4612,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
encoder->hpd_pin = ehl_hpd_pin(dev_priv, port);
else if (IS_DISPLAY_VER(dev_priv, 11))
encoder->hpd_pin = icl_hpd_pin(dev_priv, port);
- else if (IS_DISPLAY_VER(dev_priv, 10))
+ else if (IS_CANNONLAKE(dev_priv))
encoder->hpd_pin = cnl_hpd_pin(dev_priv, port);
- else if (IS_DISPLAY_VER(dev_priv, 9))
+ else if (IS_DISPLAY_VER(dev_priv, 9) && !IS_BROXTON(dev_priv))
encoder->hpd_pin = skl_hpd_pin(dev_priv, port);
else
encoder->hpd_pin = intel_hpd_pin_default(dev_priv, port);
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
` (3 preceding siblings ...)
2021-04-12 5:46 ` [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk Ville Syrjala
@ 2021-04-12 5:46 ` Ville Syrjala
2021-04-14 9:26 ` Jani Nikula
2021-04-12 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix glk display version regressions Patchwork
` (3 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Ville Syrjala @ 2021-04-12 5:46 UTC (permalink / raw
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Now that glk display version is 10 we can drop a few more glk checks.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index e208ded9a688..79ece9e45d66 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -176,7 +176,7 @@ static void intel_wait_ddi_buf_active(struct drm_i915_private *dev_priv,
enum port port)
{
/* Wait > 518 usecs for DDI_BUF_CTL to be non idle */
- if (DISPLAY_VER(dev_priv) < 10 && !IS_GEMINILAKE(dev_priv)) {
+ if (DISPLAY_VER(dev_priv) < 10) {
usleep_range(518, 1000);
return;
}
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 098636c811a8..5926ed1094a4 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -853,7 +853,7 @@ static u32 skl_plane_ctl(const struct intel_crtc_state *crtc_state,
plane_ctl = PLANE_CTL_ENABLE;
- if (DISPLAY_VER(dev_priv) < 10 && !IS_GEMINILAKE(dev_priv)) {
+ if (DISPLAY_VER(dev_priv) < 10) {
plane_ctl |= skl_plane_ctl_alpha(plane_state);
plane_ctl |= PLANE_CTL_PLANE_GAMMA_DISABLE;
--
2.26.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix glk display version regressions
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
` (4 preceding siblings ...)
2021-04-12 5:46 ` [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks Ville Syrjala
@ 2021-04-12 6:18 ` Patchwork
2021-04-12 6:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-04-12 6:18 UTC (permalink / raw
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix glk display version regressions
URL : https://patchwork.freedesktop.org/series/88938/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix glk display version regressions
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
` (5 preceding siblings ...)
2021-04-12 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix glk display version regressions Patchwork
@ 2021-04-12 6:40 ` Patchwork
2021-04-12 7:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-13 10:57 ` [Intel-gfx] [PATCH 0/5] " Jani Nikula
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-04-12 6:40 UTC (permalink / raw
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 3423 bytes --]
== Series Details ==
Series: drm/i915: Fix glk display version regressions
URL : https://patchwork.freedesktop.org/series/88938/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9955 -> Patchwork_19910
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/index.html
Known issues
------------
Here are the changes found in Patchwork_19910 that come from known issues:
### CI changes ###
### IGT changes ###
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-y: [DMESG-WARN][1] ([i915#1982]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/fi-tgl-y/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/fi-tgl-y/igt@core_hotunplug@unbind-rebind.html
* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [DMESG-WARN][3] ([i915#402]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/fi-tgl-y/igt@debugfs_test@read_all_entries.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-tgl-y: [DMESG-FAIL][5] ([i915#541]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][7] ([i915#1372]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2788]: https://gitlab.freedesktop.org/drm/intel/issues/2788
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (44 -> 39)
------------------------------
Additional (1): fi-dg1-1
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-glk-dsi fi-bsw-cyan fi-icl-y fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9955 -> Patchwork_19910
CI-20190529: 20190529
CI_DRM_9955: 77ebd079c5386d5864fa723222f4367de0cd408f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6063: d3b7f74ce5df6fdea03e490b7c64f0c6bfe76f03 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19910: 80cee6a874c3ae63cf7cf26583725dad0391a3fb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
80cee6a874c3 drm/i915: Remove a few redundant glk checks
2845b238fe10 drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk
fe1401b0dd85 drm/i915: Disable LTTPR detection on GLK once again
c09ee72b4433 drm/i915: Restore lost glk ccs w/a
2e896feb0fe1 drm/i915: Restore lost glk FBC 16bpp w/a
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/index.html
[-- Attachment #1.2: Type: text/html, Size: 4084 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix glk display version regressions
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
` (6 preceding siblings ...)
2021-04-12 6:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-04-12 7:53 ` Patchwork
2021-04-13 10:57 ` [Intel-gfx] [PATCH 0/5] " Jani Nikula
8 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2021-04-12 7:53 UTC (permalink / raw
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30268 bytes --]
== Series Details ==
Series: drm/i915: Fix glk display version regressions
URL : https://patchwork.freedesktop.org/series/88938/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9955_full -> Patchwork_19910_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19910_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-skl: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl9/igt@gem_create@create-massive.html
- shard-apl: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@gem_create@create-massive.html
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#146] / [i915#198] / [i915#2910])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl6/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb6/igt@gem_ctx_persistence@legacy-engines-mixed.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-tglb7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][8] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@big-copy:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#307])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk8/igt@gem_mmap_gtt@big-copy.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk8/igt@gem_mmap_gtt@big-copy.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [WARN][12] ([i915#2658])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb2/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-iclb: NOTRUN -> [WARN][13] ([i915#2658])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@linear-to-vebox-y-tiled:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271]) +230 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@gem_render_copy@linear-to-vebox-y-tiled.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][15] ([i915#768])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@input-checking:
- shard-snb: NOTRUN -> [DMESG-WARN][16] ([i915#3002])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb7/igt@gem_userptr_blits@input-checking.html
* igt@gem_userptr_blits@set-cache-level:
- shard-snb: NOTRUN -> [FAIL][17] ([i915#3324])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb7/igt@gem_userptr_blits@set-cache-level.html
* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][18] ([fdo#109289]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@gen7_exec_parse@oacontrol-tracking.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +362 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb6/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@bb-start-out:
- shard-iclb: NOTRUN -> [SKIP][20] ([fdo#112306])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb4/igt@gen9_exec_parse@bb-start-out.html
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#1769])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_atomic_transition@plane-all-modeset-transition-fencing.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#110725] / [fdo#111614])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_big_fb@y-tiled-64bpp-rotate-270.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#110723])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html
* igt@kms_big_joiner@basic:
- shard-apl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#2705])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl6/igt@kms_big_joiner@basic.html
* igt@kms_ccs@pipe-c-random-ccs-data:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111304])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl9/igt@kms_ccs@pipe-c-random-ccs-data.html
* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +15 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl8/igt@kms_chamelium@vga-edid-read.html
* igt@kms_color@pipe-b-ctm-0-5:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl9/igt@kms_color@pipe-b-ctm-0-5.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl1/igt@kms_color@pipe-b-ctm-0-5.html
* igt@kms_color@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109278] / [i915#1149])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_color@pipe-d-ctm-0-25.html
* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-skl: NOTRUN -> [SKIP][30] ([fdo#109271]) +33 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl9/igt@kms_color@pipe-d-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl3/igt@kms_color_chamelium@pipe-a-ctm-0-75.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl1/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-c-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109284] / [fdo#111827]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_color_chamelium@pipe-c-ctm-0-5.html
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-snb: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +22 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb7/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html
* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [FAIL][35] ([fdo#110321] / [fdo#110336])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@kms_content_protection@atomic.html
* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][36] ([i915#1319]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl1/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#3116])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb4/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278] / [fdo#109279]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109274] / [fdo#109278]) +6 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_dp_aux_dev:
- shard-iclb: [PASS][40] -> [DMESG-WARN][41] ([i915#262])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb6/igt@kms_dp_aux_dev.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_dp_aux_dev.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109274]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][43] -> [FAIL][44] ([i915#79])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [PASS][45] -> [FAIL][46] ([i915#79]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: NOTRUN -> [DMESG-WARN][47] ([i915#180]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-apl: NOTRUN -> [FAIL][48] ([i915#2641])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2672])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-kbl: NOTRUN -> [FAIL][50] ([i915#2641])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109280]) +5 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-cpu.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-apl: [PASS][52] -> [DMESG-WARN][53] ([i915#180])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl8/igt@kms_hdr@bpc-switch-suspend.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl6/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][54] ([fdo#108145] / [i915#265])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl3/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
- shard-skl: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][57] ([i915#265])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][58] -> [FAIL][59] ([fdo#108145] / [i915#265]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109278]) +13 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@kms_plane_alpha_blend@pipe-d-constant-alpha-min.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +5 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl8/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-skl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@kms_psr@cursor_plane_onoff:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271]) +41 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl3/igt@kms_psr@cursor_plane_onoff.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][65] -> [SKIP][66] ([fdo#109441])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][67] -> [DMESG-WARN][68] ([i915#180] / [i915#295])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: [PASS][69] -> [DMESG-WARN][70] ([i915#180])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533]) +3 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl7/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-a-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#2530])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@nouveau_crc@pipe-a-source-outp-complete.html
* igt@perf@polling-parameterized:
- shard-skl: [PASS][73] -> [FAIL][74] ([i915#1542])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl7/igt@perf@polling-parameterized.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl6/igt@perf@polling-parameterized.html
* igt@prime_nv_pcopy@test3_2:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109291]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb4/igt@prime_nv_pcopy@test3_2.html
* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#2994]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@sysfs_clients@fair-1.html
* igt@sysfs_clients@sema-25:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#2994])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@sysfs_clients@sema-25.html
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][78] ([i915#2369] / [i915#2481] / [i915#3070]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb2/igt@gem_eio@unwedge-stress.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][80] ([i915#2842]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb5/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][82] ([i915#2842]) -> [PASS][83] +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
- shard-glk: [FAIL][84] ([i915#2842]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][86] ([i915#2842]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-tglb2/igt@gem_exec_fair@basic-pace@rcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-tglb1/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-glk: [DMESG-WARN][88] ([i915#118] / [i915#95]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk4/igt@gem_exec_whisper@basic-contexts-priority-all.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk4/igt@gem_exec_whisper@basic-contexts-priority-all.html
* igt@gem_mmap_gtt@big-copy-odd:
- shard-skl: [FAIL][90] ([i915#307]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl4/igt@gem_mmap_gtt@big-copy-odd.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl7/igt@gem_mmap_gtt@big-copy-odd.html
* igt@gem_mmap_gtt@cpuset-medium-copy:
- shard-iclb: [FAIL][92] ([i915#307]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb5/igt@gem_mmap_gtt@cpuset-medium-copy.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb8/igt@gem_mmap_gtt@cpuset-medium-copy.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][94] ([i915#644]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk2/igt@gem_ppgtt@flink-and-close-vma-leak.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk2/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_workarounds@suspend-resume-context:
- shard-iclb: [INCOMPLETE][96] ([i915#1185]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb3/igt@gem_workarounds@suspend-resume-context.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb4/igt@gem_workarounds@suspend-resume-context.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][98] ([i915#454]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb1/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [FAIL][100] -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl7/igt@i915_pm_dc@dc9-dpms.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- shard-iclb: [INCOMPLETE][102] -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb7/igt@i915_pm_rpm@basic-pci-d3-state.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb7/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][104] ([i915#2782]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-snb7/igt@i915_selftest@live@hangcheck.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-snb5/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@linear-16bpp-rotate-0:
- shard-glk: [FAIL][106] ([i915#3331]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk6/igt@kms_big_fb@linear-16bpp-rotate-0.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk3/igt@kms_big_fb@linear-16bpp-rotate-0.html
* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-glk: [FAIL][108] ([i915#52] / [i915#54]) -> [PASS][109] +10 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk7/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk5/igt@kms_draw_crc@draw-method-rgb565-render-untiled.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][110] ([i915#180]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][112] ([i915#2122]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][114] ([i915#1188]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [DMESG-WARN][116] ([i915#180] / [i915#533]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][118] ([i915#180]) -> [PASS][119] +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][120] ([fdo#108145] / [i915#265]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-glk: [FAIL][122] ([i915#899]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-glk9/igt@kms_plane_lowres@pipe-a-tiling-none.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-glk7/igt@kms_plane_lowres@pipe-a-tiling-none.html
* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][124] ([fdo#109441]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb6/igt@kms_psr@psr2_cursor_plane_onoff.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
#### Warnings ####
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][126] ([i915#2849]) -> [FAIL][127] ([i915#2842])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [INCOMPLETE][128] ([i915#155]) -> [DMESG-WARN][129] ([i915#180])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3:
- shard-iclb: [SKIP][130] ([i915#2920]) -> [SKIP][131] ([i915#658])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-3.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#602])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl4/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl1/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl1/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-kbl1/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl4/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-kbl1/igt@runner@aborted.html
- shard-apl: ([FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146]) ([i915#180] / [i915#1814] / [i915#62]) -> ([FAIL][147], [FAIL][148]) ([i915#1814] / [i915#3002])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl8/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl1/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl2/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl8/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-apl8/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl6/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/shard-apl2/igt@runner@aborted.html
- shard-snb: ([FAIL][149], [FAIL][150]) ([i915#2426] / [i915#3002] / [i915#698]) -> [FAIL][151] ([i915#3002] / [i915#698])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-snb7/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9955/shard-snb6/igt@runner@aborted.html
[151]: https://intel-gfx-ci.01
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19910/index.html
[-- Attachment #1.2: Type: text/html, Size: 33965 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
` (7 preceding siblings ...)
2021-04-12 7:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-04-13 10:57 ` Jani Nikula
2021-04-14 9:34 ` Jani Nikula
8 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2021-04-13 10:57 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fix a couple of regressions due to the glk display version 9->10
> change. I *think* all the ones that slipped through involved
> either DISPLAY_VER==9 or DISPLAY_VER<10 checks. These three
> regressions are the ones I found through a quick scan, but someone
> should probably go through the whole tree with a fine toothcomb
> in case we missed more cases.
>
> Also tossed in a couple of cleanups.
Ville, please hold on with merging this until we figure out how to merge
[1]. I don't want to create extra conflicts when they can be avoided.
BR,
Jani.
[1] http://lore.kernel.org/r/20210413051002.92589-1-lucas.demarchi@intel.com
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
>
> Ville Syrjälä (5):
> drm/i915: Restore lost glk FBC 16bpp w/a
> drm/i915: Restore lost glk ccs w/a
> drm/i915: Disable LTTPR detection on GLK once again
> drm/i915: Don't use {skl,cnl}_hpd_pin() for bxt/glk
> drm/i915: Remove a few redundant glk checks
>
> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
> drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +-
> 5 files changed, 8 insertions(+), 7 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a
2021-04-12 5:46 ` [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a Ville Syrjala
@ 2021-04-14 9:14 ` Jani Nikula
2021-04-14 9:17 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:14 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We lost the FBC 16bpp 512byte stride requirement on glk when
> we switched from display version 9 to 10. Restore the w/a to
> avoid enabling FBC with a bad stride and thus display garbage.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
I think this should be:
Fixes: 005e95377249 ("drm/i915/display: Eliminate most usage of INTEL_GEN()")
Right?
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 04d9c7d22b04..dcc0f73ea225 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -598,7 +598,7 @@ static bool stride_is_valid(struct drm_i915_private *dev_priv,
> return false;
>
> /* Display WA #1105: skl,bxt,kbl,cfl,glk */
> - if (IS_DISPLAY_VER(dev_priv, 9) &&
> + if ((IS_DISPLAY_VER(dev_priv, 9) || IS_GEMINILAKE(dev_priv)) &&
> modifier == DRM_FORMAT_MOD_LINEAR && stride & 511)
> return false;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a
2021-04-14 9:14 ` Jani Nikula
@ 2021-04-14 9:17 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:17 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Wed, 14 Apr 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> We lost the FBC 16bpp 512byte stride requirement on glk when
>> we switched from display version 9 to 10. Restore the w/a to
>> avoid enabling FBC with a bad stride and thus display garbage.
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
>
> I think this should be:
>
> Fixes: 005e95377249 ("drm/i915/display: Eliminate most usage of INTEL_GEN()")
Strike that, the regression is in the one you mention, though arguably
it was the combination of the two that broke this, really.
>
> Right?
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
>> index 04d9c7d22b04..dcc0f73ea225 100644
>> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
>> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
>> @@ -598,7 +598,7 @@ static bool stride_is_valid(struct drm_i915_private *dev_priv,
>> return false;
>>
>> /* Display WA #1105: skl,bxt,kbl,cfl,glk */
>> - if (IS_DISPLAY_VER(dev_priv, 9) &&
>> + if ((IS_DISPLAY_VER(dev_priv, 9) || IS_GEMINILAKE(dev_priv)) &&
>> modifier == DRM_FORMAT_MOD_LINEAR && stride & 511)
>> return false;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a
2021-04-12 5:46 ` [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a Ville Syrjala
@ 2021-04-14 9:18 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:18 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We lost a CCS related w/a on glk when the display version
> became 10 instead of 9. Restore the correct check.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 411b46c012f8..7eac893b4f96 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1406,7 +1406,8 @@ intel_fb_stride_alignment(const struct drm_framebuffer *fb, int color_plane)
> * require the entire fb to accommodate that to avoid
> * potential runtime errors at plane configuration time.
> */
> - if (IS_DISPLAY_VER(dev_priv, 9) && color_plane == 0 && fb->width > 3840)
> + if ((IS_DISPLAY_VER(dev_priv, 9) || IS_GEMINILAKE(dev_priv)) &&
> + color_plane == 0 && fb->width > 3840)
> tile_width *= 4;
> /*
> * The main surface pitch must be padded to a multiple of four
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again
2021-04-12 5:46 ` [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again Ville Syrjala
@ 2021-04-14 9:19 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:19 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The glk display version change is causing us to again attempt
> LTTPR detection on glk. We must not do tha since glk doesn't
> have a long enough AUX timeout. Restore the correct logic to
> skip the detection.
>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Fixes: 2b5a4562edd0 ("drm/i915/display: Simplify GLK display version tests")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index 5e9c3c74310c..597634e4f35f 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -96,7 +96,7 @@ static bool intel_dp_read_lttpr_common_caps(struct intel_dp *intel_dp)
> * Detecting LTTPRs must be avoided on platforms with an AUX timeout
> * period < 3.2ms. (see DP Standard v2.0, 2.11.2, 3.6.6.1).
> */
> - if (DISPLAY_VER(i915) < 10)
> + if (DISPLAY_VER(i915) < 10 || IS_GEMINILAKE(i915))
> return false;
>
> if (drm_dp_read_lttpr_common_caps(&intel_dp->aux,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk
2021-04-12 5:46 ` [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk Ville Syrjala
@ 2021-04-14 9:25 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:25 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Just let bxt/glk fall back to intel_hpd_pin_default() instead
> of using skl_hpd_pin() or cnl_hpd_pin(). Doesn't really matter
> since both functions will end up returning the correct hpd pin
> anyway, but I find it a bit less confusing when bxt/glk are
> fully separated from the logic for the other platforms.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
The whole hpd pin code could use a relocation from intel_ddi.c and some
overhaul.
But first things first,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index deef24da00b5..e208ded9a688 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -4612,9 +4612,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> encoder->hpd_pin = ehl_hpd_pin(dev_priv, port);
> else if (IS_DISPLAY_VER(dev_priv, 11))
> encoder->hpd_pin = icl_hpd_pin(dev_priv, port);
> - else if (IS_DISPLAY_VER(dev_priv, 10))
> + else if (IS_CANNONLAKE(dev_priv))
> encoder->hpd_pin = cnl_hpd_pin(dev_priv, port);
> - else if (IS_DISPLAY_VER(dev_priv, 9))
> + else if (IS_DISPLAY_VER(dev_priv, 9) && !IS_BROXTON(dev_priv))
> encoder->hpd_pin = skl_hpd_pin(dev_priv, port);
> else
> encoder->hpd_pin = intel_hpd_pin_default(dev_priv, port);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks
2021-04-12 5:46 ` [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks Ville Syrjala
@ 2021-04-14 9:26 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:26 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Now that glk display version is 10 we can drop a few more glk checks.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index e208ded9a688..79ece9e45d66 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -176,7 +176,7 @@ static void intel_wait_ddi_buf_active(struct drm_i915_private *dev_priv,
> enum port port)
> {
> /* Wait > 518 usecs for DDI_BUF_CTL to be non idle */
> - if (DISPLAY_VER(dev_priv) < 10 && !IS_GEMINILAKE(dev_priv)) {
> + if (DISPLAY_VER(dev_priv) < 10) {
> usleep_range(518, 1000);
> return;
> }
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 098636c811a8..5926ed1094a4 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -853,7 +853,7 @@ static u32 skl_plane_ctl(const struct intel_crtc_state *crtc_state,
>
> plane_ctl = PLANE_CTL_ENABLE;
>
> - if (DISPLAY_VER(dev_priv) < 10 && !IS_GEMINILAKE(dev_priv)) {
> + if (DISPLAY_VER(dev_priv) < 10) {
> plane_ctl |= skl_plane_ctl_alpha(plane_state);
> plane_ctl |= PLANE_CTL_PLANE_GAMMA_DISABLE;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions
2021-04-13 10:57 ` [Intel-gfx] [PATCH 0/5] " Jani Nikula
@ 2021-04-14 9:34 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2021-04-14 9:34 UTC (permalink / raw
To: Ville Syrjala, intel-gfx
On Tue, 13 Apr 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 12 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Fix a couple of regressions due to the glk display version 9->10
>> change. I *think* all the ones that slipped through involved
>> either DISPLAY_VER==9 or DISPLAY_VER<10 checks. These three
>> regressions are the ones I found through a quick scan, but someone
>> should probably go through the whole tree with a fine toothcomb
>> in case we missed more cases.
>>
>> Also tossed in a couple of cleanups.
>
> Ville, please hold on with merging this until we figure out how to merge
> [1]. I don't want to create extra conflicts when they can be avoided.
Pushed the lot to topic/intel-gen-to-ver, thanks for the patches.
BR,
Jani.
>
> BR,
> Jani.
>
>
> [1] http://lore.kernel.org/r/20210413051002.92589-1-lucas.demarchi@intel.com
>
>
>>
>> Cc: Matt Roper <matthew.d.roper@intel.com>
>>
>> Ville Syrjälä (5):
>> drm/i915: Restore lost glk FBC 16bpp w/a
>> drm/i915: Restore lost glk ccs w/a
>> drm/i915: Disable LTTPR detection on GLK once again
>> drm/i915: Don't use {skl,cnl}_hpd_pin() for bxt/glk
>> drm/i915: Remove a few redundant glk checks
>>
>> drivers/gpu/drm/i915/display/intel_ddi.c | 6 +++---
>> drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
>> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
>> drivers/gpu/drm/i915/display/intel_fbc.c | 2 +-
>> drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 +-
>> 5 files changed, 8 insertions(+), 7 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-04-14 9:35 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-12 5:46 [Intel-gfx] [PATCH 0/5] drm/i915: Fix glk display version regressions Ville Syrjala
2021-04-12 5:46 ` [Intel-gfx] [PATCH 1/5] drm/i915: Restore lost glk FBC 16bpp w/a Ville Syrjala
2021-04-14 9:14 ` Jani Nikula
2021-04-14 9:17 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 2/5] drm/i915: Restore lost glk ccs w/a Ville Syrjala
2021-04-14 9:18 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 3/5] drm/i915: Disable LTTPR detection on GLK once again Ville Syrjala
2021-04-14 9:19 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 4/5] drm/i915: Don't use {skl, cnl}_hpd_pin() for bxt/glk Ville Syrjala
2021-04-14 9:25 ` Jani Nikula
2021-04-12 5:46 ` [Intel-gfx] [PATCH 5/5] drm/i915: Remove a few redundant glk checks Ville Syrjala
2021-04-14 9:26 ` Jani Nikula
2021-04-12 6:18 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: Fix glk display version regressions Patchwork
2021-04-12 6:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-12 7:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-13 10:57 ` [Intel-gfx] [PATCH 0/5] " Jani Nikula
2021-04-14 9:34 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.