From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5D0C48BE8 for ; Tue, 15 Jun 2021 23:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6309561350 for ; Tue, 15 Jun 2021 23:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231510AbhFOXm0 (ORCPT ); Tue, 15 Jun 2021 19:42:26 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:49954 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S230039AbhFOXmV (ORCPT ); Tue, 15 Jun 2021 19:42:21 -0400 X-UUID: fffb4e5efa684f19b12ece330d112351-20210616 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=1N+JC1snW7EnO8epve2A7QzbqIbp6/TazBXQRTkssHQ=; b=n82vwoj5rhMqtRsiJZh8+qFglbmTBIRohSuAk/q64M/NVX/l3TiFuZHeDasTD31+GL8FWitoMYCAJ/gnuERTASrK3skKFQNczhi7D0oKPxKLUav/neNe8wkY+CrLtbo/nD8UW8Ob2tJLpU+01euzEs3fDzZw3Pu66i6kVhiaeBo=; X-UUID: fffb4e5efa684f19b12ece330d112351-20210616 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1541065036; Wed, 16 Jun 2021 07:40:13 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Jun 2021 07:40:12 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 16 Jun 2021 07:40:12 +0800 Message-ID: <1623800412.8512.16.camel@mtkswgap22> Subject: Re: [next] [arm64] kernel BUG at arch/arm64/mm/physaddr.c From: Miles Chen To: Stephen Rothwell CC: Mike Rapoport , Qian Cai , Andrew Morton , Mark Rutland , Naresh Kamboju , Linux-Next Mailing List , linux-mm , Linux ARM , open list , Will Deacon , , , Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Christophe Leroy , Alistair Popple Date: Wed, 16 Jun 2021 07:40:12 +0800 In-Reply-To: <20210616093422.31270f1e@canb.auug.org.au> References: <20210615124745.GA47121@C02TD0UTHF1T.local> <20210615131902.GB47121@C02TD0UTHF1T.local> <076665b9-9fb1-71da-5f7d-4d2c7f892103@quicinc.com> <20210616093422.31270f1e@canb.auug.org.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gV2VkLCAyMDIxLTA2LTE2IGF0IDA5OjM0ICsxMDAwLCBTdGVwaGVuIFJvdGh3ZWxsIHdyb3Rl Og0KPiBIaSBhbGwsDQo+IA0KPiBPbiBUdWUsIDE1IEp1biAyMDIxIDIyOjIxOjMyICswMzAwIE1p a2UgUmFwb3BvcnQgPHJwcHRAbGludXguaWJtLmNvbT4gd3JvdGU6DQo+ID4NCj4gPiBPbiBUdWUs IEp1biAxNSwgMjAyMSBhdCAxMDo1MDozMUFNIC0wNDAwLCBRaWFuIENhaSB3cm90ZToNCj4gPiA+ IA0KPiA+ID4gT24gNi8xNS8yMDIxIDk6MTkgQU0sIE1hcmsgUnV0bGFuZCB3cm90ZTogIA0KPiA+ ID4gPiBMb29raW5nIHNvbWUgbW9yZSwgaXQgbG9va3MgbGlrZSB0aGF0J3MgY29ycmVjdCBpbiBp c29sYXRpb24sIGJ1dCBpdA0KPiA+ID4gPiBjbGFzaGVzIHdpdGggY29tbWl0Og0KPiA+ID4gPiAN Cj4gPiA+ID4gICA1ODMxZWVkYWQyYWM2ZjM4ICgibW06IHJlcGxhY2UgQ09ORklHX05FRURfTVVM VElQTEVfTk9ERVMgd2l0aCBDT05GSUdfTlVNQSIpICANCj4gPiA+IA0KPiA+ID4gSnVzdCBhIGRh dGEgcG9pbnQuIFJldmVydGluZyB0aGUgY29tbWl0IGFsb25lIGZpeGVkIHRoZSBzYW1lIGNyYXNo IGZvciBtZS4gIA0KPiA+IA0KPiA+IFllYWgsIHRoYXQgY29tbWl0IGRpZG4ndCB0YWtlIGludG8g dGhlIGFjY291bnQgdGhlIGNoYW5nZSBpbg0KPiA+IHBnZGF0X3RvX3BoeXMoKS4NCj4gPiANCj4g PiBUaGUgcGF0Y2ggYmVsb3cgc2hvdWxkIGZpeCBpdC4gSW4gdGhlIGxvbmcgcnVuIEkgdGhpbmsg d2Ugc2hvdWxkIGdldCByaWQgb2YNCj4gPiBjb250aWdfcGFnZV9kYXRhIGFuZCBhbGxvY2F0ZSBO T0RFX0RBVEEoMCkgZm9yICFOVU1BIGNhc2UgYXMgd2VsbC4NCj4gPiANCj4gPiBBbmRyZXcsIGNh biB5b3UgcGxlYXNlIGFkZCB0aGlzIGFzIGEgZml4dXAgdG8gIm1tOiByZXBsYWNlDQo+ID4gQ09O RklHX05FRURfTVVMVElQTEVfTk9ERVMgd2l0aCBDT05GSUdfTlVNQSI/DQo+ID4gDQo+ID4gDQo+ ID4gZGlmZiAtLWdpdCBhL21tL3NwYXJzZS5jIGIvbW0vc3BhcnNlLmMNCj4gPiBpbmRleCBhMGU5 Y2RiNWJjMzguLjYzMjZjZGYzNmM0ZiAxMDA2NDQNCj4gPiAtLS0gYS9tbS9zcGFyc2UuYw0KPiA+ ICsrKyBiL21tL3NwYXJzZS5jDQo+ID4gQEAgLTM0Nyw3ICszNDcsNyBAQCBzaXplX3QgbWVtX3Nl Y3Rpb25fdXNhZ2Vfc2l6ZSh2b2lkKQ0KPiA+ICANCj4gPiAgc3RhdGljIGlubGluZSBwaHlzX2Fk ZHJfdCBwZ2RhdF90b19waHlzKHN0cnVjdCBwZ2xpc3RfZGF0YSAqcGdkYXQpDQo+ID4gIHsNCj4g PiAtI2lmbmRlZiBDT05GSUdfTkVFRF9NVUxUSVBMRV9OT0RFUw0KPiA+ICsjaWZuZGVmIENPTkZJ R19OVU1BDQo+ID4gIAlyZXR1cm4gX19wYV9zeW1ib2wocGdkYXQpOw0KPiA+ICAjZWxzZQ0KPiA+ ICAJcmV0dXJuIF9fcGEocGdkYXQpOw0KPiANCj4gQWRkZWQgdG8gbGludXgtbmV4dCB0b2RheS4N Cj4gDQoNClNvcnJ5IGZvciBteSBsYXRlIHJlc3BvbnNlLg0KdGhhbmtzIGZvciBkb2luZyB0aGlz LiANCg0KTWlsZXMNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E45C48BDF for ; Tue, 15 Jun 2021 23:58:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B56F061356 for ; Tue, 15 Jun 2021 23:58:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B56F061356 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=23dR7AJNSIH7Lo2Y+09bRXqEbb7imUChZTW/5cShkr4=; b=urlAi/XgmRaMns FyO1DRxMpPVUKLWCSqOpbPmKMI3b3UWw/deEeLLGaw28cX3B8nilZszVc+1juAHSYj43isurRxB1A bgksi29w6xICh4RuL5VszBR29iDhyQLU+KSYMRd+l9BHVYgOgAvwGNIAJTMgd3779fsZgvk9fmwEN r62O7sXBYYNaCrghf5VEf30wUeUQxcL7vrfwMveR6zxqxzLVLvSzMp4OeptjYVi8xbZGLYhGBROKU P5/dCsYGkf4z13mWHb/cqvjBw7jxd6ZiJQ0SBg3RDRXHTY+lIkaxG8SzcTXbVCyrKOx6p6JUZqvVV fh4EaWljjY2rIX7M74sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltIu9-004131-TL; Tue, 15 Jun 2021 23:55:38 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltIp4-003yme-3W for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 23:50:23 +0000 X-UUID: 162cb91392f948419d6678cfc32f0ad5-20210615 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=1N+JC1snW7EnO8epve2A7QzbqIbp6/TazBXQRTkssHQ=; b=rV1vNoRzBZvK31Uj2P5mPrRzsq7BAg8oZ5UeOXtArbz+OSpC0BWA+nqaGg1x5mmdjqUS3s0fHLjTyGlir7bAEbdFAbzAseRPHfQBdK0XpzkJuGFXlQ3xZZB0fbQgOU56qipoBgUSYN32n01bfM/EGRvVrwvUJRWM4VUJEnaj6rg=; X-UUID: 162cb91392f948419d6678cfc32f0ad5-20210615 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1664057473; Tue, 15 Jun 2021 16:50:16 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Jun 2021 16:40:14 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 16 Jun 2021 07:40:12 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 16 Jun 2021 07:40:12 +0800 Message-ID: <1623800412.8512.16.camel@mtkswgap22> Subject: Re: [next] [arm64] kernel BUG at arch/arm64/mm/physaddr.c From: Miles Chen To: Stephen Rothwell CC: Mike Rapoport , Qian Cai , Andrew Morton , Mark Rutland , Naresh Kamboju , Linux-Next Mailing List , linux-mm , Linux ARM , "open list" , Will Deacon , , , Arnd Bergmann , Ard Biesheuvel , Catalin Marinas , Christophe Leroy , Alistair Popple Date: Wed, 16 Jun 2021 07:40:12 +0800 In-Reply-To: <20210616093422.31270f1e@canb.auug.org.au> References: <20210615124745.GA47121@C02TD0UTHF1T.local> <20210615131902.GB47121@C02TD0UTHF1T.local> <076665b9-9fb1-71da-5f7d-4d2c7f892103@quicinc.com> <20210616093422.31270f1e@canb.auug.org.au> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_165022_505996_9D4D0912 X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-06-16 at 09:34 +1000, Stephen Rothwell wrote: > Hi all, > > On Tue, 15 Jun 2021 22:21:32 +0300 Mike Rapoport wrote: > > > > On Tue, Jun 15, 2021 at 10:50:31AM -0400, Qian Cai wrote: > > > > > > On 6/15/2021 9:19 AM, Mark Rutland wrote: > > > > Looking some more, it looks like that's correct in isolation, but it > > > > clashes with commit: > > > > > > > > 5831eedad2ac6f38 ("mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA") > > > > > > Just a data point. Reverting the commit alone fixed the same crash for me. > > > > Yeah, that commit didn't take into the account the change in > > pgdat_to_phys(). > > > > The patch below should fix it. In the long run I think we should get rid of > > contig_page_data and allocate NODE_DATA(0) for !NUMA case as well. > > > > Andrew, can you please add this as a fixup to "mm: replace > > CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA"? > > > > > > diff --git a/mm/sparse.c b/mm/sparse.c > > index a0e9cdb5bc38..6326cdf36c4f 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -347,7 +347,7 @@ size_t mem_section_usage_size(void) > > > > static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > > { > > -#ifndef CONFIG_NEED_MULTIPLE_NODES > > +#ifndef CONFIG_NUMA > > return __pa_symbol(pgdat); > > #else > > return __pa(pgdat); > > Added to linux-next today. > Sorry for my late response. thanks for doing this. Miles _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel