* [PATCH] ASoC: dwc: Get IRQ optionally
@ 2021-08-25 15:42 Robin Murphy
2021-08-26 12:51 ` Mark Brown
2021-08-27 8:08 ` Andy Shevchenko
0 siblings, 2 replies; 5+ messages in thread
From: Robin Murphy @ 2021-08-25 15:42 UTC (permalink / raw
To: lgirdwood, broonie; +Cc: alsa-devel, linux-kernel
The IRQ is explicitly optional, so use platform_get_irq_optional() and
avoid platform_get_irq() logging a spurious error when trying to use the
thing in DMA mode.
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
---
sound/soc/dwc/dwc-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 8ebf76e04702..33ce257ae198 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -642,7 +642,7 @@ static int dw_i2s_probe(struct platform_device *pdev)
dev->dev = &pdev->dev;
- irq = platform_get_irq(pdev, 0);
+ irq = platform_get_irq_optional(pdev, 0);
if (irq >= 0) {
ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
pdev->name, dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: dwc: Get IRQ optionally
2021-08-25 15:42 [PATCH] ASoC: dwc: Get IRQ optionally Robin Murphy
@ 2021-08-26 12:51 ` Mark Brown
2021-08-27 8:08 ` Andy Shevchenko
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-08-26 12:51 UTC (permalink / raw
To: Robin Murphy, lgirdwood; +Cc: Mark Brown, alsa-devel, linux-kernel
On Wed, 25 Aug 2021 16:42:03 +0100, Robin Murphy wrote:
> The IRQ is explicitly optional, so use platform_get_irq_optional() and
> avoid platform_get_irq() logging a spurious error when trying to use the
> thing in DMA mode.
>
>
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dwc: Get IRQ optionally
commit: 2fd276c3ee4bd42eb034f8954964a5ae74187c6b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: dwc: Get IRQ optionally
@ 2021-08-26 12:51 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2021-08-26 12:51 UTC (permalink / raw
To: Robin Murphy, lgirdwood; +Cc: alsa-devel, Mark Brown, linux-kernel
On Wed, 25 Aug 2021 16:42:03 +0100, Robin Murphy wrote:
> The IRQ is explicitly optional, so use platform_get_irq_optional() and
> avoid platform_get_irq() logging a spurious error when trying to use the
> thing in DMA mode.
>
>
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: dwc: Get IRQ optionally
commit: 2fd276c3ee4bd42eb034f8954964a5ae74187c6b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: dwc: Get IRQ optionally
2021-08-25 15:42 [PATCH] ASoC: dwc: Get IRQ optionally Robin Murphy
@ 2021-08-27 8:08 ` Andy Shevchenko
2021-08-27 8:08 ` Andy Shevchenko
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2021-08-27 8:08 UTC (permalink / raw
To: Robin Murphy
Cc: Liam Girdwood, Mark Brown, ALSA Development Mailing List,
Linux Kernel Mailing List
On Wed, Aug 25, 2021 at 7:04 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> The IRQ is explicitly optional, so use platform_get_irq_optional() and
> avoid platform_get_irq() logging a spurious error when trying to use the
> thing in DMA mode.
...
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq >= 0) {
It has to be changed to if (irq > 0).
But since it's already applied, I think it will be another patch.
> ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
> pdev->name, dev);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: dwc: Get IRQ optionally
@ 2021-08-27 8:08 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2021-08-27 8:08 UTC (permalink / raw
To: Robin Murphy
Cc: ALSA Development Mailing List, Mark Brown, Liam Girdwood,
Linux Kernel Mailing List
On Wed, Aug 25, 2021 at 7:04 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> The IRQ is explicitly optional, so use platform_get_irq_optional() and
> avoid platform_get_irq() logging a spurious error when trying to use the
> thing in DMA mode.
...
> - irq = platform_get_irq(pdev, 0);
> + irq = platform_get_irq_optional(pdev, 0);
> if (irq >= 0) {
It has to be changed to if (irq > 0).
But since it's already applied, I think it will be another patch.
> ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
> pdev->name, dev);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-27 8:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-25 15:42 [PATCH] ASoC: dwc: Get IRQ optionally Robin Murphy
2021-08-26 12:51 ` Mark Brown
2021-08-26 12:51 ` Mark Brown
2021-08-27 8:08 ` Andy Shevchenko
2021-08-27 8:08 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.