From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 08/10] hash: remove duplicated code
Date: Tue, 16 Jun 2015 11:33:25 +0200
Message-ID: <1675380.IejOcZZ0JH@xps13>
References: <1432289771-12799-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1433949927-14767-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <1433949927-14767-9-git-send-email-pablo.de.lara.guarch@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 8B6B4C318
 for <dev@dpdk.org>; Tue, 16 Jun 2015 11:34:23 +0200 (CEST)
Received: by wgv5 with SMTP id 5so7862850wgv.1
 for <dev@dpdk.org>; Tue, 16 Jun 2015 02:34:23 -0700 (PDT)
In-Reply-To: <1433949927-14767-9-git-send-email-pablo.de.lara.guarch@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The following patch is needed and will be squashed to fix some doxygen issues:

--- a/lib/librte_hash/rte_jhash.h
+++ b/lib/librte_hash/rte_jhash.h
@@ -306,13 +306,13 @@ rte_jhash2(const uint32_t *k, uint32_t length, uint32_t initval)
  * with seeds. If you pass in (*pb)=0, the output (*pc) will be
  * the same as the return value from rte_jhash.
  *
- * @param k
+ * @param key
  *   Key to calculate hash of.
  * @param length
  *   Length of key in bytes.
  * @param pc
  *   IN: seed OUT: primary hash value.
- * @param pc
+ * @param pb
  *   IN: second seed OUT: secondary hash value.
  */
 static inline void
@@ -464,7 +464,7 @@ rte_jhash_2hashes(const void *key, uint32_t length, uint32_t *pc, uint32_t *pb)
  *   Length of key in units of 4 bytes.
  * @param pc
  *   IN: seed OUT: primary hash value.
- * @param pc
+ * @param pb
  *   IN: second seed OUT: secondary hash value.
  */
 static inline void