* [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro
@ 2013-11-26 1:45 Laurent Pinchart
2013-11-28 7:51 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-11-26 1:45 UTC (permalink / raw
To: linux-sh
Commit 7cbb0e55e27e ("sh-pfc: Don't duplicate argument to PINMUX_GPIO
macro") erronesouly modified the PINMUX_GPIO macro in a way that
resulted in all pins being named "name". Fix the macro to name the pins
correctly.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
index 8a494e5..463ef21 100644
--- a/drivers/pinctrl/sh-pfc/sh_pfc.h
+++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
@@ -254,7 +254,7 @@ struct sh_pfc_soc_info {
#define PINMUX_GPIO(_pin) \
[GPIO_##_pin] = { \
.pin = (u16)-1, \
- .name = __stringify(name), \
+ .name = __stringify(GPIO_##_pin), \
.enum_id = _pin##_DATA, \
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro
2013-11-26 1:45 [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro Laurent Pinchart
@ 2013-11-28 7:51 ` Simon Horman
2013-12-03 9:34 ` Linus Walleij
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-11-28 7:51 UTC (permalink / raw
To: linux-sh
On Tue, Nov 26, 2013 at 02:45:34AM +0100, Laurent Pinchart wrote:
> Commit 7cbb0e55e27e ("sh-pfc: Don't duplicate argument to PINMUX_GPIO
> macro") erronesouly modified the PINMUX_GPIO macro in a way that
> resulted in all pins being named "name". Fix the macro to name the pins
> correctly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 8a494e5..463ef21 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -254,7 +254,7 @@ struct sh_pfc_soc_info {
> #define PINMUX_GPIO(_pin) \
> [GPIO_##_pin] = { \
> .pin = (u16)-1, \
> - .name = __stringify(name), \
> + .name = __stringify(GPIO_##_pin), \
> .enum_id = _pin##_DATA, \
> }
>
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro
2013-11-26 1:45 [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro Laurent Pinchart
2013-11-28 7:51 ` Simon Horman
@ 2013-12-03 9:34 ` Linus Walleij
2013-12-04 1:06 ` Laurent Pinchart
2013-12-10 12:13 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2013-12-03 9:34 UTC (permalink / raw
To: linux-sh
On Tue, Nov 26, 2013 at 2:45 AM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Commit 7cbb0e55e27e ("sh-pfc: Don't duplicate argument to PINMUX_GPIO
> macro") erronesouly modified the PINMUX_GPIO macro in a way that
> resulted in all pins being named "name". Fix the macro to name the pins
> correctly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Or is this a regression I should apply for fixes?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro
2013-11-26 1:45 [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro Laurent Pinchart
2013-11-28 7:51 ` Simon Horman
2013-12-03 9:34 ` Linus Walleij
@ 2013-12-04 1:06 ` Laurent Pinchart
2013-12-10 12:13 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-12-04 1:06 UTC (permalink / raw
To: linux-sh
Hi Linus,
On Tuesday 03 December 2013 10:34:36 Linus Walleij wrote:
> On Tue, Nov 26, 2013 at 2:45 AM, Laurent Pinchart wrote:
> > Commit 7cbb0e55e27e ("sh-pfc: Don't duplicate argument to PINMUX_GPIO
> > macro") erronesouly modified the PINMUX_GPIO macro in a way that
> > resulted in all pins being named "name". Fix the macro to name the pins
> > correctly.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Or is this a regression I should apply for fixes?
The problem has been introduced in v3.12. It could be sent as a bug fix to
v3.13 and CC'ed to stable. If you do so, please let me know and I'll remove
the patch from my pull request.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro
2013-11-26 1:45 [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro Laurent Pinchart
` (2 preceding siblings ...)
2013-12-04 1:06 ` Laurent Pinchart
@ 2013-12-10 12:13 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2013-12-10 12:13 UTC (permalink / raw
To: linux-sh
On Wed, Dec 4, 2013 at 2:06 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Tuesday 03 December 2013 10:34:36 Linus Walleij wrote:
>> On Tue, Nov 26, 2013 at 2:45 AM, Laurent Pinchart wrote:
>> > Commit 7cbb0e55e27e ("sh-pfc: Don't duplicate argument to PINMUX_GPIO
>> > macro") erronesouly modified the PINMUX_GPIO macro in a way that
>> > resulted in all pins being named "name". Fix the macro to name the pins
>> > correctly.
>> >
>> > Signed-off-by: Laurent Pinchart
>> > <laurent.pinchart+renesas@ideasonboard.com>
>>
>> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Or is this a regression I should apply for fixes?
>
> The problem has been introduced in v3.12. It could be sent as a bug fix to
> v3.13 and CC'ed to stable. If you do so, please let me know and I'll remove
> the patch from my pull request.
OK I've applied this for fixes and added CC to stable.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-10 12:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-26 1:45 [PATCH 2/2] sh-pfc: Fix PINMUX_GPIO macro Laurent Pinchart
2013-11-28 7:51 ` Simon Horman
2013-12-03 9:34 ` Linus Walleij
2013-12-04 1:06 ` Laurent Pinchart
2013-12-10 12:13 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.