All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing
@ 2019-07-16 23:35 Heinrich Schuchardt
  2019-07-17  2:29 ` Bin Meng
  2019-07-17 16:02 ` Stephen Warren
  0 siblings, 2 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2019-07-16 23:35 UTC (permalink / raw
  To: u-boot

When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
"Parameter 'id' is missing".

A command launching qemu-riscv64_defconfig successfully on Debian is:

qemu-system-riscv64 \
-machine virt \
-kernel u-boot \
-m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
-device virtio-net-device,netdev=net0

Add the missing id.

Fixes: 990b317fdcc4 ("travis-ci: add qemu-riscv64")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 bin/travis-ci/conf.qemu-riscv64_na | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/travis-ci/conf.qemu-riscv64_na b/bin/travis-ci/conf.qemu-riscv64_na
index b375e2b..65b2096 100644
--- a/bin/travis-ci/conf.qemu-riscv64_na
+++ b/bin/travis-ci/conf.qemu-riscv64_na
@@ -5,7 +5,7 @@
 console_impl=qemu
 qemu_machine="virt"
 qemu_binary="qemu-system-riscv64"
-qemu_extra_args="-m 1G -nographic -netdev user,tftp=${UBOOT_TRAVIS_BUILD_DIR} -device virtio-net-device,netdev=user"
+qemu_extra_args="-m 1G -nographic -netdev user,id=net0,tftp=${UBOOT_TRAVIS_BUILD_DIR} -device virtio-net-device,netdev=net0"
 qemu_kernel_args="-kernel ${U_BOOT_BUILD_DIR}/u-boot"
 reset_impl=none
 flash_impl=none
--
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing
  2019-07-16 23:35 [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing Heinrich Schuchardt
@ 2019-07-17  2:29 ` Bin Meng
  2019-07-17 16:02 ` Stephen Warren
  1 sibling, 0 replies; 4+ messages in thread
From: Bin Meng @ 2019-07-17  2:29 UTC (permalink / raw
  To: u-boot

On Wed, Jul 17, 2019 at 7:36 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
> "Parameter 'id' is missing".
>
> A command launching qemu-riscv64_defconfig successfully on Debian is:
>
> qemu-system-riscv64 \
> -machine virt \
> -kernel u-boot \
> -m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
> -device virtio-net-device,netdev=net0
>
> Add the missing id.
>
> Fixes: 990b317fdcc4 ("travis-ci: add qemu-riscv64")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  bin/travis-ci/conf.qemu-riscv64_na | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing
  2019-07-16 23:35 [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing Heinrich Schuchardt
  2019-07-17  2:29 ` Bin Meng
@ 2019-07-17 16:02 ` Stephen Warren
  2019-07-17 17:52   ` Heinrich Schuchardt
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Warren @ 2019-07-17 16:02 UTC (permalink / raw
  To: u-boot

On 7/16/19 5:35 PM, Heinrich Schuchardt wrote:
> When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
> "Parameter 'id' is missing".
> 
> A command launching qemu-riscv64_defconfig successfully on Debian is:
> 
> qemu-system-riscv64 \
> -machine virt \
> -kernel u-boot \
> -m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
> -device virtio-net-device,netdev=net0
> 
> Add the missing id.

Thanks. I've applied this.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing
  2019-07-17 16:02 ` Stephen Warren
@ 2019-07-17 17:52   ` Heinrich Schuchardt
  0 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2019-07-17 17:52 UTC (permalink / raw
  To: u-boot

On 7/17/19 6:02 PM, Stephen Warren wrote:
> On 7/16/19 5:35 PM, Heinrich Schuchardt wrote:
>> When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
>> "Parameter 'id' is missing".
>>
>> A command launching qemu-riscv64_defconfig successfully on Debian is:
>>
>> qemu-system-riscv64 \
>> -machine virt \
>> -kernel u-boot \
>> -m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
>> -device virtio-net-device,netdev=net0
>>
>> Add the missing id.
>
> Thanks. I've applied this.
>
Thanks

I was able to run a job successfully:
https://travis-ci.org/xypron2/u-boot/builds/560076658

So I will now proceed to update .travis.yml.

Best regards

Heinrich Schuchardt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-17 17:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-16 23:35 [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing Heinrich Schuchardt
2019-07-17  2:29 ` Bin Meng
2019-07-17 16:02 ` Stephen Warren
2019-07-17 17:52   ` Heinrich Schuchardt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.