From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbbGNCp4 (ORCPT ); Mon, 13 Jul 2015 22:45:56 -0400 Received: from linuxhacker.ru ([217.76.32.60]:60998 "EHLO fiona.linuxhacker.ru" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753463AbbGNCpy (ORCPT ); Mon, 13 Jul 2015 22:45:54 -0400 Subject: Re: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Oleg Drokin In-Reply-To: <20150714024313.GA24722@kroah.com> Date: Mon, 13 Jul 2015 22:45:36 -0400 Cc: Dan Carpenter , devel@driverdev.osuosl.org, Andreas Dilger , Linux Kernel Mailing List Content-Transfer-Encoding: 7bit Message-Id: <188E1E93-DB4A-48FD-8A4B-E4887332CCE1@linuxhacker.ru> References: <1436201338-14263-1-git-send-email-green@linuxhacker.ru> <1436201338-14263-19-git-send-email-green@linuxhacker.ru> <20150708084202.GN4341@mwanda> <20150714024313.GA24722@kroah.com> To: Greg Kroah-Hartman X-Mailer: Apple Mail (2.1283) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 13, 2015, at 10:43 PM, Greg Kroah-Hartman wrote: > On Wed, Jul 08, 2015 at 11:45:59AM +0300, Dan Carpenter wrote: >> On Mon, Jul 06, 2015 at 12:48:56PM -0400, green@linuxhacker.ru wrote: >>> +static int libcfs_param_debug_mb_set(const char *val, >>> + const struct kernel_param *kp) >>> +{ >>> + int rc; >>> + unsigned num; >>> + >>> + rc = kstrtouint(val, 0, &num); >>> + if (rc == -EINVAL) >>> + return -EINVAL; >> >> Presumably, this is root only so using num uninitialized is not an >> information leak. > > But it's not good, this should be a check for rc < 0 to make sure. > > Oleg, can you send a follow-on patch to fix this up? Sure. Do you want it now or should I wait till you merge my previous bunch? Bye, Oleg