From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Wed, 3 Mar 1999 16:19:26 +1100
Message-Id: <199903030519.QAA01628@tango.anu.edu.au>
From: Paul Mackerras <paulus@cs.anu.edu.au>
To: Loic.Prylli@ens-lyon.fr
CC: linuxppc-dev@lists.linuxppc.org
In-reply-to: <199901301505.QAA14745@porto.ens-lyon.fr> (message from Loic
	Prylli on Sat, 30 Jan 1999 16:05:36 +0100 (MET))
Subject: Re: bug in arch/ppc/mm/init.c
Reply-to: Paul.Mackerras@cs.anu.edu.au
References: <199901301505.QAA14745@porto.ens-lyon.fr>
Sender: owner-linuxppc-dev@lists.linuxppc.org
List-Id: <linuxppc-dev@lists.linuxppc.org>


Loic Prylli <Loic.Prylli@ens-lyon.fr> wrote:

> The init function of some drivers use ioremap, which may call
> MMU_get_page (if the target zone cross a 4Mbyte/s bounday(. But
> MMU_get_page is marked as an initfunc, so it is no longer
> present->panic.

You're right, MMU_get_page shouldn't be an initfunc.

> Here one possible solution:
> 
> --- arch/ppc/mm/init.c~ Thu Jan  7 21:06:57 1999
> +++ arch/ppc/mm/init.c  Sat Jan 30 16:01:17 1999
> @@ -883,7 +883,7 @@
>         }           
>  }
>  
> -__initfunc(static void *MMU_get_page(void))
> +static void *MMU_get_page(void)
>  {
>         void *p;
>  

Looks good to me.

Paul.

[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to  Cc linuxppc-dev  if your ]]
[[ reply is of general interest. To unsubscribe from linuxppc-dev, send ]]
[[ the message 'unsubscribe' to linuxppc-dev-request@lists.linuxppc.org ]]