From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 3 Jun 1999 12:50:57 +1000 Message-Id: <199906030250.MAA04127@tango.anu.edu.au> From: Paul Mackerras To: costabel@wanadoo.fr CC: linuxppc-dev@lists.linuxppc.org, cort@ppc.kernel.org In-reply-to: <3755213D.3BB3C8B6@wanadoo.fr> (message from Martin Costabel on Wed, 02 Jun 1999 14:19:09 +0200) Subject: Re: Bug in vger 2.2.10 and 2.3.4 (Re: Problems with vger 2.3.3/4) Reply-to: Paul.Mackerras@cs.anu.edu.au References: <374D8E2A.48871830@wanadoo.fr> <3755213D.3BB3C8B6@wanadoo.fr> Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: Martin Costabel wrote: > A while ago I reported about boot problems with the vger 2.3.x kernel > after May 22. Now I found that this same bug has crept into the "stable" > tree, starting with 2.2.10 on May 30. After some digging, I found the > culprit. It is the file arch/ppc/mm/init.c, patched (wrongly) as > follows: [snip] > - return (void *) (v + (p & ~PAGE_MASK)); > + return (void *) (v + (addr & ~PAGE_MASK)); In fact that patch is correct but you also need this patch (which I'm about to check into vger): --- linux/arch/ppc/mm/init.c Sat May 29 20:24:09 1999 +++ pmac/arch/ppc/mm/init.c Thu Jun 3 10:13:00 1999 @@ -371,7 +371,7 @@ * same virt address (and this is contiguous). * -- Cort */ - if ( (v = p_mapped_by_bats(addr)) /*&& p_mapped_by_bats(addr+(size-1))*/ ) + if ( (v = p_mapped_by_bats(p)) /*&& p_mapped_by_bats(p+size-1)*/ ) goto out; #endif /* CONFIG_8xx */ Paul. [[ This message was sent via the linuxppc-dev mailing list. Replies are ]] [[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]] [[ reply is of general interest. Please check http://lists.linuxppc.org/ ]] [[ and http://www.linuxppc.org/ for useful information before posting. ]]