From: Alvin Brattli <Alvin.Brattli@phys.uit.no>
To: Ryan Nielsen <ran@krazynet.com>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: patch for dmasound bug
Date: Fri, 11 Jun 1999 00:56:26 +0200 [thread overview]
Message-ID: <199906102256.AAA01670@mitra.phys.uit.no> (raw)
In-Reply-To: Your message of "Wed, 02 Jun 1999 13:05:09 PDT." <19990602130509.A269@gondolin>
OK, this reply comes a bit late, but I didn't try the patch
until now, so here goes:
Ryan Nielsen:
>
>This restores the rate/byteswap to normal after playing a beep
>if you for example stop timidity, make a beep, resume, the sound
>will be slower than normal (without this patch).
Although this patch might do what it was intended for, it has some
unwanted consequences on the PowerBook G3 Series, namely that one gets a
constant, really annoying hiss from the loudspeakers, most notably
during the boot sequence. Without this patch, the hiss stops after a
system beep (like when you do an "echo ^G" in a shell), but now even
this does not help. So, if this patch is included in the standard
distribution, I suspect we will hear a lot of complaints from PowerBook
G3 users.
To me, it seems like there is something wrong in the dmasound driver
that causes this hiss; it just doesn't switch off all sound when it's
supposed to. I don't know enough about the workings of the audio
controller to go bug hunting here myself, so all I can do is just point
out that there is a problem here :(
>--- linux/drivers/sound/dmasound.c 1999/02/05 05:45:42 1.41
>+++ linux/drivers/sound/dmasound.c 1999/06/02 19:42:08
>@@ -3255,6 +3255,11 @@
> save_flags(flags); cli();
> if (beep_playing) {
> st_le16(&beep_dbdma_cmd->command, DBDMA_STOP);
>+ out_le32(&awacs_txdma->control, (RUN|PAUSE|FLUSH|WAKE) << 16);
>+ out_le32(&awacs->control,
>+ (in_le32(&awacs->control) & ~0x1f00)
>+ | (awacs_rate_index << 8));
>+ out_le32(&awacs->byteswap, sound.hard.format != AFMT_S16_BE);
> beep_playing = 0;
> }
> restore_flags(flags);
aLViN
--
:r .signature
[[ This message was sent via the linuxppc-dev mailing list. Replies are ]]
[[ not forced back to the list, so be sure to Cc linuxppc-dev if your ]]
[[ reply is of general interest. Please check http://lists.linuxppc.org/ ]]
[[ and http://www.linuxppc.org/ for useful information before posting. ]]
next prev parent reply other threads:[~1999-06-10 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-06-02 20:05 patch for dmasound bug Ryan Nielsen
1999-06-10 22:56 ` Alvin Brattli [this message]
1999-06-11 20:07 ` Ryan Nielsen
1999-06-11 22:54 ` Alvin Brattli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199906102256.AAA01670@mitra.phys.uit.no \
--to=alvin.brattli@phys.uit.no \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=ran@krazynet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.