From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF0F9C43331 for ; Tue, 12 Jan 2021 15:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76C562070B for ; Tue, 12 Jan 2021 15:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392200AbhALPxX (ORCPT ); Tue, 12 Jan 2021 10:53:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392192AbhALPxW (ORCPT ); Tue, 12 Jan 2021 10:53:22 -0500 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 173BEC061794 for ; Tue, 12 Jan 2021 07:52:42 -0800 (PST) Received: by mail-qk1-x730.google.com with SMTP id h4so2215553qkk.4 for ; Tue, 12 Jan 2021 07:52:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3VOirjeOIr8hFRm3h3Xp5mZuV+8C+76qUAIeoSHnuRs=; b=UD+st9PzLlClludf4uK5aFj+zVbeUU1a2TLuK04qgHnlgPAt/AOudNFQWtJlRebu7N f17RzYFk0zMzc7ZH+ay7DM/9vB5cf0pVrs0c6VdQgtEGkZMlLlioS/rZkY2dvdXOy0ML BXKWAVZPfGQfiz/Ofje4Ih0YWLOgdLwYlCvUvw0wMuhwWV6dmETlBD+Y2y14vcfs15uU HgLXCit1veUlQQyBqkZxKI/veK0gfCa5099+vs+hAmbaILlazZtKsCvrdQRYtzJlnrkr jS6l76MX6pazYYZmZvyqdHDldKVhIBZ0hejfWWocoeNVk8ewiuFNO17SZo5RFLJmx5HF HRnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3VOirjeOIr8hFRm3h3Xp5mZuV+8C+76qUAIeoSHnuRs=; b=Hku9LxFR1ZYB1VA7NLAPC2x9cIc9HjZZMeVl9lCmQw30e39u694arTb2t1DgtWYDhw lHeh7+DeZ8Jsobm5v9DQf89oBfKuq5PkEbhBz954to7UdA8kFG0Wxq6GA2ZqeDpbRlZr jAn/oENdipIqgXC0U7fswPa1HmVAudW8YT4vEvOV9Yb0Ki+Pvqr/5OcdWkYOrZz4umKC SAzmXK2ZpWVu/eU6biuiq2NhK1HDrGxSVmfYUPgLsiy4HfzpauMmYDkenUhaUqBSQRAv B7SsyN0P8ApYreDdYANHf2GL6RT3kmESF50Fl5mxlGuzKGu9la7QAoGl2UPWZ3ZigxS2 XIbg== X-Gm-Message-State: AOAM53293qOAIHvHAaXMHRWJFBHNjFmFSUA6ouVoBqqNah/UlKNg0qLb QQvgj9nQHfcys/dZeWXwAU/S/Q== X-Google-Smtp-Source: ABdhPJzXxc0ipRQINJ/p5shNULsus/jkY3XyvKky1a1zVgoSEOFq0r4Vr7GaLVcEOgm6Ss77yCP6Aw== X-Received: by 2002:a37:2796:: with SMTP id n144mr5369005qkn.471.1610466761282; Tue, 12 Jan 2021 07:52:41 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id q92sm1239635qtd.48.2021.01.12.07.52.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 07:52:40 -0800 (PST) Subject: Re: [PATCH v11 16/40] btrfs: advance allocation pointer after tree log node To: Naohiro Aota , linux-btrfs@vger.kernel.org, dsterba@suse.com Cc: hare@suse.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , "Darrick J. Wong" References: <06add214bc16ef08214de1594ecdfcc4cdcdbd78.1608608848.git.naohiro.aota@wdc.com> From: Josef Bacik Message-ID: <19ac727e-4232-8a2b-d36c-ab34eecc22ce@toxicpanda.com> Date: Tue, 12 Jan 2021 10:52:39 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 12/21/20 10:49 PM, Naohiro Aota wrote: > Since the allocation info of tree log node is not recorded to the extent > tree, calculate_alloc_pointer() cannot detect the node, so the pointer can > be over a tree node. > > Replaying the log call btrfs_remove_free_space() for each node in the log > tree. So, advance the pointer after the node. > > Signed-off-by: Naohiro Aota Reviewed-by: Josef Bacik Thanks, Josef