All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
To: "Pali Rohár" <pali@kernel.org>,
	linux-man@vger.kernel.org,
	"Michael Kerrisk" <mtk.manpages@gmail.com>
Subject: Re: [PATCH] ioctl_tty.2: Update DTR example
Date: Fri, 30 Jul 2021 20:22:28 +0200	[thread overview]
Message-ID: <1ac4e6e1-3336-a98e-b768-9b8ff25e7fba@gmail.com> (raw)
In-Reply-To: <20210730105444.10483-1-pali@kernel.org>

Hi Pali,

On 7/30/21 12:54 PM, Pali Rohár wrote:
> Do not include unused (and incompatible) header file termios.h and include
> required header files for puts() and close() functions.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Patch applied.  Thanks,

Alex

> ---
>   man2/ioctl_tty.2 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/man2/ioctl_tty.2 b/man2/ioctl_tty.2
> index 91aceddb7828..b5356738d4bb 100644
> --- a/man2/ioctl_tty.2
> +++ b/man2/ioctl_tty.2
> @@ -743,7 +743,8 @@ Insufficient permission.
>   Check the condition of DTR on the serial port.
>   .PP
>   .EX
> -#include <termios.h>
> +#include <stdio.h>
> +#include <unistd.h>
>   #include <fcntl.h>
>   #include <sys/ioctl.h>
>   
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

      reply	other threads:[~2021-07-30 18:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 10:54 [PATCH] ioctl_tty.2: Update DTR example Pali Rohár
2021-07-30 18:22 ` Alejandro Colomar (man-pages) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ac4e6e1-3336-a98e-b768-9b8ff25e7fba@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.