* [PATCH] tg3: add amd8131 to "write reorder" chipsets
@ 2006-07-07 18:58 John W. Linville
2006-07-07 19:12 ` David Miller
2006-07-08 20:29 ` David Miller
0 siblings, 2 replies; 11+ messages in thread
From: John W. Linville @ 2006-07-07 18:58 UTC (permalink / raw
To: netdev; +Cc: davem
Add the AMD 8131 bridge to the list of chipsets that reorder writes.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/tg3.c | 2 ++
1 files changed, 2 insertions(+)
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index f645921..ce6f3be 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -10078,6 +10078,8 @@ static int __devinit tg3_get_invariants(
static struct pci_device_id write_reorder_chipsets[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_AMD,
PCI_DEVICE_ID_AMD_FE_GATE_700C) },
+ { PCI_DEVICE(PCI_VENDOR_ID_AMD,
+ PCI_DEVICE_ID_AMD_8131_BRIDGE) },
{ PCI_DEVICE(PCI_VENDOR_ID_VIA,
PCI_DEVICE_ID_VIA_8385_0) },
{ },
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 18:58 [PATCH] tg3: add amd8131 to "write reorder" chipsets John W. Linville
@ 2006-07-07 19:12 ` David Miller
2006-07-07 19:21 ` John W. Linville
2006-07-07 20:21 ` Auke Kok
2006-07-08 20:29 ` David Miller
1 sibling, 2 replies; 11+ messages in thread
From: David Miller @ 2006-07-07 19:12 UTC (permalink / raw
To: linville; +Cc: netdev
From: "John W. Linville" <linville@tuxdriver.com>
Date: Fri, 7 Jul 2006 14:58:36 -0400
> Add the AMD 8131 bridge to the list of chipsets that reorder writes.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
What failure report is this chipset blacklist addition based
upon? I just want to look at the paper trail before adding
this.
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 19:12 ` David Miller
@ 2006-07-07 19:21 ` John W. Linville
2006-07-07 20:21 ` Auke Kok
1 sibling, 0 replies; 11+ messages in thread
From: John W. Linville @ 2006-07-07 19:21 UTC (permalink / raw
To: David Miller; +Cc: netdev
On Fri, Jul 07, 2006 at 12:12:20PM -0700, David Miller wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Fri, 7 Jul 2006 14:58:36 -0400
>
> > Add the AMD 8131 bridge to the list of chipsets that reorder writes.
> >
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> What failure report is this chipset blacklist addition based
> upon? I just want to look at the paper trail before adding
> this.
What? Due diligence? You must be joking!!! :-)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174019#c48
Hth!
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
@ 2006-07-07 19:51 Michael Chan
2006-07-07 20:16 ` John W. Linville
0 siblings, 1 reply; 11+ messages in thread
From: Michael Chan @ 2006-07-07 19:51 UTC (permalink / raw
To: John W. Linville, netdev; +Cc: davem
John W. Linville wrote:
> Add the AMD 8131 bridge to the list of chipsets that reorder writes.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Hi John,
The latest tg3 driver in 2.6.18 has a recovery mechanism to detect
and recover from this kind of reordering problem. I suppose we can
add this chipset now if we're reasonably sure that it is reordering
MMIO. But it will be nice to actually see the recovery mechanism in
action catching this chipset.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 19:51 Michael Chan
@ 2006-07-07 20:16 ` John W. Linville
0 siblings, 0 replies; 11+ messages in thread
From: John W. Linville @ 2006-07-07 20:16 UTC (permalink / raw
To: Michael Chan; +Cc: netdev, davem
On Fri, Jul 07, 2006 at 12:51:35PM -0700, Michael Chan wrote:
> John W. Linville wrote:
>
> > Add the AMD 8131 bridge to the list of chipsets that reorder writes.
> >
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Hi John,
>
> The latest tg3 driver in 2.6.18 has a recovery mechanism to detect
> and recover from this kind of reordering problem. I suppose we can
> add this chipset now if we're reasonably sure that it is reordering
> MMIO. But it will be nice to actually see the recovery mechanism in
> action catching this chipset.
Obviously it is between you and Dave to decide what is best. We are
carrying this patch in RHEL4 at the moment, so I didn't want to hold
it back from upstream. If you think you have a better solution then
"it's on you"... :-)
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 19:12 ` David Miller
2006-07-07 19:21 ` John W. Linville
@ 2006-07-07 20:21 ` Auke Kok
2006-07-07 20:57 ` David Miller
1 sibling, 1 reply; 11+ messages in thread
From: Auke Kok @ 2006-07-07 20:21 UTC (permalink / raw
To: David Miller; +Cc: linville, netdev
David Miller wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Fri, 7 Jul 2006 14:58:36 -0400
>
>> Add the AMD 8131 bridge to the list of chipsets that reorder writes.
>>
>> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> What failure report is this chipset blacklist addition based
> upon? I just want to look at the paper trail before adding
> this.
Moreover, since e1000 suffers from reordering/write-combining problems on the
8132, I'm starting to see an (ugly) pattern here. I didn't know that tg3 has a
whole blacklist for this, could this affect other network cards as well?
Auke
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 20:21 ` Auke Kok
@ 2006-07-07 20:57 ` David Miller
0 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2006-07-07 20:57 UTC (permalink / raw
To: auke-jan.h.kok; +Cc: linville, netdev
From: Auke Kok <auke-jan.h.kok@intel.com>
Date: Fri, 07 Jul 2006 13:21:38 -0700
> Moreover, since e1000 suffers from reordering/write-combining
> problems on the 8132, I'm starting to see an (ugly) pattern here. I
> didn't know that tg3 has a whole blacklist for this, could this
> affect other network cards as well?
The tg3 is probably more susceptible to this problem because of
how it uses a software structure in memory for interrupt status and
RX/TX descriptor table head/tail indexes.
Whereas the e1000 always has to synchronize with MMIO register reads
to get interrupt status and the indexes.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
@ 2006-07-07 21:22 Michael Chan
2006-07-07 23:57 ` David Miller
0 siblings, 1 reply; 11+ messages in thread
From: Michael Chan @ 2006-07-07 21:22 UTC (permalink / raw
To: John W. Linville; +Cc: netdev, davem
John W. Linville wrote:
> Obviously it is between you and Dave to decide what is best. We are
> carrying this patch in RHEL4 at the moment, so I didn't want to hold
> it back from upstream. If you think you have a better solution then
> "it's on you"... :-)
>
Since 2.6.18 already has the recovery logic in place, we can probably
holdoff merging this patch upstream.
If e1000 is having similar problems with a similar AMD chipset, it
must be a fairly widespread problem. It might be a good idea to
push this patch to -stable.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 21:22 Michael Chan
@ 2006-07-07 23:57 ` David Miller
0 siblings, 0 replies; 11+ messages in thread
From: David Miller @ 2006-07-07 23:57 UTC (permalink / raw
To: mchan; +Cc: linville, netdev
From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 7 Jul 2006 14:22:11 -0700
> John W. Linville wrote:
>
> > Obviously it is between you and Dave to decide what is best. We are
> > carrying this patch in RHEL4 at the moment, so I didn't want to hold
> > it back from upstream. If you think you have a better solution then
> > "it's on you"... :-)
>
> Since 2.6.18 already has the recovery logic in place, we can probably
> holdoff merging this patch upstream.
I think that since we do have a proof positive report, and well
documented success of the fix, we should add the fix even though
we have the fallback thing to take care of it.
This is how we were going to use the fall-back code, to make the the
chipset blacklist more robust yet still allow the user's machine to
work meanwhile. Here, we have enough information to add the blacklist
entry safely.
What do you think?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
@ 2006-07-08 0:49 Michael Chan
0 siblings, 0 replies; 11+ messages in thread
From: Michael Chan @ 2006-07-08 0:49 UTC (permalink / raw
To: David Miller; +Cc: linville, netdev
David Miller wrote:
> I think that since we do have a proof positive report, and well
> documented success of the fix, we should add the fix even though
> we have the fallback thing to take care of it.
>
> This is how we were going to use the fall-back code, to make the the
> chipset blacklist more robust yet still allow the user's machine to
> work meanwhile. Here, we have enough information to add the blacklist
> entry safely.
>
> What do you think?
>
>
OK, no objection to merging it now.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] tg3: add amd8131 to "write reorder" chipsets
2006-07-07 18:58 [PATCH] tg3: add amd8131 to "write reorder" chipsets John W. Linville
2006-07-07 19:12 ` David Miller
@ 2006-07-08 20:29 ` David Miller
1 sibling, 0 replies; 11+ messages in thread
From: David Miller @ 2006-07-08 20:29 UTC (permalink / raw
To: linville; +Cc: netdev
From: "John W. Linville" <linville@tuxdriver.com>
Date: Fri, 7 Jul 2006 14:58:36 -0400
> Add the AMD 8131 bridge to the list of chipsets that reorder writes.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
Applied, thanks John.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2006-07-08 20:29 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-07 18:58 [PATCH] tg3: add amd8131 to "write reorder" chipsets John W. Linville
2006-07-07 19:12 ` David Miller
2006-07-07 19:21 ` John W. Linville
2006-07-07 20:21 ` Auke Kok
2006-07-07 20:57 ` David Miller
2006-07-08 20:29 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2006-07-07 19:51 Michael Chan
2006-07-07 20:16 ` John W. Linville
2006-07-07 21:22 Michael Chan
2006-07-07 23:57 ` David Miller
2006-07-08 0:49 Michael Chan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.