All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table
@ 2014-02-19 13:10 Stephane Eranian
  2014-02-20  6:20 ` Yan, Zheng
  2014-02-21 21:14 ` [tip:perf/urgent] perf/x86/uncore: Fix IVT/ SNB-EP " tip-bot for Stephane Eranian
  0 siblings, 2 replies; 5+ messages in thread
From: Stephane Eranian @ 2014-02-19 13:10 UTC (permalink / raw
  To: linux-kernel; +Cc: peterz, mingo, ak, zheng.z.yan


This patch updates the CBOX PMU filters mapping tables for SNB-EP
and IVT (model 45 and 62 respectively).

The NID umask always comes in addition to another umask.
When set, the NID filter is applied.

The current mapping tables were missing some code/umask
combinations to account for the NID umask. This patch
fixes that.
    
Signed-off-by: Stephane Eranian <eranian@google.com>

diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -501,8 +501,11 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
 				  SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
@@ -1178,10 +1181,15 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
 				  SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
-	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x10),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x10),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x2135, 0xffff, 0x10),

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table
  2014-02-19 13:10 [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table Stephane Eranian
@ 2014-02-20  6:20 ` Yan, Zheng
  2014-02-20  8:56   ` Stephane Eranian
  2014-02-21 21:14 ` [tip:perf/urgent] perf/x86/uncore: Fix IVT/ SNB-EP " tip-bot for Stephane Eranian
  1 sibling, 1 reply; 5+ messages in thread
From: Yan, Zheng @ 2014-02-20  6:20 UTC (permalink / raw
  To: Stephane Eranian, linux-kernel; +Cc: peterz, mingo, ak

On 02/19/2014 09:10 PM, Stephane Eranian wrote:
> 
> This patch updates the CBOX PMU filters mapping tables for SNB-EP
> and IVT (model 45 and 62 respectively).
> 
> The NID umask always comes in addition to another umask.
> When set, the NID filter is applied.

Do you means the NID always applies for LLC_LOOKUP no matter what umask is.
If yes, I think it's better to define filter as SNBEP_CBO_EVENT_EXTRA_REG(0x34, 0xff, 0x6)

Regards
Yan, Zheng

> 
> The current mapping tables were missing some code/umask
> combinations to account for the NID umask. This patch
> fixes that.
>     
> Signed-off-by: Stephane Eranian <eranian@google.com>
> 
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> @@ -501,8 +501,11 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
>  	SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>  				  SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0x6),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0x6),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0x6),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
> @@ -1178,10 +1181,15 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
>  	SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>  				  SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0xc),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0xc),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
> -	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
> +	SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0xc),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x10),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x10),
>  	SNBEP_CBO_EVENT_EXTRA_REG(0x2135, 0xffff, 0x10),
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table
  2014-02-20  6:20 ` Yan, Zheng
@ 2014-02-20  8:56   ` Stephane Eranian
  2014-02-20  9:00     ` Yan, Zheng
  0 siblings, 1 reply; 5+ messages in thread
From: Stephane Eranian @ 2014-02-20  8:56 UTC (permalink / raw
  To: Yan, Zheng; +Cc: LKML, Peter Zijlstra, mingo@elte.hu, ak@linux.intel.com

On Thu, Feb 20, 2014 at 7:20 AM, Yan, Zheng <zheng.z.yan@intel.com> wrote:
> On 02/19/2014 09:10 PM, Stephane Eranian wrote:
>>
>> This patch updates the CBOX PMU filters mapping tables for SNB-EP
>> and IVT (model 45 and 62 respectively).
>>
>> The NID umask always comes in addition to another umask.
>> When set, the NID filter is applied.
>
> Do you means the NID always applies for LLC_LOOKUP no matter what umask is.
> If yes, I think it's better to define filter as SNBEP_CBO_EVENT_EXTRA_REG(0x34, 0xff, 0x6)
>
No. I mean you can add NID umask to any other umask but it cannot be
used by itself.
In other words, LLC_LOOKUP.NID is not allowed but LLC_LOOKUP.DATA_READ.NID is.

That is what I gathered from the description in the specs.


> Regards
> Yan, Zheng
>
>>
>> The current mapping tables were missing some code/umask
>> combinations to account for the NID umask. This patch
>> fixes that.
>>
>> Signed-off-by: Stephane Eranian <eranian@google.com>
>>
>> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>> @@ -501,8 +501,11 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
>>       SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>>                                 SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0x6),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0x6),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0x6),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
>> @@ -1178,10 +1181,15 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
>>       SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>>                                 SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0xc),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0xc),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
>> -     SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0xc),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x10),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x10),
>>       SNBEP_CBO_EVENT_EXTRA_REG(0x2135, 0xffff, 0x10),
>>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table
  2014-02-20  8:56   ` Stephane Eranian
@ 2014-02-20  9:00     ` Yan, Zheng
  0 siblings, 0 replies; 5+ messages in thread
From: Yan, Zheng @ 2014-02-20  9:00 UTC (permalink / raw
  To: Stephane Eranian; +Cc: LKML, Peter Zijlstra, mingo@elte.hu, ak@linux.intel.com

On 02/20/2014 04:56 PM, Stephane Eranian wrote:
> On Thu, Feb 20, 2014 at 7:20 AM, Yan, Zheng <zheng.z.yan@intel.com> wrote:
>> On 02/19/2014 09:10 PM, Stephane Eranian wrote:
>>>
>>> This patch updates the CBOX PMU filters mapping tables for SNB-EP
>>> and IVT (model 45 and 62 respectively).
>>>
>>> The NID umask always comes in addition to another umask.
>>> When set, the NID filter is applied.
>>
>> Do you means the NID always applies for LLC_LOOKUP no matter what umask is.
>> If yes, I think it's better to define filter as SNBEP_CBO_EVENT_EXTRA_REG(0x34, 0xff, 0x6)
>>
> No. I mean you can add NID umask to any other umask but it cannot be
> used by itself.
> In other words, LLC_LOOKUP.NID is not allowed but LLC_LOOKUP.DATA_READ.NID is.
> 
> That is what I gathered from the description in the specs.

Thanks

Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>

> 
> 
>> Regards
>> Yan, Zheng
>>
>>>
>>> The current mapping tables were missing some code/umask
>>> combinations to account for the NID umask. This patch
>>> fixes that.
>>>
>>> Signed-off-by: Stephane Eranian <eranian@google.com>
>>>
>>> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>>> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>>> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
>>> @@ -501,8 +501,11 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
>>>       SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>>>                                 SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0x6),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0x6),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0x6),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
>>> @@ -1178,10 +1181,15 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
>>>       SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
>>>                                 SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0xc),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0xc),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
>>> -     SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
>>> +     SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0xc),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x10),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x10),
>>>       SNBEP_CBO_EVENT_EXTRA_REG(0x2135, 0xffff, 0x10),
>>>
>>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [tip:perf/urgent] perf/x86/uncore: Fix IVT/ SNB-EP uncore CBOX NID filter table
  2014-02-19 13:10 [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table Stephane Eranian
  2014-02-20  6:20 ` Yan, Zheng
@ 2014-02-21 21:14 ` tip-bot for Stephane Eranian
  1 sibling, 0 replies; 5+ messages in thread
From: tip-bot for Stephane Eranian @ 2014-02-21 21:14 UTC (permalink / raw
  To: linux-tip-commits
  Cc: linux-kernel, eranian, hpa, mingo, peterz, zheng.z.yan, tglx

Commit-ID:  337397f3afc911d94d1d71371a36a53ce218b41f
Gitweb:     http://git.kernel.org/tip/337397f3afc911d94d1d71371a36a53ce218b41f
Author:     Stephane Eranian <eranian@google.com>
AuthorDate: Wed, 19 Feb 2014 14:10:18 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 21 Feb 2014 22:09:01 +0100

perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table

This patch updates the CBOX PMU filters mapping tables for SNB-EP
and IVT (model 45 and 62 respectively).

The NID umask always comes in addition to another umask.
When set, the NID filter is applied.

The current mapping tables were missing some code/umask
combinations to account for the NID umask. This patch
fixes that.

Cc: mingo@elte.hu
Cc: ak@linux.intel.com
Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140219131018.GA24475@quad
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/cpu/perf_event_intel_uncore.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
index 29c2487..c88f7f4 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
@@ -501,8 +501,11 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
 				  SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8),
@@ -1178,10 +1181,15 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = {
 	SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN,
 				  SNBEP_CBO_PMON_CTL_TID_EN, 0x1),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0334, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4334, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0534, 0xffff, 0x4),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4534, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0934, 0xffff, 0x4),
-	SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc),
+	SNBEP_CBO_EVENT_EXTRA_REG(0x4934, 0xffff, 0xc),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x10),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x10),
 	SNBEP_CBO_EVENT_EXTRA_REG(0x2135, 0xffff, 0x10),

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-02-21 21:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-19 13:10 [PATCH] perf/x86/uncore: Fix IVT/SNB-EP uncore CBOX NID filter table Stephane Eranian
2014-02-20  6:20 ` Yan, Zheng
2014-02-20  8:56   ` Stephane Eranian
2014-02-20  9:00     ` Yan, Zheng
2014-02-21 21:14 ` [tip:perf/urgent] perf/x86/uncore: Fix IVT/ SNB-EP " tip-bot for Stephane Eranian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.