All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: vt6656: whitespace checkpatch warning fix.
@ 2014-12-10 17:05 Krzysztof Adamski
  2015-01-13  3:41 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Adamski @ 2014-12-10 17:05 UTC (permalink / raw
  To: Forest Bond, Greg Kroah-Hartman, Malcolm Priestley; +Cc: devel, linux-kernel

This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
 drivers/staging/vt6656/rxtx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index ea5140a..5a18e26 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
 
 static const u16 vnt_fb_opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
 };
 
 #define RTSDUR_BB       0
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] staging: vt6656: whitespace checkpatch warning fix.
@ 2014-12-22 16:08 Krzysztof Adamski
  2015-01-13  3:41 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Adamski @ 2014-12-22 16:08 UTC (permalink / raw
  To: Greg Kroah-Hartman, Forest Bond, Malcolm Priestley; +Cc: devel, linux-kernel

This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
 drivers/staging/vt6656/rxtx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index ea5140a..5a18e26 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
 
 static const u16 vnt_fb_opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
 };
 
 #define RTSDUR_BB       0
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: vt6656: whitespace checkpatch warning fix.
  2014-12-10 17:05 [PATCH] staging: vt6656: whitespace checkpatch warning fix Krzysztof Adamski
@ 2015-01-13  3:41 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-01-13  3:41 UTC (permalink / raw
  To: Krzysztof Adamski; +Cc: Forest Bond, Malcolm Priestley, devel, linux-kernel

On Wed, Dec 10, 2014 at 06:05:31PM +0100, Krzysztof Adamski wrote:
> This fixes following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
> 
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
> ---
>  drivers/staging/vt6656/rxtx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index ea5140a..5a18e26 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
>  
>  static const u16 vnt_fb_opt1[2][5] = {
>  	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
> -	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> +	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>  };
>  
>  #define RTSDUR_BB       0
> -- 
> 1.7.10.4

You already sent this, why send it again?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: vt6656: whitespace checkpatch warning fix.
  2014-12-22 16:08 Krzysztof Adamski
@ 2015-01-13  3:41 ` Greg Kroah-Hartman
  2015-01-13  7:06   ` Krzysztof Adamski
  0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2015-01-13  3:41 UTC (permalink / raw
  To: Krzysztof Adamski; +Cc: Forest Bond, Malcolm Priestley, devel, linux-kernel

On Mon, Dec 22, 2014 at 05:08:34PM +0100, Krzysztof Adamski wrote:
> This fixes following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
> 
> Signed-off-by: Krzysztof Adamski <k@japko.eu>
> ---
> drivers/staging/vt6656/rxtx.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index ea5140a..5a18e26 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
> 
> static const u16 vnt_fb_opt1[2][5] = {
> 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
> -	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> +	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
> };
> 
> #define RTSDUR_BB       0
> -- 
> 1.7.10.4

Again resend?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: vt6656: whitespace checkpatch warning fix.
  2015-01-13  3:41 ` Greg Kroah-Hartman
@ 2015-01-13  7:06   ` Krzysztof Adamski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Adamski @ 2015-01-13  7:06 UTC (permalink / raw
  To: Greg Kroah-Hartman; +Cc: devel, linux-kernel

On Mon, Jan 12, 2015 at 07:41:34PM -0800, Greg Kroah-Hartman wrote:
>On Mon, Dec 22, 2014 at 05:08:34PM +0100, Krzysztof Adamski wrote:
>> This fixes following checkpatch.pl error:
>> ERROR: space prohibited before that ',' (ctx:WxW)
>>
>> Signed-off-by: Krzysztof Adamski <k@japko.eu>
>> ---
>> drivers/staging/vt6656/rxtx.c |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
>> index ea5140a..5a18e26 100644
>> --- a/drivers/staging/vt6656/rxtx.c
>> +++ b/drivers/staging/vt6656/rxtx.c
>> @@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
>>
>> static const u16 vnt_fb_opt1[2][5] = {
>> 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
>> -	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>> +	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
>> };
>>
>> #define RTSDUR_BB       0
>> --
>> 1.7.10.4
>
>Again resend?

Sorry, it was my first attempt at getting some patch to upstream kernel.  
I was following your advice about being persistent:
http://www.reddit.com/r/linux/comments/2ny1lz/im_greg_kroahhartman_linux_kernel_developer_ama/cmvltqk

Next time I'll wait much longer.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-13  7:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-10 17:05 [PATCH] staging: vt6656: whitespace checkpatch warning fix Krzysztof Adamski
2015-01-13  3:41 ` Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2014-12-22 16:08 Krzysztof Adamski
2015-01-13  3:41 ` Greg Kroah-Hartman
2015-01-13  7:06   ` Krzysztof Adamski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.