From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149AbbCXTD7 (ORCPT ); Tue, 24 Mar 2015 15:03:59 -0400 Received: from foss.arm.com ([217.140.101.70]:49271 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037AbbCXTD6 (ORCPT ); Tue, 24 Mar 2015 15:03:58 -0400 Date: Tue, 24 Mar 2015 19:04:05 +0000 From: Lorenzo Pieralisi To: Daniel Lezcano Cc: "rjw@rjwysocki.net" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Catalin Marinas , "robherring2@gmail.com" , "arnd@arndb.de" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lina.iyer@linaro.org" , "sboyd@codeaurora.org" Subject: Re: [PATCH 2/2] ARM: cpuidle: Document the code Message-ID: <20150324190405.GC27311@red-moon> References: <20150323225828.GC15435@e102568-lin.cambridge.arm.com> <1427190842-30675-1-git-send-email-daniel.lezcano@linaro.org> <1427190842-30675-2-git-send-email-daniel.lezcano@linaro.org> <20150324185144.GB27311@red-moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150324185144.GB27311@red-moon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2015 at 06:51:44PM +0000, Lorenzo Pieralisi wrote: > On Tue, Mar 24, 2015 at 09:54:02AM +0000, Daniel Lezcano wrote: [...] > > +/* > > + * arm_cpuidle_init() - Initialize cpuidle_ops for a specific cpu > > + * @cpu: the cpu to be initialized > > + * > > + * Initialize the cpuidle ops with the device for the cpu and then call > > + * the cpu's idle initialization callback. This may fail if the underlying HW > > + * is not operational. > > + * > > + * Returns: > > + * 0 on success, > > + * -ENODEV if it fails to find the cpu node in the device tree, > > + * -EOPNOTSUPP if it does not find a registered cpuidle_ops for this cpu, > > + * -ENOENT if it fails to find a enabled-method property, > > Ultra-nit: "an enabled-method" Bah, I cannot see the wood for the trees anymore. "an enable-method". Lorenzo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lorenzo Pieralisi Subject: Re: [PATCH 2/2] ARM: cpuidle: Document the code Date: Tue, 24 Mar 2015 19:04:05 +0000 Message-ID: <20150324190405.GC27311@red-moon> References: <20150323225828.GC15435@e102568-lin.cambridge.arm.com> <1427190842-30675-1-git-send-email-daniel.lezcano@linaro.org> <1427190842-30675-2-git-send-email-daniel.lezcano@linaro.org> <20150324185144.GB27311@red-moon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150324185144.GB27311@red-moon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Lezcano Cc: "rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Catalin Marinas , "robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" List-Id: devicetree@vger.kernel.org On Tue, Mar 24, 2015 at 06:51:44PM +0000, Lorenzo Pieralisi wrote: > On Tue, Mar 24, 2015 at 09:54:02AM +0000, Daniel Lezcano wrote: [...] > > +/* > > + * arm_cpuidle_init() - Initialize cpuidle_ops for a specific cpu > > + * @cpu: the cpu to be initialized > > + * > > + * Initialize the cpuidle ops with the device for the cpu and then call > > + * the cpu's idle initialization callback. This may fail if the underlying HW > > + * is not operational. > > + * > > + * Returns: > > + * 0 on success, > > + * -ENODEV if it fails to find the cpu node in the device tree, > > + * -EOPNOTSUPP if it does not find a registered cpuidle_ops for this cpu, > > + * -ENOENT if it fails to find a enabled-method property, > > Ultra-nit: "an enabled-method" Bah, I cannot see the wood for the trees anymore. "an enable-method". Lorenzo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) Date: Tue, 24 Mar 2015 19:04:05 +0000 Subject: [PATCH 2/2] ARM: cpuidle: Document the code In-Reply-To: <20150324185144.GB27311@red-moon> References: <20150323225828.GC15435@e102568-lin.cambridge.arm.com> <1427190842-30675-1-git-send-email-daniel.lezcano@linaro.org> <1427190842-30675-2-git-send-email-daniel.lezcano@linaro.org> <20150324185144.GB27311@red-moon> Message-ID: <20150324190405.GC27311@red-moon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 24, 2015 at 06:51:44PM +0000, Lorenzo Pieralisi wrote: > On Tue, Mar 24, 2015 at 09:54:02AM +0000, Daniel Lezcano wrote: [...] > > +/* > > + * arm_cpuidle_init() - Initialize cpuidle_ops for a specific cpu > > + * @cpu: the cpu to be initialized > > + * > > + * Initialize the cpuidle ops with the device for the cpu and then call > > + * the cpu's idle initialization callback. This may fail if the underlying HW > > + * is not operational. > > + * > > + * Returns: > > + * 0 on success, > > + * -ENODEV if it fails to find the cpu node in the device tree, > > + * -EOPNOTSUPP if it does not find a registered cpuidle_ops for this cpu, > > + * -ENOENT if it fails to find a enabled-method property, > > Ultra-nit: "an enabled-method" Bah, I cannot see the wood for the trees anymore. "an enable-method". Lorenzo