From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966308AbbD2O30 (ORCPT ); Wed, 29 Apr 2015 10:29:26 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:35816 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966218AbbD2O3Y (ORCPT ); Wed, 29 Apr 2015 10:29:24 -0400 Date: Wed, 29 Apr 2015 15:29:18 +0100 From: Lee Jones To: Shobhit Kumar Cc: intel-gfx , linux-kernel , linux-gpio , linux-pwm , dri-devel , Linus Walleij , Alexandre Courbot , Daniel Vetter , David Airlie , Samuel Ortiz , Thierry Reding , Jani Nikula , Povilas Staniulis , Chih-Wei Huang Subject: Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal Message-ID: <20150429142918.GV9169@x1> References: <1430316005-16480-1-git-send-email-shobhit.kumar@intel.com> <1430316005-16480-4-git-send-email-shobhit.kumar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430316005-16480-4-git-send-email-shobhit.kumar@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By the way, your subject lines are messed up. They should adhere to the conventions laid down by the Maintainers. `git log --oneline -- drivers/` > On some Intel SoC platforms, the panel enable/disable signals are > controlled by CRC PMIC. Add those control as a new GPIO in a lookup > table for gpio-crystalcove chip during CRC driver load > > v2: Make the lookup table static (Thierry) > Remove the lookup table during driver remove (Thierry) > > CC: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Signed-off-by: Shobhit Kumar > --- > drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index 7b50b6b..f3d918e 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -24,8 +24,19 @@ > #include > #include > #include > +#include > #include "intel_soc_pmic_core.h" > > +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ > +static struct gpiod_lookup_table panel_gpio_table = { > + /* Intel GFX is consumer */ > + .dev_id = "0000:00:02.0", > + .table = { > + /* Panel EN/DISABLE */ > + GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + }, > +}; > + > static int intel_soc_pmic_find_gpio_irq(struct device *dev) > { > struct gpio_desc *desc; > @@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, > if (ret) > dev_warn(dev, "Can't enable IRQ as wake source: %d\n", ret); > > + /* Add lookup table binding for Panel Control to the GPIO Chip */ > + gpiod_add_lookup_table(&panel_gpio_table); > + > ret = mfd_add_devices(dev, -1, config->cell_dev, > config->n_cell_devs, NULL, 0, > regmap_irq_get_domain(pmic->irq_chip_data)); > @@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client *i2c) > > regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); > > + /* Remove lookup table for Panel Control from the GPIO Chip */ > + gpiod_remove_lookup_table(&panel_gpio_table); > + > mfd_remove_devices(&i2c->dev); > > return 0; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 3/8] drivers/mfd: Add lookup table for Panel Control as GPIO signal Date: Wed, 29 Apr 2015 15:29:18 +0100 Message-ID: <20150429142918.GV9169@x1> References: <1430316005-16480-1-git-send-email-shobhit.kumar@intel.com> <1430316005-16480-4-git-send-email-shobhit.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f180.google.com ([209.85.212.180]:37285 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966212AbbD2O3Y (ORCPT ); Wed, 29 Apr 2015 10:29:24 -0400 Received: by widdi4 with SMTP id di4so68132277wid.0 for ; Wed, 29 Apr 2015 07:29:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1430316005-16480-4-git-send-email-shobhit.kumar@intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Shobhit Kumar Cc: intel-gfx , linux-kernel , linux-gpio , linux-pwm , dri-devel , Linus Walleij , Alexandre Courbot , Daniel Vetter , David Airlie , Samuel Ortiz , Thierry Reding , Jani Nikula , Povilas Staniulis , Chih-Wei Huang By the way, your subject lines are messed up. They should adhere to the conventions laid down by the Maintainers. `git log --oneline -- drivers/` > On some Intel SoC platforms, the panel enable/disable signals are > controlled by CRC PMIC. Add those control as a new GPIO in a lookup > table for gpio-crystalcove chip during CRC driver load >=20 > v2: Make the lookup table static (Thierry) > Remove the lookup table during driver remove (Thierry) >=20 > CC: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Signed-off-by: Shobhit Kumar > --- > drivers/mfd/intel_soc_pmic_core.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_so= c_pmic_core.c > index 7b50b6b..f3d918e 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -24,8 +24,19 @@ > #include > #include > #include > +#include > #include "intel_soc_pmic_core.h" > =20 > +/* Lookup table for the Panel Enable/Disable line as GPIO signals */ > +static struct gpiod_lookup_table panel_gpio_table =3D { > + /* Intel GFX is consumer */ > + .dev_id =3D "0000:00:02.0", > + .table =3D { > + /* Panel EN/DISABLE */ > + GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + }, > +}; > + > static int intel_soc_pmic_find_gpio_irq(struct device *dev) > { > struct gpio_desc *desc; > @@ -85,6 +96,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_clie= nt *i2c, > if (ret) > dev_warn(dev, "Can't enable IRQ as wake source: %d\n", ret); > =20 > + /* Add lookup table binding for Panel Control to the GPIO Chip */ > + gpiod_add_lookup_table(&panel_gpio_table); > + > ret =3D mfd_add_devices(dev, -1, config->cell_dev, > config->n_cell_devs, NULL, 0, > regmap_irq_get_domain(pmic->irq_chip_data)); > @@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_c= lient *i2c) > =20 > regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); > =20 > + /* Remove lookup table for Panel Control from the GPIO Chip */ > + gpiod_remove_lookup_table(&panel_gpio_table); > + > mfd_remove_devices(&i2c->dev); > =20 > return 0; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html