From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757560AbbEVPGA (ORCPT ); Fri, 22 May 2015 11:06:00 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:36748 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757307AbbEVPF5 (ORCPT ); Fri, 22 May 2015 11:05:57 -0400 Date: Fri, 22 May 2015 08:05:54 -0700 From: Guenter Roeck To: Fu Wei Cc: Timo Kokkonen , Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Timur Tabi , Ashwin Chaugule , Arnd Bergmann , vgandhi@codeaurora.org, wim@iguana.be, Jon Masters , Leo Duran , Jon Corbet , Mark Rutland Subject: Re: [PATCH v2 5/7] Watchdog: introduce "pretimeout" into framework Message-ID: <20150522150554.GB2930@roeck-us.net> References: <=fu.wei@linaro.org> <1432197156-16947-1-git-send-email-fu.wei@linaro.org> <1432197156-16947-6-git-send-email-fu.wei@linaro.org> <555ECD04.6000404@offcode.fi> <555EEFDB.2030907@offcode.fi> <555F2DED.2010200@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=0.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 22, 2015 at 10:38:32PM +0800, Fu Wei wrote: > Hi Guenter. > > Sorry for my poor English . > let me explain this : > > On 22 May 2015 at 21:23, Guenter Roeck wrote: > > On 05/22/2015 03:46 AM, Fu Wei wrote: > >> > >> Hi Timo, > >> > > [ ... ] > > > >> So I am still trying to improve pretimeout support :-) > > > > > > Is there anything still missing from it ? > > > >> If I can make pretimeout merged, may be you can try pretimeout to > >> implement early_timeout_sec function? > > > > > > Not sure how one would or even could do that. > > > > Do you mean "implement early_pretimeout_sec", by any chance ? > > I mean: using pretimeout to implement the function you want, instead > of early_pretimeout_sec > How would this work if the watchdog hardware doesn't support pretimeout ? Pretimeout and early timeout are two logically different functions, with different goals, so I don't entirely (if at all) understand why it would make sense to tie them together. Can you elaborate why you think this would be a good idea ? Thanks, Guenter