From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: Re: [PATCH 2/5] cxgbe: add cxgbe poll mode driver.
Date: Sat, 23 May 2015 11:26:31 +0530
Message-ID: <20150523055629.GB4569@scalar.blr.asicdesigners.com>
References: <cover.1432300701.git.rahul.lakkireddy@chelsio.com>
 <25f06823ef87d05bf57d996df387478e7fbc966f.1432300701.git.rahul.lakkireddy@chelsio.com>
 <20150522094320.1e10251d@urahara>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Felix Marti <felix@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from stargate3.asicdesigners.com (stargate.chelsio.com
 [67.207.112.58]) by dpdk.org (Postfix) with ESMTP id CA5F8377C
 for <dev@dpdk.org>; Sat, 23 May 2015 07:56:56 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20150522094320.1e10251d@urahara>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 22, 2015 at 09:43:20 -0700, Stephen Hemminger wrote:
> On Fri, 22 May 2015 18:54:20 +0530
> Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> wrote:
> 
> > +/**
> > + * fls - find last (most-significant) bit set
> > + * @x: the word to search
> > + *
> > + * This is defined the same way as ffs.
> > + * Note fls(0) = 0, fls(1) = 1, fls(0x80000000) = 32.
> > + */
> > +static inline int fls(int x)
> 
> Isn't there a Gcc intrinsic already for this?

I guess you are referring to __builtin_clz ?
I will do that change in v2.


Thanks,
Rahul.