From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753788AbbEZNYN (ORCPT ); Tue, 26 May 2015 09:24:13 -0400 Received: from foss.arm.com ([217.140.101.70]:49734 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752825AbbEZNYH (ORCPT ); Tue, 26 May 2015 09:24:07 -0400 Date: Tue, 26 May 2015 13:28:58 +0100 From: Will Deacon To: "fu.wei@linaro.org" Cc: "suravee.suthikulpanit@amd.com" , "linaro-acpi@lists.linaro.org" , "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "tekkamanninja@gmail.com" , "graeme.gregory@linaro.org" , "al.stone@linaro.org" , "hanjun.guo@linaro.org" , "timur@codeaurora.org" , "ashwin.chaugule@linaro.org" , "arnd@arndb.de" , "linux@roeck-us.net" , "vgandhi@codeaurora.org" , "wim@iguana.be" , "jcm@redhat.com" , "leo.duran@amd.com" , "corbet@lwn.net" , Mark Rutland , Catalin Marinas Subject: Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device Message-ID: <20150526122858.GJ1565@arm.com> References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-7-git-send-email-fu.wei@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432548193-19569-7-git-send-email-fu.wei@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2015 at 11:03:13AM +0100, fu.wei@linaro.org wrote: > From: Fu Wei > > Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, > and create a platform device with that information. > This platform device can be used by the ARM SBSA Generic > Watchdog driver. > > Tested-by: Suravee Suthikulpanit > Tested-by: Timur Tabi > Signed-off-by: Fu Wei > --- > arch/arm64/kernel/acpi.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 145 insertions(+) Why does this all need to be under arch/arm64? The GTDT really isn't architecture-specific, so I'd *much* rather it was parsed in the driver code itself, like we already do for the architected timer. The GIC is an exception because it's in the MADT, which we need to parse in the arch code to configure SMP properly. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device Date: Tue, 26 May 2015 13:28:58 +0100 Message-ID: <20150526122858.GJ1565@arm.com> References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-7-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1432548193-19569-7-git-send-email-fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" Cc: "suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org" , "linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org" , "linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "tekkamanninja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "ashwin.chaugule-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org" , "vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org" , "jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Mon, May 25, 2015 at 11:03:13AM +0100, fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote: > From: Fu Wei > > Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, > and create a platform device with that information. > This platform device can be used by the ARM SBSA Generic > Watchdog driver. > > Tested-by: Suravee Suthikulpanit > Tested-by: Timur Tabi > Signed-off-by: Fu Wei > --- > arch/arm64/kernel/acpi.c | 145 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 145 insertions(+) Why does this all need to be under arch/arm64? The GTDT really isn't architecture-specific, so I'd *much* rather it was parsed in the driver code itself, like we already do for the architected timer. The GIC is an exception because it's in the MADT, which we need to parse in the arch code to configure SMP properly. Will -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html