From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbbEZSYN (ORCPT ); Tue, 26 May 2015 14:24:13 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:56925 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbbEZSYJ (ORCPT ); Tue, 26 May 2015 14:24:09 -0400 Date: Tue, 26 May 2015 11:24:03 -0700 From: Guenter Roeck To: Timur Tabi Cc: Hanjun Guo , fu.wei@linaro.org, Suravee.Suthikulpanit@amd.com, linaro-acpi@lists.linaro.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, tekkamanninja@gmail.com, graeme.gregory@linaro.org, al.stone@linaro.org, ashwin.chaugule@linaro.org, arnd@arndb.de, vgandhi@codeaurora.org, wim@iguana.be, jcm@redhat.com, leo.duran@amd.com, corbet@lwn.net, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Subject: Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device Message-ID: <20150526182403.GA23370@roeck-us.net> References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-7-git-send-email-fu.wei@linaro.org> <55642EA8.5000003@linaro.org> <5564A0C7.1090306@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5564A0C7.1090306@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=0.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2015 at 11:35:19AM -0500, Timur Tabi wrote: > On 05/26/2015 03:28 AM, Hanjun Guo wrote: > > >> early_acpi_os_unmap_memory((char *)table, tbl_size); > >> } > > > >please add > > > >#ifdef CONFIG_ARM_SBSA_WATCHDOG > >(acpi gtdt code) > >#endif > > I don't agree with this. The GTDT should be parsed even if there's no > watchdog driver compiled for this kernel. There are no other #ifdefs in > this file. > Me not either, but then I thought this is really a maintainer question. If the maintainers want out-of-subsystem #ifdefs in the code, who am I to complain. Should be "#if IS_ENABLED(CONFIG_ARM_SBSA_WATCHDOG)", though, if we go along that route. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device Date: Tue, 26 May 2015 11:24:03 -0700 Message-ID: <20150526182403.GA23370@roeck-us.net> References: <=fu.wei@linaro.org> <1432548193-19569-1-git-send-email-fu.wei@linaro.org> <1432548193-19569-7-git-send-email-fu.wei@linaro.org> <55642EA8.5000003@linaro.org> <5564A0C7.1090306@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5564A0C7.1090306-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Timur Tabi Cc: Hanjun Guo , fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org, linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tekkamanninja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, ashwin.chaugule-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leo.duran-5C7GfCeVMHo@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, May 26, 2015 at 11:35:19AM -0500, Timur Tabi wrote: > On 05/26/2015 03:28 AM, Hanjun Guo wrote: > > >> early_acpi_os_unmap_memory((char *)table, tbl_size); > >> } > > > >please add > > > >#ifdef CONFIG_ARM_SBSA_WATCHDOG > >(acpi gtdt code) > >#endif > > I don't agree with this. The GTDT should be parsed even if there's no > watchdog driver compiled for this kernel. There are no other #ifdefs in > this file. > Me not either, but then I thought this is really a maintainer question. If the maintainers want out-of-subsystem #ifdefs in the code, who am I to complain. Should be "#if IS_ENABLED(CONFIG_ARM_SBSA_WATCHDOG)", though, if we go along that route. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html