From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Date: Sat, 30 May 2015 08:48:00 -0700 Message-ID: <20150530084800.56e3585e@urahara> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Liang-Min Larry Wang Return-path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 3BA501DB1 for ; Sat, 30 May 2015 17:47:58 +0200 (CEST) Received: by pdbqa5 with SMTP id qa5so75002537pdb.0 for ; Sat, 30 May 2015 08:47:57 -0700 (PDT) In-Reply-To: <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 29 May 2015 20:37:56 -0400 Liang-Min Larry Wang wrote: > adding a new library based upon ethdev APIs to provide API's that bear > the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops > (linux/netdevice.h). The API's for ethtool like things are valuable, but please contain it more. I think you should contain this to only those things which are in the original Linux ethtool. Adding yet another layer that calls DPDK for open/close/start stop just adds more layers with out providing any value. The ones I would keep: get_driverinfo get_link The ones I would add: cmd - for speed/duplex negotiation eeprom - for eeprom access eee - for energy awareness coalesce - for packet coalescing ringparam - to allow changing ring parameters (existing rx config model is limiting) pauseparam - existing flow control in DPDK is mess gstrings/stats - map to XSTATS test - for offline tests dump - for register dump features - control offload features perm_addr - base mac address