From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Date: Sun, 31 May 2015 09:48:28 -0700 Message-ID: <20150531094828.371263fe@urahara> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1432946276-9424-3-git-send-email-liang-min.wang@intel.com> <20150530084800.56e3585e@urahara> <20150530122617.1bf2cd18@urahara> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" To: "Wang, Liang-min" Return-path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id AC70F12A8 for ; Sun, 31 May 2015 18:48:34 +0200 (CEST) Received: by padj3 with SMTP id j3so26967725pad.0 for ; Sun, 31 May 2015 09:48:34 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 30 May 2015 19:40:46 +0000 "Wang, Liang-min" wrote: > > On Sat, 30 May 2015 16:16:01 +0000 > "Wang, Liang-min" wrote: > > > >The design decision is to keep ethdev as THE interface for all the external API, so ethtool APIs are designed based upon ethdev API. At the meantime, the ethtool APIs are designed to enable users to migrate designs based upon kernel-space ethtool. The open/close/start are put in place to enable quick migration. > > > >But there is no open/close/start in ethtool in kernel. > >Anyway ethtool is currently on the disfavored list from kernel developers. > >What about netlink or something better? > > > >Remember each new API creates more long term compatiablity and ABI issues. > >So I am against introducing any new API that does the same thing as existing API's. > > Just to clarify APIs supported by this ethtool api: there are net_open and net_stop and no net_start. Both functions are put in place to support net_device_ops::ndo_open and net_device_ops::ndo_close as defined in linux/netdevice.h I get the feeling there is some use case you are not telling the list about. What kind of application would use this api only. Why or how would DPDK application be involved in net_device_ops. If you are planning on putting DPDK in the kernel there are lots of other issues including kernel ABI stability and licensing that need to be dealt with.